fluid-work IRC Logs-2012-07-23

[09:27:43 CDT(-0500)] <jhung> justin_o, I checked out your changes and will be looking at the styling.

[09:27:54 CDT(-0500)] <Justin_o> jhung: thanks

[09:28:08 CDT(-0500)] <Justin_o> i'm working on disabling the custom output settings form fields now

[09:31:38 CDT(-0500)] <jhung> justin_o: looks good! I made a 200x200cm Type 3 PDF and worked fine.

[09:32:04 CDT(-0500)] <jhung> I just realized we don't have a method of accessing the OCR text generated by Type 2+

[09:37:00 CDT(-0500)] <Justin_o> jhung: what do you mean? returning the text file?

[09:38:08 CDT(-0500)] <jhung> Yeah. So right now the user only gets the PDF, but not the Text file.

[09:38:52 CDT(-0500)] <Justin_o> jhung: hmm

[09:38:57 CDT(-0500)] <Justin_o> jhung: yes.. that's the case

[09:39:01 CDT(-0500)] <jhung> There should be a way of the user to download that justin_o. My gut feeling is adding a 3rd link, but I like just have 2 links after generating the PDF.

[09:39:28 CDT(-0500)] <Justin_o> jhung: yah.. you don't want to clutter things

[09:39:42 CDT(-0500)] <Justin_o> jhung: how necessary is it for this release..

[09:39:49 CDT(-0500)] <Justin_o> could we add it in the next release instead

[09:41:33 CDT(-0500)] <jhung> I guess not critical Justin_o. I guess add it to the list of things to do if we suddenly found ourselves with an extra day. (tongue)

[09:42:20 CDT(-0500)] <jhung> also, should we add Type 4 to the list of PDFs. It shouldn't be hard to add, right?

[09:43:06 CDT(-0500)] <Justin_o> jhung: yes.. planning to do that.. just wanted to get all the output settings stuff in place first

[09:43:24 CDT(-0500)] <jhung> ok cool.

[13:02:29 CDT(-0500)] <asteig> Hi Justin_o, jhung. (big grin)

[13:02:47 CDT(-0500)] <Justin_o> asteig: hello

[13:02:50 CDT(-0500)] <Justin_o> how are things going

[13:03:02 CDT(-0500)] <asteig> Hold on, let me commit. Things are going well.

[13:04:03 CDT(-0500)] <jhung> hey asteig

[13:04:26 CDT(-0500)] <Justin_o> asteig: that's great to hear

[13:04:38 CDT(-0500)] <asteig> jhung, Justin_o: Okay, just pushed the changes I made. It's a little messy.

[13:04:57 CDT(-0500)] <asteig> But figured out all of the infusion stuff, and refactored a ton. Have placeholders for the algorithms.

[13:05:19 CDT(-0500)] <asteig> Not exactly where I want to be but made a ton of progress this week and it's all tying together really quickly. (smile)

[13:06:07 CDT(-0500)] <jhung> checking it out now asteig...

[13:13:08 CDT(-0500)] <asteig> jhung, Justin_o: For some reason my indenting always shows up really horribly on github but looks fine locally.

[13:13:22 CDT(-0500)] <asteig> I think I've been playing around with my vimrc too much.

[13:15:22 CDT(-0500)] <Justin_o> asteig: my guess is that you have a mix of spaces and tabs for your indentations.. we try to replace all tabs with 4 spaces, although this is just the convention we adopted.The important thing is to be consistent. You should be able to run this through swarm.fluidproject.org/jslint to catch the cases where there is a mix.. to catch the rest you might want to turn on your invisible characters in your editor to se

[13:15:23 CDT(-0500)] <Justin_o> what the whitespaces actually are

[13:17:19 CDT(-0500)] <asteig> Justin_o: Running it through now. Thanks for the tip. (smile)

[13:17:48 CDT(-0500)] <Justin_o> asteig: no problem..

[13:23:45 CDT(-0500)] <Justin_o> asteig: by the way, i think you forgot to commit your instance of MyInfusion.js

[13:24:07 CDT(-0500)] <asteig> Good catch, Justin_o. You are correct. (smile) Thanks.

[13:24:52 CDT(-0500)] <asteig> My mind is already set to Defcon. Hard to focus. LOL

[13:31:36 CDT(-0500)] <asteig> Justin_o, jhung, I'm using eval for something silly. Do you mind taking a look at line 84 of ImageAdjuster.js and giving me some feedback on other ideas on how to approach that particular line of code?

[13:31:48 CDT(-0500)] <asteig> As jsLint kindly pointed out, it truly is evil.

[13:35:00 CDT(-0500)] <asteig> If you refresh it should be far less painful now, guys. (wink)

[13:38:31 CDT(-0500)] <Justin_o> asteig: yes.. that looks better.. thanks (smile)

[13:39:36 CDT(-0500)] <Justin_o> asteig: so if i'm reading this correctly.. you are trying to assign the value for each of the properties in editor.imageAdjuster.adjustments

[13:40:52 CDT(-0500)] <Justin_o> from the looks of it there should be no need for eval here at all.. your an use the array notation to get what you are looking for.

[13:41:28 CDT(-0500)] <Justin_o> editor.imageAdjuster.adjustments[key] = value

[13:44:08 CDT(-0500)] <Justin_o> by the way you seem to have assigned k to key but haven't used it.

[13:44:43 CDT(-0500)] <Justin_o> asteig: ^

[13:44:48 CDT(-0500)] <asteig> Thanks! (big grin)

[13:45:15 CDT(-0500)] <asteig> Yeah, I was pretty tired when I wrote that. That's why I just put whatever there to wait until my eyes could focus on letters again.

[13:45:31 CDT(-0500)] <Justin_o> asteig: (smile) I know how that is

[13:46:13 CDT(-0500)] <Justin_o> asteig: you might actually want to move editor.imageAdjuster.adjustments into a model on the component.. since it seems that this is something that is specific to an instance of the component.

[13:46:52 CDT(-0500)]

<Justin_o> if you add model:

Unknown macro: {brightness}

to your defaults.. it will be accessible though that.model

[13:47:22 CDT(-0500)] <asteig> Cool, thanks! (smile)

[13:47:33 CDT(-0500)] <asteig> Also, I fell off the TDD train. Haha

[13:47:40 CDT(-0500)] <asteig> I need to write new tests, but after I wrote the code.

[13:49:08 CDT(-0500)] <Justin_o> asteig: yah… i know.. sometimes you just really want to write the code… try to stick with it as much as possible.. it will help you in the long run.. but falling off from time to time is understandable