fluid-work IRC Logs-2013-11-04

[06:38:24 CST(-0600)] <chrispetsos> Justin_o: Hi, do you have some time for a question?

[07:37:01 CST(-0600)] <Justin_o> chrispetsos: hello.. how are you?

[07:37:33 CST(-0600)] <chrispetsos> Hi Justin_o: i'm fine thanks.

[07:39:35 CST(-0600)] <chrispetsos> Justin_o: well, actually i was employing the repeatingSelector technique to create the two bottom adjusters shown here (http://160.40.60.238/prefsEditors/demos/adjustersPilots2/), "Magnifier location follows:" and " Screen reader follows: "

[07:41:00 CST(-0600)] <Justin_o> okay, looks like they are rendering out well

[07:41:04 CST(-0600)] <Justin_o> chrispetsos: ^

[07:41:57 CST(-0600)] <chrispetsos> Justin_o: Tried to reuse as much of their code as possible, but there were problems with their values. It seemed that the value of the one was copied to the other and vice-versa

[07:43:02 CST(-0600)] <chrispetsos> Justin_o: after some experiments, i've managed to solve this, but with less reused code. the changes can be shown here https://github.com/chrispetsos/prefsEditors/commit/3ccf4a526249a73ad2eb4b32236d5764ddf5a7b3

[07:43:22 CST(-0600)] <chrispetsos> Justin_o: "Basically, everything that has to do with the repeatingSelector mechanism (and anything dependent on that) had to be uniquely specified in the sub-adjusters."

[07:43:54 CST(-0600)] <chrispetsos> Justin_o: if you think there is any more delicate solution i'm open...

[07:47:20 CST(-0600)] <Justin_o> chrispetsos: so looking through your changes there.. gpii.prefs.panel.followingElement as a base grade.

[07:48:24 CST(-0600)] <Justin_o> chrispetsos: so one thing, which it seems you've run into, is that protoTrees don't merge. You'll have to write this out into each of your specific panel grades. I think the repeatingSelectors should merge though.

[07:52:59 CST(-0600)] <chrispetsos> Justin_o: previously, protoTrees only existed in the base grade, while now they only exist in the sub-adjusters. I've never had to merge protoTrees. I hoped that a single protoTree in the base grade would be shared correctly among two adjusters but it seems that something went wrong with the repeatingSelector technique

[07:53:52 CST(-0600)] <chrispetsos> Justin_o: I suspect that the expander used there searched throughout the page and found some IDs twice. leading to conflicts, but i'm not exactly sure about that

[07:54:14 CST(-0600)] <Justin_o> chrispetsos: that's possible, did you get an error or anything?

[07:58:10 CST(-0600)] <chrispetsos> Justin_o: Nope no errors there. I've checked out here http://160.40.60.238/prefsEditors/demos/adjustersPilots2/ the problematic version. Play around a bit with the bottom adjusters to get a feeling of what goes wrong.

[07:59:10 CST(-0600)] <chrispetsos> And the files that should interest you at that version are: 1) https://github.com/chrispetsos/prefsEditors/blob/5eda943f1e91055f4ee6fa4e8549d32327b22a43/src/shared/adjusters/js/FollowingElementAdjuster.js, 2) https://github.com/chrispetsos/prefsEditors/blob/5eda943f1e91055f4ee6fa4e8549d32327b22a43/src/shared/adjusters/js/MagnifierFollowsFollowingElementAdjuster.js, 3) https://github.com/chrispetsos/prefsEditors/blob/5eda943f1

[07:59:24 CST(-0600)] <chrispetsos> Justin_o: 3) https://github.com/chrispetsos/prefsEditors/blob/5eda943f1e91055f4ee6fa4e8549d32327b22a43/src/shared/adjusters/js/ScreenReaderFollowsFollowingElementAdjuster.js

[08:22:43 CST(-0600)] <Justin_o> chrispetsos: thanks.. i'll take a look at those

[08:30:50 CST(-0600)] <chrispetsos> Justin_o: OK , thanks, perhaps we will be able to employ a better solution when the composite panel is available

[09:13:40 CST(-0600)] <amilchev> hey Justin_o, how are you?

[09:19:04 CST(-0600)] <cindyli> anastasiac: the fix for 5203 for having more than one text field slider in one composite panel has been included in a pull request. I also modified your PFID branch to demonstrate what changes are required for integrators to use this fix: https://github.com/cindyli/infusion/tree/anastasia-PFID, you may want to take a look

[09:20:16 CST(-0600)] <anastasiac> thanks, cindyli, I'll have a look

[09:21:52 CST(-0600)] <Justin_o> amilchev: hello.. i'm alright.. how are things going?

[09:25:55 CST(-0600)] <amilchev> Justin_o: it's OK, things are moving along

[09:26:28 CST(-0600)] <Justin_o> amilchev: that's good..

[09:27:17 CST(-0600)] <amilchev> Justin_o: I faced some strange issues today and decided to ask you first, perhaps the problem is little

[09:27:25 CST(-0600)] <amilchev> wait a sec..

[09:27:31 CST(-0600)] <Justin_o> amilchev: sure

[09:32:10 CST(-0600)] <amilchev> Justin_o: first of all, this is the file to run - https://github.com/radmanovi4/prefsEditors/blob/gpii-271/demos/pcp/index.html

[09:34:10 CST(-0600)] <amilchev> Justin_o: have a look at this function - https://github.com/radmanovi4/prefsEditors/blob/gpii-271/src/shared/adjusters/pcp/js/speakText.js#L213-L216

[09:34:10 CST(-0600)]

[09:35:32 CST(-0600)] <Justin_o> yes, better to pass in the value you need directly

[09:36:32 CST(-0600)]

[09:37:06 CST(-0600)] <amilchev> Justin_o: Yeah, exactly, but that value is undefined when the header is clicked

[09:37:37 CST(-0600)] <amilchev> and thus nothing it's the the hideEvent() that is always fired

[09:37:55 CST(-0600)] <Justin_o> ah okay.. new feature

[09:38:01 CST(-0600)] <amilchev> and thus it's the the hideEvent() that is always fired *

[09:38:02 CST(-0600)] <Justin_o> you need to add another property there

[09:38:13 CST(-0600)] <Justin_o> so in your showHidePartial invoker declaration

[09:38:28 CST(-0600)] <Justin_o> you need to add the key/value dynamic: true

[09:39:05 CST(-0600)]

[09:39:13 CST(-0600)]

[09:40:04 CST(-0600)] <Justin_o> amilchev: yep same thing there.. set it directly to the value and make the invoker dynamic

[09:40:06 CST(-0600)] <amilchev> Justin_o: uh, that explains why most of the animation I tried to configure was .. messed up

[09:40:57 CST(-0600)] <Justin_o> amilchev: yes.. sorry about that.. keep forgetting about all of the infusion changes that have gone in.. one other thing that has changes is how you can work with strings.. I'm updating the docs on this now..

[09:40:58 CST(-0600)] <amilchev> Justin_o: I found this in MyInfusion.js - is this what I need to do?

[09:40:58 CST(-0600)] <amilchev> handleStyle: {

[09:40:58 CST(-0600)] <amilchev> funcName: "fluid.prefs.enactors.styleElements.handleStyle",

[09:40:58 CST(-0600)]

[09:40:58 CST(-0600)] <amilchev> dynamic: true

[09:40:59 CST(-0600)] <amilchev> },

[09:41:14 CST(-0600)] <Justin_o> amilchev: yes.. that's it

[09:41:59 CST(-0600)] <amilchev> Justin_o: ok, I'm glad it's such a small issue will fix it right away

[09:42:01 CST(-0600)] <amilchev> thank you

[09:42:32 CST(-0600)] <Justin_o> amilchev: let me know if you come across any other issues..

[09:43:42 CST(-0600)] <amilchev> Justin_o: as far as acknowledging new Infusion features being added - I suggest posting on the list whenever a new doc is completed, as Anastasia promised to do with the composite panel

[09:44:30 CST(-0600)] <amilchev> Justin_o: sure, no problem.. I'm actually taking off, have a nice day

[09:45:06 CST(-0600)] <Justin_o> amilchev: good suggestion.. have a good day..

[10:13:03 CST(-0600)] <Justin_o> anastasiac: i've updated the localization in the prefs framework doc.. i'm sure it could use some touchups though http://wiki.fluidproject.org/display/docs/Localization+in+the+Preferences+Framework

[10:13:21 CST(-0600)] <anastasiac> Thanks, Justin_o, I'll have a look

[10:13:44 CST(-0600)] <Justin_o> anastasiac: thanks

[10:16:11 CST(-0600)] <Justin_o> jhung: are you ready to talk about FSS stuff at the community meeting this week?

[10:17:16 CST(-0600)] <jhung> Justin_o: can we schedule next Wednesday? I have an appointment this Wednesday and won't be in the office.

[10:17:24 CST(-0600)] <Justin_o> jhung: no problem

[10:17:32 CST(-0600)] <jhung> Justin_o: cool thanks

[10:17:32 CST(-0600)] <Justin_o> jhung: so Nov 13