fluid-work IRC Logs-2013-10-02

[08:17:47 CDT(-0500)] <colinclark> jhernandez: How are the PUPPIES?

[08:21:12 CDT(-0500)] <Justin_o> yzen: hello.. so i pushed up a few more changes to my FLUID-5131 branch.. it includes new tests for the actual rendering..

[08:22:20 CDT(-0500)] <Justin_o> yzen: the rendering does happen properly, but the tests fail. I believe they are failing because the subPanels are still working off of the old pre-rendering DOM nodes

[08:22:30 CDT(-0500)] <Justin_o> yzen: any thoughts on this?

[08:25:52 CDT(-0500)] <jhernandez> colinclark: they are fantastic!

[08:26:23 CDT(-0500)] <jhernandez> all their business are sleep and eat

[08:26:24 CDT(-0500)] <jhernandez>

[08:26:47 CDT(-0500)] <colinclark> cute!

[08:28:23 CDT(-0500)] <yzen_> Justin_o: when we rewrite selector stuff we use the names not the actual jquery objects right ?

[08:29:01 CDT(-0500)] <Justin_o> yzen_: yes that's correct..

[08:29:54 CDT(-0500)] <yzen_> Justin_o: also the sub panels are initialized before the rendering of the panel happens right ?

[08:31:54 CDT(-0500)] <Justin_o> yzen_: that's also correct

[08:32:32 CDT(-0500)] <yzen_> Justin_o: does it make sense to init them after or we need some resolved options ?

[08:35:11 CDT(-0500)] <Justin_o> yzen_: yes.. we need resolved options for the templates and the selectors

[08:35:45 CDT(-0500)] <Justin_o> yzen_: i believe the latter is because we need to know what the components container will be so that we can scope the new selectors in the parent to that

[08:36:30 CDT(-0500)] <Justin_o> yzen_: i suppose we could experiment with getting around those

[08:38:47 CDT(-0500)] <yzen_> or perhaps we can use the actual jquery objects instead of names

[08:39:30 CDT(-0500)] <Justin_o> yzen_: what do you mean?

[08:40:08 CDT(-0500)]

[08:41:03 CDT(-0500)] <Justin_o> yzen_: i think the selectors in the parent work... although i haven't tried.. but they render out.. so i'd guess so.. but it's the selectors in the subPanel's themselves no longer work

[08:42:18 CDT(-0500)] <yzen_> ya i feel like once we initialized the component it gets messed up if we change those things afterwards

[08:42:47 CDT(-0500)] <Justin_o> yzen_: so i took another look and the selectors don't use the resolved components.. i'll look at the other one again

[08:44:15 CDT(-0500)] <Justin_o> actually it doesn't look like any of them do.. so i can try calling init afterRender.. although the afterRender event is shared.. so that would pose a different issue.

[08:46:26 CDT(-0500)] <Justin_o> yzen_: the produceTree method needs the resolved component

[08:46:38 CDT(-0500)] <yzen_> hmm

[08:47:19 CDT(-0500)] <Justin_o> yzen_: it needs a reference to the subPanel for getting the expanderOptions, creating the expander, and calling the panel's produceTree method

[08:47:28 CDT(-0500)] <yzen_> right yes

[08:51:12 CDT(-0500)] <clown> good day jhernandez! Have a moment?

[08:55:56 CDT(-0500)] <Justin_o> cindyli: is there a way to pass something down to subcomponents by grade instead of membername using IoCSS?

[08:57:46 CDT(-0500)] <cindyli> Justin_o: you mean to pass down a grade name into subcomponent's gradeNames list, or merge options of the grade into the subcomponent?

[09:04:49 CDT(-0500)] <Justin_o> cindyli: basically i want to change the subcomponents options, for all components of a certain type

[09:10:42 CDT(-0500)] <yzen_> Justin_o, cindyli what would you think the best current strategy is to reconfigure invokers(or other component options for that matter) in test environment without using demands ?

[09:10:52 CDT(-0500)] <cindyli> Justin_o: i'm thinking you can add the grade that contains all the options directly to "gradeNames" of those subcomponents beforehand, so you don't need to use IoCSS. wonder if you have the grade dynamically generated, don't have its name ahead and cannot do it this way?

[09:11:28 CDT(-0500)] <Justin_o> cindyli: i was doing this, but can't anymore

[09:11:28 CDT(-0500)] <cindyli> yzen_: pass down the reconfigured invoker via IoCSS

[09:11:43 CDT(-0500)] <yzen_> cindyli: nice thanks

[09:12:08 CDT(-0500)] <cindyli> Justin_o: why?

[09:12:33 CDT(-0500)] <jhernandez> clown: morning!

[09:12:52 CDT(-0500)] <clown> jhrernandez, good afternoon.

[09:13:02 CDT(-0500)] * clown can't sepll...

[09:13:11 CDT(-0500)] <clown> jhernandez: good afternoon.

[09:13:48 CDT(-0500)] <jhernandez> right now I'm on a meeting

[09:13:49 CDT(-0500)] <clown> I was looking at the testing urls you gave me, and at other examples, and discovered that there two kinds of testing.

[09:13:55 CDT(-0500)] <clown> ah, okay. I can wait.

[09:14:00 CDT(-0500)] <jhernandez> clown: ok

[09:14:23 CDT(-0500)] <jhernandez> anyhoo ... yes! I passed them to you because of that

[09:14:37 CDT(-0500)] <jhernandez> you can use one of these approaches

[09:14:38 CDT(-0500)] <jhernandez>

[09:14:42 CDT(-0500)] <clown> shall I wait? Or ask my questions?

[09:15:37 CDT(-0500)] <jhernandez> ask them later

[09:16:27 CDT(-0500)] <jhernandez> meanwhile, update your nodepackageKit branch, I have made a helpful change

[09:16:28 CDT(-0500)] <jhernandez>

[09:16:59 CDT(-0500)] <clown> okay. time to git stash...

[09:17:02 CDT(-0500)] <clown> maybe.

[09:18:13 CDT(-0500)] <clown> later, jhernandez. Have a productive meeting.

[09:22:29 CDT(-0500)] <Justin_o> cindyli, yzen_: thanks for talking things over.. okay.. so here's the crazy solution... the subPanels are created on an event called initSubPanels. This event is triggered by both the onCreate and afterRender events from the parent.. This unfortunately puts the burden of adding a createOnEvent declaration for the integrator.. The second issue was that we

[09:22:29 CDT(-0500)] <Justin_o> actually needed to share the afterRender event down to the subPanel, but of course it is too late now.. to get around this, there is a new subPanelAfterRender event which is fired as the "last" listener to the parents "afterRender" and triggers the subPanel's afterRender event

[09:22:56 CDT(-0500)] <jhernandez> clown: that's the commit -> https://github.com/javihernandez/linux/commit/004dd60c3083801ab6f2be6a0739e18ce558cb23

[09:23:57 CDT(-0500)] <clown> jhernandez: thanks. I'll get to it. I'm on a roll with testing; don't want to stop just now.

[09:28:00 CDT(-0500)] <jhernandez> np

[09:28:05 CDT(-0500)] <jhernandez> it was JFYI

[10:01:00 CDT(-0500)] <Justin_o> cindyli: i added some documentation for how the compositePanel works to the jira http://issues.fluidproject.org/browse/FLUID-5131

[10:01:59 CDT(-0500)] <cindyli> thanks, Justin_o, i will read thru

[10:03:34 CDT(-0500)] <Justin_o> cindyli: thanks, hopefully it will make sense

[10:05:48 CDT(-0500)] <anastasiac> Justin_o, the compositePanel is something that's going to need to be documented as part of the Preferences Framework, no?

[10:07:37 CDT(-0500)] <Justin_o> anastasiac: yes it will be

[10:08:00 CDT(-0500)] <anastasiac> ok, I'll file a docs JIRA and reference your comments on 5131, so this doesn't get lost

[10:08:10 CDT(-0500)] <anastasiac> I'll assign it to you, Justin_o

[10:09:04 CDT(-0500)] <Justin_o> anastasiac: thanks.. for now the changes are just in my branch but i'll look into the documentation on the wiki once it's in the repo.

[10:09:25 CDT(-0500)] <anastasiac> yep. that's why I'm filing it and not copying your notes to the wiki now

[10:09:59 CDT(-0500)] <Justin_o> anastasiac: okay.. makes sense

[10:10:19 CDT(-0500)] <Justin_o> anastasiac: we should probably also write docs for panels in general and enactors i guess, if you don't have tasks for those down alreaday

[10:10:49 CDT(-0500)] <anastasiac> I think I have a task for that, Justin_o, but I'll double-check

[10:11:01 CDT(-0500)] <Justin_o> anastasiac: thanks

[10:12:22 CDT(-0500)] <anastasiac> Justin_o, do you think there's any advantage or disadvantage of creating a "Prefs Framework" JIRA component and starting to tag issues with it at this point?

[10:12:49 CDT(-0500)] <cindyli> Justin_o: i sent a pull request https://github.com/fluid-project/infusion/pull/411 to make fat panel onReady returns itself rather than "uiOptions". can you take a look when you have a chance?

[10:12:53 CDT(-0500)] <Justin_o> anastasiac: i guess that makes sense.. i'll create one nwo

[10:13:42 CDT(-0500)] <anastasiac> Thanks, Justin_o. I was just thinking it would be handy to have it, so I could more easily scan the prefs-framework related tech docs issues

[10:14:02 CDT(-0500)] <Justin_o> anastasiac: i've added it now.. you should be able to re-assign issues to it

[10:14:12 CDT(-0500)] <anastasiac> thanks, Justin_o

[10:15:11 CDT(-0500)] <Justin_o> cindyli: sure, will do

[10:15:24 CDT(-0500)] <cindyli> thanks, Justin_o

[10:29:09 CDT(-0500)] <Justin_o> cindyli: I'm having a problem running the builder tests

[10:30:05 CDT(-0500)] <cindyli> Justin_o: in IE8, that's a same issue with master branch. i created a jira for that: http://issues.fluidproject.org/browse/FLUID-5166

[10:39:13 CDT(-0500)] <jessm> fluid-everyone: i'm on the C4A coordinator meeting where they're defining the next deliverable for the pilots. i'll miss standup. i'm continuing to articulate the various tools in the pref. editing ecosystem with Gregg. we're making progress...

[10:59:34 CDT(-0500)] <Justin_o> cindyli: merged in your pull request for FLUID-5162

[11:00:06 CDT(-0500)] <cindyli> yay! thanks, Justin_o

[11:46:37 CDT(-0500)] <jhung> Justin_o, if vjoanna is in the office today. Can you show her https://github.com/fluid-project/prefsEditors/pull/52?

[11:47:13 CDT(-0500)] <clown> jhernandez: I've updated to your latest, and rebuilt. But I don't see any output from the new progress, and installPackage no longer works. Does progressCallBack() output for you?

[11:49:17 CDT(-0500)] <Justin_o> jhung: i did that this morning

[11:49:26 CDT(-0500)] <Justin_o> left you some comments from my code review there as well

[11:49:52 CDT(-0500)] <jhung> ok Justin_o thanks! I'll take a look.

[12:03:20 CDT(-0500)] <jhernandez> clown: you have to set DEGUG to TRUE

[12:03:21 CDT(-0500)] <jhernandez>

[12:03:41 CDT(-0500)] <clown> d'oh!

[12:03:44 CDT(-0500)] <jhernandez>

[12:03:47 CDT(-0500)] <jhernandez> and it works

[12:03:52 CDT(-0500)] <jhernandez> at least to me

[12:04:55 CDT(-0500)] <clown> that explains why progress wasn't working for me. But, you need DEBUG for installPackage() as well?

[12:05:35 CDT(-0500)] * clown making the change, and rebuilding...

[12:05:38 CDT(-0500)] <jhernandez> nope

[12:05:41 CDT(-0500)] <jhernandez> DEBUG is global

[12:06:09 CDT(-0500)] <jhernandez> I added the progressCallback function to the three transactions (search, install and remove)

[12:07:54 CDT(-0500)] <clown> yes, I see.

[12:08:05 CDT(-0500)] <clown> rebuilt, and now I see progress. +1

[12:15:26 CDT(-0500)] <clown> jhernandez: but installPackage() is not installing anything.

[12:15:42 CDT(-0500)] <clown> well, it's not installing 'tuxguitar'

[12:15:52 CDT(-0500)] * clown tries some other package.

[12:16:41 CDT(-0500)] <jhernandez> why not?

[12:16:56 CDT(-0500)] <clown> dunno. that's what I was askin you.

[12:17:09 CDT(-0500)] <jhernandez> is installing anything? is tuxguitar maybe already installed?

[12:17:42 CDT(-0500)] <clown> no, tuxguitar is not installed. both 'yum info' and searchPackage confirm that.

[12:17:58 CDT(-0500)] <clown> when I run installPackage(), progress reports:

[12:18:13 CDT(-0500)] <clown> [nodePackagekit] Transaction status: wait

[12:18:13 CDT(-0500)] <clown> [nodePackagekit] Transaction status: finished

[12:18:14 CDT(-0500)] <clown> true

[12:18:21 CDT(-0500)] <jhernandez> ok

[12:18:24 CDT(-0500)] <clown> but it isn't installed.

[12:18:51 CDT(-0500)] <jhernandez> maybe bitten by the "sometimes doesn't work" bug?

[12:18:52 CDT(-0500)] <jhernandez> heh

[12:18:58 CDT(-0500)] <jhernandez> call it twice

[12:19:00 CDT(-0500)] <jhernandez> xDDD

[12:19:48 CDT(-0500)] <clown> maybe … I'll try it twice. and then I'm going to try another package (dtach) because that was working on Mon.

[12:20:01 CDT(-0500)] <jhernandez> weird ...

[12:20:10 CDT(-0500)] <jhernandez> it's working here

[12:21:45 CDT(-0500)] <clown> nope, neither dtach nor tuxradio install here.

[12:21:56 CDT(-0500)] <clown> I called installPackage four times.

[12:22:02 CDT(-0500)] <clown> no luck.

[12:22:28 CDT(-0500)] <clown> it isn't something silly like I need to be super user, is it?

[12:23:05 CDT(-0500)] <jhernandez> nope

[12:23:08 CDT(-0500)] <jhernandez> you don't need to be root

[12:23:15 CDT(-0500)] <clown> hmmmm….

[12:23:18 CDT(-0500)] * clown thinks

[12:23:40 CDT(-0500)] <jhernandez> try to go back to the previous commit, build it, and try again

[12:24:06 CDT(-0500)] <jhernandez> AFAIK there is nothing critical in my last commit

[12:24:10 CDT(-0500)] * clown git reset —soft HEAD^

[12:24:15 CDT(-0500)] <jhernandez> --hard

[12:24:23 CDT(-0500)] <jhernandez> git reset --harg HEAD^

[12:24:27 CDT(-0500)] <jhernandez> *hard

[12:24:29 CDT(-0500)] <jhernandez>

[12:26:44 CDT(-0500)] <clown> I like "harg" better...

[12:40:19 CDT(-0500)] <clown> jhernandez: I gone back one commit, rebuilt, and installPackage doesn't work for that one as well.

[12:40:27 CDT(-0500)] <clown> So: something wrong with my machine.

[12:40:57 CDT(-0500)] * clown thinks some more

[12:43:55 CDT(-0500)] <jhernandez> mmm

[12:44:18 CDT(-0500)] * jhernandez thinking and talking to people who want to adopt puppies

[12:44:25 CDT(-0500)] <jhernandez>

[12:45:29 CDT(-0500)] <jhernandez> clown: maybe a stupid question but ... are you passing the package's id to install the install method?

[12:46:01 CDT(-0500)] <jhernandez> yesterday a few times I tried to install by passing the package's name

[12:46:03 CDT(-0500)] <jhernandez> and not the id

[12:46:24 CDT(-0500)] <jhernandez> xD

[12:46:25 CDT(-0500)] <clown> not a dumb question at all.

[12:46:26 CDT(-0500)] * clown hits forehead with hand.

[12:47:40 CDT(-0500)] <jhernandez> really?

[12:47:41 CDT(-0500)] <jhernandez> xDDDD

[12:53:25 CDT(-0500)] <clown> really, jhernandez. that was the problem. I have updated to your latest, recompiled, set DEBUG to TRUE, and now things install.

[12:53:37 CDT(-0500)] <jhernandez> pheeww

[12:53:40 CDT(-0500)] * clown hangs head in shame

[12:53:45 CDT(-0500)] <jhernandez> xDDD

[12:53:59 CDT(-0500)] <clown> okay. back to my unit tests.

[12:54:15 CDT(-0500)] <jhernandez> clown: ok

[12:54:36 CDT(-0500)] <jhernandez> I have to run out in an hour or so

[12:54:53 CDT(-0500)] <jhernandez> JFYI

[12:55:06 CDT(-0500)] <clown> cool. I should be fine. If I have questions, I'll post them here. If you are gone, I'll email you.

[12:55:26 CDT(-0500)] <clown> thanks for your help, as always.

[13:20:30 CDT(-0500)] <jhernandez> clown: yw

[13:20:58 CDT(-0500)] <clown> jhernandez: I have successful unit tests for search and install. On to remove....

[13:21:08 CDT(-0500)] <jhernandez> yay!

[13:22:01 CDT(-0500)] * jhernandez is looking forward to see that pull request :]

[13:24:54 CDT(-0500)] <clown> jhernandez: not a big github user, so I may (will) need guidance on how to put the stuff there.

[13:25:04 CDT(-0500)] <Justin_o> fluid-everyone: would anyone like to join the community meeting remotely today. We'll be continuing our work on grunt and the infusion build scripts

[13:33:34 CDT(-0500)] <Justin_o> Bosmon7: so we have the first pass at FLUID-5131 done. https://github.com/jobara/infusion/tree/FLUID-5131

[13:34:18 CDT(-0500)] <Justin_o> Bosmon7: however cindyli and I noticed an issue.. There currently isn't a way for the compositePanel to do it's own rendering..

[13:37:22 CDT(-0500)] <Justin_o> Bosmon7: do you have any thoughts on this.. the problem is that the produce tree needs to be defined to assemble those from it's subcomponents

[13:55:15 CDT(-0500)] <clown> jhernandez: all the test work!

[13:55:20 CDT(-0500)] <clown> *tests even

[14:04:15 CDT(-0500)] <jhernandez> clown: awesome!

[14:04:45 CDT(-0500)] <jhernandez> I'm about to leave

[14:05:14 CDT(-0500)] <clown> So: I'm not looking at github documentation to see how to put it on my github. I'm thinking I have to fork your packagekitBridge first? Oh, go ahead if you have to.

[14:05:20 CDT(-0500)] <clown> gahh!

[14:05:24 CDT(-0500)] <clown> I'm NOW looking

[14:05:28 CDT(-0500)] <jhernandez> I'm going with my parents for the diner

[14:05:43 CDT(-0500)] <jhernandez> heh

[14:05:43 CDT(-0500)] <clown> I thought you had something to do with puppies.

[14:06:03 CDT(-0500)] * clown hopes you aren't dining on them

[14:06:10 CDT(-0500)] * clown grody.

[14:06:12 CDT(-0500)] <jhernandez> you have to clone my personal fork, and then change to the branch

[14:06:35 CDT(-0500)] <clown> I did that. But, I did that on my test machine.

[14:06:43 CDT(-0500)] <clown> not on my github account.

[14:06:55 CDT(-0500)] <jhernandez> create your personal branch where you're going to make commits, and then create the pull request when done

[14:07:10 CDT(-0500)] <jhernandez> clown: yes, it's different from gnome

[14:07:10 CDT(-0500)] <clown> "create your personal branch" where?

[14:07:15 CDT(-0500)] <jhernandez> heh

[14:07:16 CDT(-0500)] <jhernandez> xDD

[14:07:21 CDT(-0500)] <clown> Indeed it is different.

[14:07:30 CDT(-0500)] <clown> gnome uses the "central repository" method.

[14:07:43 CDT(-0500)] <clown> even though the tool is git.

[14:08:13 CDT(-0500)] <clown> I presume I "create your personal branch" on github. How?

[14:08:24 CDT(-0500)] <jhernandez> yup

[14:08:36 CDT(-0500)] <jhernandez> the workflow is:

[14:08:40 CDT(-0500)] <jhernandez> fork my repo on Github

[14:08:50 CDT(-0500)] * clown I was right!

[14:08:54 CDT(-0500)] * clown go on.

[14:09:02 CDT(-0500)] <jhernandez> heh

[14:09:03 CDT(-0500)] <jhernandez> or

[14:09:16 CDT(-0500)] <jhernandez> well

[14:09:17 CDT(-0500)] <jhernandez> heh

[14:09:19 CDT(-0500)] <clown> I wrote: "I'm thinking I have to fork your packagekitBridge first? " four minutes ago.

[14:09:29 CDT(-0500)] <jhernandez> I'm used to use remotes

[14:09:53 CDT(-0500)] <jhernandez> IMVHO, the best workflow could be:

[14:10:00 CDT(-0500)] <jhernandez> 1. fork GPII/linux on Github

[14:10:16 CDT(-0500)] <jhernandez> 2. get your personal copy of the recently forked repo

[14:10:31 CDT(-0500)] <jhernandez> 3. add javihernandez/linux as a remote

[14:11:27 CDT(-0500)] <jhernandez> 4. git checkout javihernandez/packagekitBridge -b <name-of-your-branch>

[14:11:45 CDT(-0500)] <jhernandez> 5. do changes

[14:12:04 CDT(-0500)] <jhernandez> 6. push your new branch to Github

[14:12:31 CDT(-0500)] <jhernandez> 7. make a pull request from your new branch to javihernandez/packagekitBridge

[14:13:04 CDT(-0500)] <jhernandez> 8. I will (or maybe not) accept the changes

[14:13:05 CDT(-0500)] <jhernandez> xDDDD

[14:13:11 CDT(-0500)] <clown> "GPII/linux on Github" (step 1) = https://github.com/javihernandez/linux/tree/master, right?

[14:13:28 CDT(-0500)] <jhernandez> https://github.com/GPII/linux

[14:13:50 CDT(-0500)] <clown> yeah, that makes more sense. (*what is my browser telling me???)

[14:14:05 CDT(-0500)] <jhernandez> xDDD

[14:14:23 CDT(-0500)] <jhernandez> or

[14:14:32 CDT(-0500)] <clown> all that makes sense, but I don't know how to do 7.

[14:14:36 CDT(-0500)] <jhernandez> git://github.com/GPII/linux.git

[14:14:43 CDT(-0500)] <jhernandez> heh

[14:15:01 CDT(-0500)] <jhernandez> it's easy

[14:15:15 CDT(-0500)] <clown> but i just found: https://help.github.com/articles/creating-a-pull-request

[14:15:40 CDT(-0500)] <jhernandez> clown: got it!

[14:16:04 CDT(-0500)] * clown pats himself on the back.

[14:16:40 CDT(-0500)] <clown> okay, go have a nice meal with your parents. Say "hi" for me.

[14:16:42 CDT(-0500)] <clown>

[14:16:49 CDT(-0500)] <jhernandez> now I gotta run for the diner

[14:17:18 CDT(-0500)] <jhernandez> I hope that my brothers haven't ate all the stuff

[14:17:18 CDT(-0500)] <jhernandez>

[14:17:33 CDT(-0500)] <clown> jhernandez: you are just a puppy in your own litter.

[14:17:49 CDT(-0500)] <clown> ciao!

[14:18:09 CDT(-0500)] <jhernandez> hehehe

[14:18:20 CDT(-0500)] <jhernandez> thx clown

[14:18:25 CDT(-0500)] <jhernandez> see you!