/
fluid-work IRC Logs-2011-09-02

fluid-work IRC Logs-2011-09-02

Sept 02, 2011

[08:25:50 CDT(-0500)] <michelled> cindyli, yura: I've pushed the fixes for 4370 from Justin/Cindy/Antranig
[08:26:16 CDT(-0500)] <michelled> here's what's left for the release: http://issues.fluidproject.org/secure/ConfigureReport.jspa?filterid=10128&amp;mapper=resolution&amp;selectedProjectId=10001&amp;reportKey=com.atlassian.jira.plugin.system.reports%3Asinglelevelgroupby&amp;Next=Next
[08:26:45 CDT(-0500)] <michelled> could you two pick up something from the blockers list?
[08:27:16 CDT(-0500)] <cindyli> sure, michelled
[08:27:28 CDT(-0500)] <michelled> I think Bosmon said he's look at 4374 but I don't think he got started on it yet
[08:28:15 CDT(-0500)] * michelled wishes that her grammar would also get auto corrected
[08:35:53 CDT(-0500)] <cindyli> yura, michelled, i will work on 4418
[09:06:40 CDT(-0500)] <yura> cindyli, michelled, i m taking on FLUID-4412
[09:42:24 CDT(-0500)] <michelled> cindyli: which JIRA are you working on?
[09:42:38 CDT(-0500)] <cindyli> 4418
[09:42:39 CDT(-0500)] <heidi_> michelled how do i pull up that list of remaining jiras ?
[09:42:55 CDT(-0500)] <michelled> here's the report heidi_ http://issues.fluidproject.org/secure/ConfigureReport.jspa?filterid=10128&amp;mapper=resolution&amp;selectedProjectId=10001&amp;reportKey=com.atlassian.jira.plugin.system.reports%3Asinglelevelgroupby&amp;Next=Next
[09:43:00 CDT(-0500)] <heidi_> tanks
[09:43:02 CDT(-0500)] <michelled> yura: which one is yours?
[09:43:54 CDT(-0500)] <yura> 4412
[09:44:19 CDT(-0500)] <heidi_> michelled are there any major styling jiras that have yet to be reviewed/added to master
[09:44:48 CDT(-0500)] <michelled> everything is in at this point heidi_
[09:45:03 CDT(-0500)] <michelled> I think justin_o had gone over his changes with you
[09:45:33 CDT(-0500)] <michelled> but you might want to look at what's in master right now and see what you think
[09:45:35 CDT(-0500)] <heidi_> michelled okay cool i'll update my trunk and see what i can pick up...
[09:45:45 CDT(-0500)] <michelled> cool - thanks
[09:47:35 CDT(-0500)] <michelled> hey mlam - have you picked up a release blocker yet?
[09:48:06 CDT(-0500)] <mlam> hey michelled, not yet. let me take a look at the logs to see what's been taken
[09:48:18 CDT(-0500)] <michelled> cool thx
[09:54:28 CDT(-0500)] <michelled> fluid-everyone: I'd like to restart the build so we can see the lasted
[09:54:38 CDT(-0500)] <michelled> anastasiac: will you do the honours please?
[09:54:48 CDT(-0500)] <anastasiac> on the way...
[09:57:26 CDT(-0500)] <mlam> michelled: it seems a few of the jiras are related to justin's latest branch
[09:57:42 CDT(-0500)] <mlam> is there a jira that hasn't been spoken for and is separate from justin's branch?
[09:58:01 CDT(-0500)] <mlam> i guess 4368?
[09:58:37 CDT(-0500)] <anastasiac> fluid-everyone, the build should be redeployed now
[10:05:35 CDT(-0500)] <michelled> mlam: justin's branch is in now
[10:05:44 CDT(-0500)] <michelled> unless there was one I didn't know about
[10:05:51 CDT(-0500)] <michelled> which branch are you talking about?
[10:05:52 CDT(-0500)] <mlam> ok
[10:06:34 CDT(-0500)] <mlam> i can't remember exactly, but there were a couple JIRAs with comments made about their relation to justin's branch
[10:06:51 CDT(-0500)] <mlam> but anyways, i can take a look at FLUID-4368
[10:11:57 CDT(-0500)] <michelled> cool
[10:13:05 CDT(-0500)] <heidi_> michelled should i pick from blockers or critical? are we focussing on blockers?
[10:13:35 CDT(-0500)] <michelled> we are focussing on blockers heidi_
[10:14:11 CDT(-0500)] <michelled> but if you only have a tiny bit of time and you think you can whip out some criticals then go for it
[10:14:18 CDT(-0500)] <heidi_> k
[10:21:42 CDT(-0500)] <heidi_> michelled is antranig still working on FLUID-4374
[10:26:16 CDT(-0500)] <heidi_> michelled i'll try 4362 fyi
[10:26:43 CDT(-0500)] <michelled> heidi_: not sure about Antranig - I'll check in with him when he comes online
[10:27:16 CDT(-0500)] <michelled> heidi_: that would be great - so it looks like Justin's fixes fixed the with preview version
[10:27:29 CDT(-0500)] <michelled> so maybe you can compare the two versions and see what's different
[10:27:45 CDT(-0500)] <heidi_> k
[11:36:24 CDT(-0500)] <cindyli> michelled: i sent a pull request on 4418, can u code review? thanks
[11:36:34 CDT(-0500)] <michelled> thanks cindyli - I'm looking now
[11:36:49 CDT(-0500)] <cindyli> cool
[11:39:47 CDT(-0500)] <michelled> cindyli: do you think you could take on 4376?
[11:40:19 CDT(-0500)] <cindyli> michelled: i'm actually looking at this one but cannot re-produce
[11:40:38 CDT(-0500)] <cindyli> michelled: show/hide link does get color changed and font changed
[11:40:54 CDT(-0500)] <michelled> cindyli: does the size change too?
[11:40:54 CDT(-0500)] <mlam> michelled: so I'll change 4368 to a blocker for 1.5?
[11:41:08 CDT(-0500)] <michelled> mlam: yep, that would be great
[11:41:14 CDT(-0500)] <cindyli> yes, michelled
[11:43:18 CDT(-0500)] <michelled> fluid-everyone: we're going to rebuild nightly again
[11:43:22 CDT(-0500)] <michelled> anastasiac: please (smile)
[11:43:48 CDT(-0500)] <anastasiac> building...
[11:44:23 CDT(-0500)] <michelled> Bosmon: you are working on 4374, right?
[11:47:26 CDT(-0500)] <Bosmon> michelled - yes - I guess FLUID-4294 should go along with
[11:47:27 CDT(-0500)] <Bosmon> it
[11:48:11 CDT(-0500)] <cindyli> Bosmon: if you are workin on 4374, i want to let you know what i find out so you don't have to look over again
[11:48:19 CDT(-0500)] <Bosmon> ok, thanks
[11:48:28 CDT(-0500)] <cindyli> Bosmon: "make input larger" looks for "input" tag
[11:48:50 CDT(-0500)] <cindyli> uiEnhancer.js, line 272
[11:48:59 CDT(-0500)] <cindyli> the button is actually using <button> tag
[11:49:34 CDT(-0500)] <cindyli> Bosmon: adding in "button" detection should fix the issue
[11:50:04 CDT(-0500)] <michelled> mlam: looks like you get your pick of the criticals (smile)
[11:50:19 CDT(-0500)] <mlam> yah (smile)
[11:50:21 CDT(-0500)] <mlam> looks like it
[11:50:52 CDT(-0500)] <cindyli> Bosmon: i'm thinking of the case that <img> tag is used for button-look stuff, should we handle this kind of case?
[11:54:37 CDT(-0500)] <heidi_> yura if you're busy with cspace i can take a look at 4412
[11:55:21 CDT(-0500)] <heidi_> michelled i sent a pull for 4362
[11:55:41 CDT(-0500)] <yura> heidi_: sure i can pick it up as soon as i m done there
[11:58:32 CDT(-0500)] <cindyli> Bosmon: thanks for fixing my code on 4370. i guess you must have stayed quite late last night. (smile)
[12:01:18 CDT(-0500)] <michelled> mlam: please assign the jura to yourself when you pick one up (if you haven't already) (smile)
[12:01:46 CDT(-0500)] <mlam> yah, i will. i'm still scanning the list
[12:06:04 CDT(-0500)] <heidi_> michelled can you still recreate this? http://issues.fluidproject.org/browse/FLUID-4412
[12:06:52 CDT(-0500)] <mlam> michelled: i'm taking on 4373
[12:07:04 CDT(-0500)] <michelled> heidi_: yes - on the demo portal
[12:07:05 CDT(-0500)] <heidi_> did you mean http://build.fluidproject.org/infusion/demos/uiOptions/html/uiOptions.html or is there a different demo portal link
[12:07:14 CDT(-0500)] <heidi_> url?
[12:07:20 CDT(-0500)] <michelled> heidi_: http://build.fluidproject.org/infusion/demos/uiOptions/demo.html
[12:07:35 CDT(-0500)] <heidi_> ah, duh, thanks (smile)
[12:07:40 CDT(-0500)] <michelled> np (smile)
[12:09:03 CDT(-0500)] <heidi_> michelled is it there if you make your browser window wider ?
[12:09:56 CDT(-0500)] <michelled> heidi_: nope - my window is as wide as it goes
[12:10:12 CDT(-0500)] <michelled> I still get the behaviour that's in the screen shot on the JIRA
[12:10:21 CDT(-0500)] <heidi_> there's something up with the sizing of that iframe's width.... UIO is seeing it as wider than it is. so the link is there, just off-screen
[12:11:14 CDT(-0500)] <heidi_> if i move my browser window way left so it's off-screen and continue to resize it wider, i see it
[12:18:36 CDT(-0500)] <michelled> heidi_: do you think it's something you can fix?
[12:18:51 CDT(-0500)] <michelled> I know the demo portal is on the chopping block but I don't know when we'll get to it
[12:21:40 CDT(-0500)] <heidi_> michelled i'm going to try (smile)
[12:47:22 CDT(-0500)] <michelled> heidi_: I looked at your pull for 4362 - the inputs are still quite crazy with respect to the icons and the labels
[12:48:28 CDT(-0500)] <heidi_> michelled wewps i fixed the button icons, not the inputs. will do that now. oh, brain
[12:48:47 CDT(-0500)] <michelled> heidi_: np! thanks for looking (smile)
[13:50:40 CDT(-0500)] <Bosmon> cindyli - thanks for looking at that issue - do I need to do anything on it?
[13:51:07 CDT(-0500)] <Bosmon> [11:01] <michelled> mlam: please assign the jura to yourself when you pick one up (if you haven't already) (smile)
[13:51:10 CDT(-0500)] <Bosmon> The JURA has been assigned!!
[13:51:17 CDT(-0500)] <Bosmon> Perhaps it will escape early from the filing cabinet
[13:51:55 CDT(-0500)] <mlam> (smile)
[13:52:54 CDT(-0500)] <cindyli> Bosmon: do u want me to take on 4374?
[13:54:15 CDT(-0500)] <Bosmon> Ah, I thought you solved it already?
[13:54:36 CDT(-0500)] <Bosmon> You said "adding in button detection should fix the issue"?
[13:57:57 CDT(-0500)] <cindyli> lol
[13:58:27 CDT(-0500)] <cindyli> Bosmon: i will fix it
[14:00:03 CDT(-0500)] <michelled> Bosmon: you can tell it's a Friday before a long weekend - assign the JURA!
[14:00:35 CDT(-0500)] <michelled> cindyli: do you know what we need to add the size specifically to the button tags?
[14:00:39 CDT(-0500)] <michelled> it seems so hacky
[14:01:32 CDT(-0500)] <cindyli> michelled: you mean why?
[14:01:57 CDT(-0500)] <michelled> yes, that's what I meant - I'm glad you can read my mind since I clearly can't type what's in it today
[14:02:16 CDT(-0500)] <cindyli> honestly, i don't know and no luck from the research.
[14:02:30 CDT(-0500)] <cindyli> need heidi_'s help (wink)
[14:02:32 CDT(-0500)] <michelled> heidi_: do you have any thoughts on this?
[14:03:01 CDT(-0500)] <heidi_> readin..
[14:03:20 CDT(-0500)] <michelled> you might need to look at the pull request or cindyli can explain maybe
[14:03:27 CDT(-0500)] <heidi_> ill check the req
[14:08:54 CDT(-0500)] <heidi_> cindyli michelled there's prob a better way. but i'm also noticing in the demo that the links to the other UIO's aren't affected either
[14:09:18 CDT(-0500)] <heidi_> oh wait might be my UIO css... sec
[14:10:13 CDT(-0500)] <heidi_> no it happens on http://build.fluidproject.org/infusion/demos/uiOptions/html/uiOptions.html as well
[14:10:32 CDT(-0500)] <heidi_> michelled anastasiac did newest UIO css get created on latest build?
[14:11:26 CDT(-0500)] <anastasiac> heidi_, I didn't do anything in particular - I assume that the general build process should create the css as a matter of course. michelled, can you confirm that?
[14:17:00 CDT(-0500)] <michelled> anastasiac: yes, it will - maybe we should rebuild again? I can't remember when we last rebuilt
[14:18:00 CDT(-0500)] <anastasiac> michelled, heidi_: it was last built at 12:45 - do you want me to rebuild?
[14:18:27 CDT(-0500)] <heidi_> i think that's fine - just making sure the uio css got refreshed today
[14:19:13 CDT(-0500)] <michelled> I can't remember when my last push was
[14:19:27 CDT(-0500)] <heidi_> so yeah michelled , cindyli i don't think that's the way to solve 4376... the issue extends beyond the hide/show button (the demo links as well). think the styles in the body need to have !importants
[14:20:06 CDT(-0500)] <heidi_> no that doesn't do it - but it's something with UIO not over-riding
[14:20:45 CDT(-0500)] <cindyli> heidi_: seems it's only not overriding button tags
[14:21:27 CDT(-0500)] <heidi_> cindyli i wonder if browsers set button text size by default - perhaps it's something fss-reset needs to reset
[14:22:08 CDT(-0500)] <heidi_> cindyli font-size and font-family should be "inherit" in fss-reset-base i think
[14:22:12 CDT(-0500)] <heidi_> for buttons
[14:23:09 CDT(-0500)] <cindyli> I wonder how to do that, heidi_
[14:23:30 CDT(-0500)]

<heidi_> cindyli button

Unknown macro: { font-family}

[14:24:01 CDT(-0500)] <cindyli> ah, i see. trying
[14:24:32 CDT(-0500)] <heidi_> cindyli not sure about fss-reset or fss-base .... which one makes sense or even if we want this as a default, maybe just appropriate for UIO. michelled thoughts?
[14:28:13 CDT(-0500)] <michelled> interesting question heidi_
[14:28:30 CDT(-0500)] <michelled> I think it makes sense in fss-reset but I suppose that might be considered an API change?
[14:28:36 CDT(-0500)] <michelled> I think it would be a good one though
[14:28:51 CDT(-0500)] <michelled> heidi_: if you feel good about that let's go that strategy
[14:29:20 CDT(-0500)] <heidi_> michelled i think having buttons sizes be inherited makes sense as a reset ya
[14:29:32 CDT(-0500)] <heidi_> sounds good - cindyli, that solves the issue right?
[14:29:37 CDT(-0500)] <michelled> heidi_, cindyli: perhaps one of you could describe the change to the list though so we can get other opinions early
[14:30:07 CDT(-0500)] <michelled> I mean, we should fix it and get it into master but also describe the fix to the community (smile)
[14:30:15 CDT(-0500)] <cindyli> still trying, heidi_
[14:31:16 CDT(-0500)] <heidi_> so i guess <button> seems to have a browser default, which isn't over-ridden by UIO. reseting those values to inherit from its parent styles them correctly
[14:37:19 CDT(-0500)] <cindyli> heidi_: super, setting "inherit" solves the issue. thanks a lot
[14:37:46 CDT(-0500)] <heidi_> cool
[14:37:51 CDT(-0500)] <cindyli> heidi_: the next thing is, as u said, which css file is the right place for button "inherit" to go
[14:38:01 CDT(-0500)] <cindyli> for now, i use "uiOptions.css"
[14:38:14 CDT(-0500)] <cindyli> is that ok, heidi_
[14:38:40 CDT(-0500)] <cindyli> or you think fss-base or fss-reset is better?
[14:38:40 CDT(-0500)] <heidi_> cindyli michelled and i think fss-reset tho it'll require an API change.... uiOptions.css wouldn't. michelled ?
[14:40:35 CDT(-0500)] <heidi_> cindyli i guess the two reset files and make sure anastasiac for doc purposes
[14:41:31 CDT(-0500)] <cindyli> ok, heidi_
[14:41:49 CDT(-0500)] <anastasiac> cindyli, if you change the FSS files, feel free to update the docs accordingly (smile)
[14:42:12 CDT(-0500)] <cindyli> sure, anastasiac
[14:44:15 CDT(-0500)] <cindyli> heidi_: 2 reset files are fss-reset-context.css and fss-reset-global.css, right?
[14:44:37 CDT(-0500)] <heidi_> cindyli yep. fss-rest alone is deprecated
[14:44:57 CDT(-0500)] <cindyli> thanks, heidi_
[14:59:55 CDT(-0500)] <cindyli> heidi_: pushed the css change into my github, can you have a look: https://github.com/cindyli/infusion/commit/df7e95add32f72b1f96e2383e4d39e76a5546964
[15:00:56 CDT(-0500)] <heidi_> cindyli looks good!
[15:02:00 CDT(-0500)] <cindyli> thanks, heidi_
[15:02:29 CDT(-0500)] <cindyli> michelled: 4376 is ready for further review. (smile)
[15:02:34 CDT(-0500)] <michelled> cindyli: 4374 is ready to be pushed, right?
[15:02:39 CDT(-0500)] <cindyli> yes
[15:02:40 CDT(-0500)] <michelled> thx cindyli
[15:02:43 CDT(-0500)] <cindyli> np
[15:02:44 CDT(-0500)] <michelled> I'll look at both
[15:02:55 CDT(-0500)] <cindyli> thanks
[15:06:09 CDT(-0500)] <cindyli> heidi_ & anastasiac, regarding the change i've made on fss-reset-global & fss-reset-context, i wonder which API i should update
[15:06:45 CDT(-0500)] <anastasiac> cindyli, check if this page describes anything that you've changed: http://wiki.fluidproject.org/display/fluid/FSS+Cheat+Sheet
[15:07:08 CDT(-0500)] <anastasiac> there are also other pages linked-to from that page that you could check, depending on what's changed, cindyli
[15:07:24 CDT(-0500)] <michelled> cindyli: can you also mail the list telling everyone of the API change?
[15:07:41 CDT(-0500)] <cindyli> thanks, anastasiac, i will have a look
[15:09:19 CDT(-0500)] <cindyli> michelled: i certainly can. i'm just thnking what i should explain to everyone the effect of this change since I myself don't even know
[15:10:28 CDT(-0500)] <cindyli> i don't think it's good to paste my css code in the mail
[15:10:28 CDT(-0500)] <heidi_> cindyli we've discovered <button> seems to have a browser default, which isn't over-ridden by UIO. reseting those values to inherit from its parent styles them correctly
[15:11:10 CDT(-0500)] <cindyli> aha, heidi_, thanks
[15:11:45 CDT(-0500)] <heidi_> cindyli maybe make sure it looks good in all teh browsers
[15:11:50 CDT(-0500)] <heidi_> that it works
[15:11:52 CDT(-0500)] <heidi_> esp IE
[15:12:23 CDT(-0500)] <cindyli> thanks for the reminding, heidi_
[15:17:51 CDT(-0500)] <cindyli> heidi_, michelled, works well in ff, safari, chrome, all on windows. not ie6, which is a known issue that we have 4427 for it
[15:18:05 CDT(-0500)] <heidi_> cool
[15:18:20 CDT(-0500)] <michelled> (smile)