fluid-work IRC Logs-2013-07-24

[07:53:08 CDT(-0500)] <Justin_o> heidiv: just looking at your FLUID-5080 pull request now..

[07:53:18 CDT(-0500)] <heidiv> thanks Justin_o

[07:53:46 CDT(-0500)] <Justin_o> heidiv: so i realized the other day that we can't use this in demo until the UIO integration is done.. particularly because the UIO variant of the theme isn't being generated

[07:54:23 CDT(-0500)] <heidiv> Justin_o what is left for UIO integration? do you mean the schema work?

[07:54:23 CDT(-0500)] <Justin_o> heidiv: so we can either add that change into this pull request or get the UIO integration jira finished up. What do you think would be better?

[07:54:34 CDT(-0500)] <heidiv> oh, n/m

[07:54:37 CDT(-0500)] <heidiv> i know what you mean

[07:54:45 CDT(-0500)] <Justin_o> heidiv: okay.. good (smile)

[07:55:03 CDT(-0500)] <heidiv> Justin_o how about we keep them sep jiras. i'll work on UIO integration once this is pulled in?

[07:55:43 CDT(-0500)] <Justin_o> heidiv: okay.. I'm going to be finishing that up in the next minute or two

[07:58:38 CDT(-0500)] <Justin_o> heidiv: your pull request for FLUID-5080 is now in the repo

[08:00:11 CDT(-0500)] <heidiv> Justin_o cool thanks i'll work on 5087 now

[08:00:22 CDT(-0500)] <Justin_o> heidiv: thanks

[08:00:29 CDT(-0500)] <Justin_o> let me know if you need any help with that

[08:00:34 CDT(-0500)] <heidiv> k

[08:04:35 CDT(-0500)] <heidiv> Justin_o fyi sent a small pull req for gpii-141 just now

[08:05:59 CDT(-0500)] <Justin_o> heidiv: is that all that is needed for gpii-141?

[08:06:19 CDT(-0500)] <heidiv> Justin_o is what all that's needed?

[08:06:56 CDT(-0500)] <Justin_o> the pull request you sent.. will the jira be resolvable once this goes in?

[08:07:31 CDT(-0500)] <heidiv> Justin_o yes it just adds a search input to the demo resource header

[08:12:23 CDT(-0500)] <Justin_o> heidiv: made a minor comment on the jira

[08:12:28 CDT(-0500)] <Justin_o> sorry, pull request

[08:12:59 CDT(-0500)] <heidiv> Justin_o i'll make those changes, thank yoU!

[08:13:42 CDT(-0500)] <Justin_o> heidiv: thanks, let me know when you've updated the pull request and i'll look at it again

[08:15:17 CDT(-0500)] <heidiv> Justin_o updated!

[08:17:25 CDT(-0500)] <Justin_o> heidiv: thanks.. i'll take another look now

[08:19:06 CDT(-0500)] <heidiv> Justin_o i might wait on 5087 until joanna's in… to ask if both LC themes should be added to the panel or just one. thoughts?

[08:19:07 CDT(-0500)] <Justin_o> heidiv: so the only thing is that the search field is styled differently in safari.. is that okay for you?

[08:19:19 CDT(-0500)] <Justin_o> heidiv: sure, that makes sense

[08:19:55 CDT(-0500)] <heidiv> Justin_o i see… re: safari. hmm

[08:20:56 CDT(-0500)] <Justin_o> heidiv: it's styled more like a native search field.. which i guess is more consistent with the platform, but less consistent from browser to browser

[08:21:29 CDT(-0500)] <heidiv> Justin_o i feel like uniform across browsers pref. reading http://demosthenes.info/blog/343/Forcing-A-Consistent-Appearance-For-the-HTML5-Search-Input-Across-All-Browsers

[08:23:33 CDT(-0500)] <heidiv> Justin_o pull req updated

[08:23:50 CDT(-0500)] <Justin_o> heidiv: thanks

[08:26:16 CDT(-0500)] <heidiv> vjoanna there are two new low contrast themes in infusion and i'm wanting to add them to the UIO theme panel. one is light grey on dark grey and the other is the reverse. Should we add both to the panel or just one? thoughts?

[08:26:53 CDT(-0500)] <Justin_o> heidiv: your pull request for GPII-141 is in the fluid-project/prefsEditors repo

[08:27:02 CDT(-0500)] <heidiv> cheers Justin_o

[08:27:50 CDT(-0500)] <vjoanna> heidiv: i think just one for now - what's the high-contrast theme we're using black on white?

[08:28:11 CDT(-0500)] <heidiv> vjoanna yes b on w

[08:29:45 CDT(-0500)] <vjoanna> heidiv: let's do light grey on dark then - so that it's the opposite of the high contast.. what do you think?

[08:29:59 CDT(-0500)] <heidiv> vjoanna that sounds good to me, thanks!

[08:32:00 CDT(-0500)] <Justin_o> yzen, cindyli: where are we at with the schema work?

[08:35:19 CDT(-0500)] <cindyli> Justin_o: we've fixed all failing unit tests; i'm working on applying the new schema structure. the status is the demo is running with the new structure but need to clean up the code a bit and fix unit tests for aux builder and builder. yzen is working on http://issues.fluidproject.org/browse/FLUID-4986

[08:36:03 CDT(-0500)] <jessm> anastasiac: ping

[09:05:50 CDT(-0500)] <anastasiac> jessm, pong

[09:06:31 CDT(-0500)] <jessm> anastasiac: let's jump on skype and chat about this zero proj. thingy

[09:06:36 CDT(-0500)] <jessm> if you can now

[09:06:57 CDT(-0500)] <anastasiac> k, give me a sec

[09:09:05 CDT(-0500)] <Justin_o> cindyli: you mean yzen is fixing that issue or he is updating our implementation to make use of it

[09:17:00 CDT(-0500)] <yzen> Justin_o: both

[09:17:59 CDT(-0500)] <Justin_o> yzen: so that hasn't gone into the project repo yet?

[09:18:20 CDT(-0500)] <yzen> no, Justin_o, it' will require a fix to renderer utils

[09:20:04 CDT(-0500)] <Justin_o> yzen: okay… thanks for the update

[09:20:15 CDT(-0500)] <Justin_o> yzen, cindyli: did either of you need help with anything?

[09:22:00 CDT(-0500)] <cindyli> Justin_o: you can pair up with either of us or work on the next issue, which is i18n, it's half way thru in one of my branch

[09:23:37 CDT(-0500)] <Justin_o> cindyli: i'm not quite sure where you are at with your work, would you prefer i pair with you, or would it be better for me to continue on with the i18n work?

[09:24:16 CDT(-0500)] <Justin_o> cindyli, yzen: also i just tried the demo and it looks like emphasize links isn't working properly

[09:24:28 CDT(-0500)] <cindyli> oh no

[09:25:11 CDT(-0500)] <cindyli> Justin_o: let's pair up first

[09:25:26 CDT(-0500)] <Justin_o> cindyli: okay

[10:30:27 CDT(-0500)] <Justin_o> cindyli, yzen, michelled, Bosmon: i'm making an early pull request for FLUID-4907 so that we can start getting feedback and code review on it now. I'll make this from my branch and merge in your changes into it.

[10:30:45 CDT(-0500)] <colinclark> cool

[10:33:22 CDT(-0500)] <Justin_o> https://github.com/fluid-project/infusion/pull/371

[11:24:39 CDT(-0500)] <heidiv> Justin_o fyi sent a pull req for low contrast theme added to UIO

[11:25:06 CDT(-0500)] <Justin_o> heidiv: thanks.. i'll take a look at it in a bit… just finishing up something for the schema work

[11:25:23 CDT(-0500)] <heidiv> no rush

[11:38:52 CDT(-0500)] <Justin_o> yzen, cindyli: finished added unit tests for the auxbuilder.. they are all passing. i've pushed this up to my branch

[11:39:04 CDT(-0500)] <cindyli> great, thanks Justin_o

[11:44:12 CDT(-0500)] <Justin_o> heidiv: looking at your pull request. The css generation for the uio is not happening. You'll need to update a file in the build-scripts for this. I have a note on the jira that should help with how to do this.

[11:44:26 CDT(-0500)] <heidiv> Justin_o perfect, ty

[11:48:19 CDT(-0500)] <jhung1> vjoanna: remember last week how we were going over the high-contrast theme for the discovery tool? The colour scheme for the panel is white on black. But the show/hide bar is black on white and it would be difficult to change it. My question is: is it okay to change the discovery tool high contrast theme from white on black to black on white?

[11:54:56 CDT(-0500)] <Justin_o> michelled: what do you think of me sending a pull request from fluid-project/prefsEditors to gpii/prefsEditors right now

[11:55:13 CDT(-0500)] <michelled> sounds like a good idea Justin_o

[11:59:45 CDT(-0500)] <vjoanna> jhung1: does that change the contrast theme for the rest of the content?

[12:00:44 CDT(-0500)] <jhung1> No. The contrast theme for the content is black on white. So the Discovery Tool will match that theme now. This means, at least for the demo, we'll have to add additional styling to distinguish the DT panel from the content.

[12:00:49 CDT(-0500)] <jhung1> ^vjoanna

[12:04:09 CDT(-0500)] <vjoanna> jhung1: I'm worried that if the discovery tool panel colours are not inverted, it won't stand out enough from the rest of the content.. and we would have to use a lot of outlines which might make it look really cluttered

[12:04:46 CDT(-0500)] <vjoanna> why is it difficult to change the show/hide bar?

[12:04:52 CDT(-0500)] <jhung1> vjoanna: yes that is a concern.

[12:05:56 CDT(-0500)] <jhung1> The show-hide bar takes on the same theme as the content - so it will be black on white since the content is that way. I'd assume we'd have to modify the component to fix this vjoanna. heidiv does that sound about right?

[12:09:04 CDT(-0500)] <jhung1> vjoanna: perhaps as a compromise, we can do black on white for the demo, but intend to fix it to be white on black at a later time? Justin_o, do you think we'll have time to fix the panel bar or should it be filed for another time?

[12:25:29 CDT(-0500)] <heidiv> jhung1 actually we might be able to do some theming of the panel bar … when the body theme is bw, we could change the style of the panel bar to be wb

[12:25:41 CDT(-0500)] <heidiv> in the css

[12:25:46 CDT(-0500)] <heidiv> do you want to try that in 134?

[12:26:01 CDT(-0500)]

<heidiv> .theme-bw .panel-bar

Unknown macro: { w on b }

kinda thing

[12:29:52 CDT(-0500)] <jhung1> we can try that heidiv. I'll include it in GPII-134

[12:42:26 CDT(-0500)] <Justin_o> jhung_away: what's the problem with it?

[12:47:15 CDT(-0500)] <heidiv> Justin_o updated 5087 fyi. and re: panel bar theming, think it's gonna be fine

[12:50:49 CDT(-0500)] <Justin_o> heidiv: okay.. i'll take a look at your pull request again

[12:58:38 CDT(-0500)] <Justin_o> heidiv: left you another comment on the pull request.. i think you need to generate the uio style sheets for both lgdg and dglg because of the fl-inverted

[12:59:01 CDT(-0500)] <heidiv> Justin_o right… thanks

[12:59:09 CDT(-0500)] <Justin_o> and i guess that also means they'll both need to be imported to each html page

[12:59:23 CDT(-0500)] <heidiv> ok

[13:10:59 CDT(-0500)] <Justin_o> heidiv: put up another comment.. i just noticed a bug

[13:11:44 CDT(-0500)] <heidiv> Justin_o ah interesting… jquery theming maybe…. :|

[13:12:13 CDT(-0500)] <Justin_o> heidiv: could be for the sliders.. I'm pretty sure the on/off toggle is custom though

[13:12:37 CDT(-0500)] <heidiv> yeah

[13:14:22 CDT(-0500)] <heidiv> Justin_o can't replicate - clear cache?

[13:15:07 CDT(-0500)] <Justin_o> heidiv: could be.. let me try that

[13:16:09 CDT(-0500)] <Justin_o> heidiv: yep.. looks like that was it..

[13:16:29 CDT(-0500)] <heidiv> k

[13:18:28 CDT(-0500)] <Justin_o> heidiv: okay.. this should be the last thing.. there are broken unit tests, because they were expecting only 5 contrasts and now there are 6. UIOptions tests, and Panels tests have failures

[13:18:46 CDT(-0500)] <heidiv> k

[13:24:41 CDT(-0500)] <Justin_o> yzen: do i need to do anything to get the "speak" preset to work on my machine in chrome

[13:24:52 CDT(-0500)] <yzen> no

[13:24:56 CDT(-0500)] <Justin_o> I'm trying to test out your GPII-125 pull request

[13:25:33 CDT(-0500)] <Justin_o> yzen: i'm not hearing anything in either the master or your branch

[13:25:45 CDT(-0500)] <yzen> Justin_o: let me see

[13:26:12 CDT(-0500)] <Justin_o> yzen: okay.. never mind.. i'm hearing it now

[13:26:12 CDT(-0500)] <Justin_o> maybe my volume was too low or something

[13:26:21 CDT(-0500)] <yzen> (smile)

[13:27:08 CDT(-0500)] <Justin_o> works in safari too

[13:30:03 CDT(-0500)] <Justin_o> yzen: in GPII-125 the correct jira?

[13:30:34 CDT(-0500)] <Justin_o> http://issues.gpii.net/browse/GPII-125

[13:30:53 CDT(-0500)] <yzen> Justin_o: it was originally meant for anastasiac's GPII-125 branch

[13:31:03 CDT(-0500)] <Justin_o> yzen: okay

[13:34:47 CDT(-0500)] <Justin_o> anastasiac: can GPII-125 be resolved now.. http://issues.gpii.net/browse/GPII-125

[13:35:02 CDT(-0500)] <Justin_o> or are there other things that need to go into the fluid-project/prefsEditors repo

[13:35:03 CDT(-0500)] <Justin_o> ?

[13:35:33 CDT(-0500)] <anastasiac> Justin_o, I don't have permissions to resolve/close issues in the GPII issue tracker

[13:36:24 CDT(-0500)] <Justin_o> anastasiac: okay.. but it should be resolved?

[13:36:37 CDT(-0500)] <anastasiac> justn_o, your comment just now on GPII-125 referred to a pull request for GPII-141?

[13:36:49 CDT(-0500)] <anastasiac> and yes, it probably should be resolved

[13:36:53 CDT(-0500)] <anastasiac> 125, that is

[13:37:23 CDT(-0500)] <Justin_o> anastasiac: thanks (sad)

[13:38:10 CDT(-0500)] <anastasiac> Justin_o, are we having a community workshop today?

[13:40:44 CDT(-0500)] <Justin_o> anastasiac: fixed the link, thanks for spotting that.. i also adjusted your permissions… but i'll resolve this one since i'm on it already.

[13:40:44 CDT(-0500)] <Justin_o> anastasiac: yes.. i guess i should start rounding people up for that

[13:41:07 CDT(-0500)] <Justin_o> fluid-everyone: the community meeting today will be a continuation of our work on the build scripts.. we will try to drop maven today. Let me know if anyone would like to join remotely.

[13:41:34 CDT(-0500)] <cindyli> me

[13:42:18 CDT(-0500)] <Justin_o> fluid-everyone: we have access to the colabroom today, so locally we can meet there

[13:42:39 CDT(-0500)] <cindyli> lol ok

[13:46:45 CDT(-0500)] <Justin_o> heidiv: FLUID-5087 is in

[13:46:52 CDT(-0500)] <heidiv> phew (smile) thanks

[13:47:46 CDT(-0500)] <Justin_o> heidiv: (smile) thank you

[13:47:58 CDT(-0500)] <Justin_o> fluid-everyone: let's gather at 3pm for the community meeting

[13:54:32 CDT(-0500)] <Justin_o> yzen, Bosmon: i've sent a pull request to get the initial working implementation of the discovery tool into the gpii/prefsEditors repo

[13:54:38 CDT(-0500)] <Justin_o> https://github.com/GPII/prefsEditors/pull/3

[14:02:14 CDT(-0500)] <Justin_o> fluid-everyone: we are meeting now for the community meeting

[14:02:25 CDT(-0500)] <Justin_o> would anyone like to join remotely?

[14:08:24 CDT(-0500)] <yzen> Justin_o: yes

[14:08:32 CDT(-0500)] <Justin_o> colinclark: will you be joining the community meeting

[14:20:03 CDT(-0500)] <colinclark> oh

[14:20:09 CDT(-0500)] <colinclark> sure, if you'd like me to

[14:20:11 CDT(-0500)] <colinclark> Justin_o: ^

[14:22:00 CDT(-0500)] <Justin_o> colinclark: are you local, we're screen sharing with yzen

[14:22:08 CDT(-0500)] <anastasiac> we're in the collar room

[14:22:11 CDT(-0500)] <colinclark> ok

[14:22:14 CDT(-0500)] <anastasiac> s/collar/collab

[14:22:19 CDT(-0500)] <colinclark> see you shortly

[14:23:13 CDT(-0500)] <Justin_o> colinclark: thanks.. we're starting from your branch

[15:18:59 CDT(-0500)] <Justin_o> michelled:

[15:19:07 CDT(-0500)] <Justin_o> can you take a look at the pull request cindyli filed

[15:19:41 CDT(-0500)] <michelled> yep, looking now Justin_o

[15:19:47 CDT(-0500)] <Justin_o> https://github.com/fluid-project/infusion/pull/373

[15:19:51 CDT(-0500)] <Justin_o> oh thanks michelled

[15:20:09 CDT(-0500)] <Justin_o> i'm not sure how the daily builds work.. not sure if they are using the war.. so we might need to look at those too

[15:20:47 CDT(-0500)] <michelled> yzen: can your 4903 pull request be closed now that Justin_o has filed one for 4907?

[15:21:20 CDT(-0500)] <yzen> yes (smile) ill do that , michelled

[15:21:26 CDT(-0500)] <michelled> thx yzen

[15:25:31 CDT(-0500)] <michelled> nothing like 918 changed files in a pull request - teaches me to miss a community meeting (wink)

[15:31:09 CDT(-0500)] <colinclark> (smile)