Skip to end of metadata
Go to start of metadata

You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 35 Next »

[07:59:33 CDT(-0500)] <Justin_o> cindyli: do you know why this was resolved? was there a fix that got merged in somewhere? http://issues.fluidproject.org/browse/FLUID-5116

[08:01:04 CDT(-0500)] <cindyli> Justin_o: yes, i fixed it and Bosmon merged the pull into the master. let me find out the commit#

[08:02:44 CDT(-0500)] <cindyli> Justin_o: https://github.com/fluid-project/infusion/commit/50b253a3e004c598ae7389e5d3b12fe53e679351

[08:07:06 CDT(-0500)] <Justin_o> cindyli: thanks do you know if this one is also done.. the comment at the end is a bit ambigous

[08:07:07 CDT(-0500)] <Justin_o> http://issues.fluidproject.org/browse/FLUID-5010

[08:07:57 CDT(-0500)] <cindyli> Justin_o: yes, it's fixed too

[08:08:19 CDT(-0500)] <Justin_o> cindyli: thanks

[08:08:25 CDT(-0500)] <cindyli> np

[08:14:55 CDT(-0500)] <cindyli> Justin_o: do you want me to start on uio renaming?

[08:17:54 CDT(-0500)] <Justin_o> cindyli: sure thanks.. let me know if there's a way we can split that up at all

[08:18:37 CDT(-0500)] <cindyli> sure

[08:35:41 CDT(-0500)] <Justin_o> anastasiac: can you test something for me..

[08:35:48 CDT(-0500)] <anastasiac> sure

[08:35:54 CDT(-0500)] <Justin_o> anastasiac: can you verify that text size doesn't work in the panel on the build site

[08:35:54 CDT(-0500)] <Justin_o> http://build.fluidproject.org/infusion/demos/uiOptions/gradesDemo/html/uiOptions.html

[08:36:24 CDT(-0500)] <anastasiac> works for me in FF, Justin_o

[08:36:52 CDT(-0500)] <anastasiac> works for me in Chrome, too

[08:37:25 CDT(-0500)] <Justin_o> anastasiac: i guess it's just me then, which i guess is a good thing.. thanks for testing

[09:09:16 CDT(-0500)] <Justin_o> anastasiac: do you know if this can be closed? do we still suggest the use of jQuery UI dialogs? http://issues.fluidproject.org/browse/FLUID-3744

[09:10:54 CDT(-0500)] <anastasiac> Justin_o, as far as I can tell, nothing in the current docs mentions jQuery dialogs, so I think that issue can be closed

[09:16:07 CDT(-0500)] <Justin_o> anastasiac: thanks

[09:17:24 CDT(-0500)] <cindyli> anastasiac, Justin_o, how do you think we should rename FatPanelUIOptions.html? to SeparatedPanelPrefsEditor.html?

[09:17:44 CDT(-0500)] * anastasiac ponders

[09:17:49 CDT(-0500)] <Justin_o> cindyli: long but i guess so

[09:18:00 CDT(-0500)] <Justin_o> or SeparatedPanel.htmkl

[09:18:02 CDT(-0500)] <Justin_o> html

[09:18:29 CDT(-0500)] <cindyli> sounds good. thanks

[09:18:33 CDT(-0500)] <anastasiac> I don't mind the long name, myself

[09:18:43 CDT(-0500)] <Justin_o> anastasiac: do you know what this means? http://issues.fluidproject.org/browse/FLUID-3740

[09:18:49 CDT(-0500)] <anastasiac> SeparatedPanel might be confused w Panels in general

[09:18:59 CDT(-0500)] <Justin_o> anastasiac: that's true

[09:19:36 CDT(-0500)] <anastasiac> Justni_o, that issue sounds like it was completed long ago

[09:19:55 CDT(-0500)] <Justin_o> anastasiac: thanks.. i'll close it

[09:19:58 CDT(-0500)] <anastasiac> I vote for the longer name, cindyli and Justin_o, to avoid confusion with prefs panels

[09:20:38 CDT(-0500)] <anastasiac> Justin_o, if you look at that issue's parent issue, you might find some other things we can close (smile)

[09:20:58 CDT(-0500)] <anastasiac> i.e. all of them!!

[09:21:45 CDT(-0500)] <cindyli> anastasiac, Justin_o, i'm fine with the longer name, my only concern is it could be even longer in the case at renaming FatPanelUIOptionsFrame.html -> SeparatedPanelPrefsEditorFrame.html

[09:22:51 CDT(-0500)] <anastasiac> well, if it looks like a duck and quacks like a duck...

[09:23:35 CDT(-0500)] <anastasiac> Justin_o, what do you think?

[09:26:54 CDT(-0500)] <Justin_o> anastasiac: i think that makes it a duck

[09:27:45 CDT(-0500)] <Justin_o> anastasiac, cindyli: i personally am fine with the longer names, i think we should start with the longer name and if there is concern we can rename it again

[09:27:59 CDT(-0500)] <anastasiac> my vote is: go with the longer names, cindyli. Maybe we can get another vote from michelled when she gets in

[09:28:11 CDT(-0500)] <cindyli> ok, thanks

[09:39:02 CDT(-0500)] <Justin_o> anastasiac: do you know if this one can be close http://issues.fluidproject.org/browse/FLUID-1653

[09:40:10 CDT(-0500)] <anastasiac> good question, Justin_o, I'm not sure

[09:42:33 CDT(-0500)] <Justin_o> anastasiac: okay.. i'll leave it for now then.. i added a comment anyways

[10:10:19 CDT(-0500)] <Justin_o> cindyli: do you still have an IE 9 vm?

[10:10:31 CDT(-0500)] <cindyli> yes, Justin_o

[10:10:44 CDT(-0500)] <Justin_o> cindyli: never mind.. i got mine working again.. thanks though

[10:10:56 CDT(-0500)] <cindyli> ok

[10:15:56 CDT(-0500)] <Justin_o> cindyli: do you know if this is already fixed? http://issues.fluidproject.org/browse/FLUID-5102

[10:19:25 CDT(-0500)] <cindyli> Justin_o: i think yes. resourceLoader has already been a top level option

[10:25:57 CDT(-0500)] <Justin_o> cindyli: thanks

[10:55:51 CDT(-0500)] <Justin_o> cindyli: did you want to break up the work for FLUID-5161 somehow.. i think i'm finished with the jira cleanup now

[10:56:23 CDT(-0500)] <cindyli> sure, Justin_o. let's talk about how to break up

[11:21:06 CDT(-0500)] <Justin_o> jhung: for GPII-193 did you just switch the focus highlighting to be dashed?

[11:21:27 CDT(-0500)] <jhung> yes Justin_o

[11:22:06 CDT(-0500)] <Justin_o> jhung: was vjoanna okay with that or do we need to run it by her again?

[11:22:54 CDT(-0500)] <jhung> Yes I talked to vjoanna about it. It should be fine.

[11:23:55 CDT(-0500)] <Justin_o> cool.. i do have one more comment.. leaving it on the pull request now

[11:24:28 CDT(-0500)] <jhung> ok thanks Justin_o

[11:25:32 CDT(-0500)] <Justin_o> jhung: comment is up

[11:25:44 CDT(-0500)] <Justin_o> let me know if you have questions about it

[11:39:48 CDT(-0500)] <Bosmon> Hi cindyli - how are you getting on with the "args" improvement to the testing framework?

[11:43:42 CDT(-0500)] <Justin_o> cindyli: we should probably opportunistically get to as many of these issues as possible while we do the renaming http://issues.fluidproject.org/issues/?jql=component%20%3D%20%22Prefs%20Framework%22%20AND%20project%20%3D%20FLUID%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC

[11:44:41 CDT(-0500)] <cindyli> ok, Justin_o, let's try

  • No labels