[08:21:27 EDT(-0400)] * Justin_o (n=Justin@142.150.154.101) has joined #fluid-work
[08:55:17 EDT(-0400)] * anastasiac (n=team@142.150.154.160) has joined #fluid-work
[09:01:42 EDT(-0400)] * athena7 (n=athena7@adsl-99-149-83-32.dsl.wlfrct.sbcglobal.net) has joined #fluid-work
[09:04:01 EDT(-0400)] * EricDalquist (n=dalquist@bohemia.doit.wisc.edu) has joined #fluid-work
[09:47:07 EDT(-0400)] * Justin_o (n=Justin@142.150.154.101) has joined #fluid-work
[09:50:03 EDT(-0400)] * theclown (n=theclown@guiseppi.atrc.utoronto.ca) has joined #fluid-work
[09:51:01 EDT(-0400)] * jessm (n=Jess@c-76-19-199-61.hsd1.ma.comcast.net) has joined #fluid-work
[10:41:02 EDT(-0400)] * michelled (n=team@142.150.154.197) has joined #fluid-work
[10:41:54 EDT(-0400)] <anastasiac> I'll talk on FLUID-1594 (problem with undo in inline edit) if no one else is looking at it yet
[10:43:37 EDT(-0400)] <michelled> anastasiac: can you code review my commit from yesterday? 5637
[10:43:50 EDT(-0400)] <anastasiac> sure, michelled, I'll look at it right no
[10:43:51 EDT(-0400)] <anastasiac> now
[10:53:33 EDT(-0400)] <anastasiac> michelled, your commit looks good - I've tested the Fluid-all file, and it's functioning jsut fine. Is there a JIRA I can close for this?
[10:54:20 EDT(-0400)] <michelled> I'm not sure if Justin_o already closed it - 1601
[10:54:23 EDT(-0400)] <michelled> thanks for looking at it
[10:54:59 EDT(-0400)] <Justin_o> michelled, anastasiac: I did close it already...
[11:18:06 EDT(-0400)] <athena7> hello all - i was wondering if anyone might know which fluid javascript files the portal should include?
[11:18:36 EDT(-0400)] <athena7> i'm assuming Fluid.js, LayoutCustomizer.js, Reorderer.js, probably ModuleLayout.js
[11:18:41 EDT(-0400)] <athena7> wasn't sure about the others
[11:18:44 EDT(-0400)] <anastasiac> athena7, if you look at http://wiki.fluidproject.org/display/fluid/Layout+Customizer+API, it includes a list of the dependencies
[11:18:53 EDT(-0400)] <anastasiac> at the bottom of the page
[11:19:06 EDT(-0400)] <athena7> ohoh! yay! thank you 
[11:19:19 EDT(-0400)] <athena7> perfect!
[11:19:20 EDT(-0400)] <anastasiac> hm. actually, give me 5 minutes to update it to a recent change
[11:20:41 EDT(-0400)] <anastasiac> ok, fixed - it was missing one file that was added over the weekend based on some refactoring
[11:21:49 EDT(-0400)] <athena7> ah, thanks
[11:40:54 EDT(-0400)] <michelled> Justin_o: I can't seem to reproduce FLUID-1598
[11:41:08 EDT(-0400)] <Justin_o> let me check
[11:41:36 EDT(-0400)] <michelled> ack - I didn't notice it was Opera only
[11:42:05 EDT(-0400)] <michelled> sorry
[11:43:22 EDT(-0400)] <Justin_o> michelled: np... common mistake
[11:59:17 EDT(-0400)] * ecochran (n=ecochran@dhcp-169-229-212-26.LIPS.Berkeley.EDU) has joined #fluid-work
[12:08:14 EDT(-0400)] <michelled> I'm looking at 1323
[12:10:42 EDT(-0400)] <ecochran> I'll take 1334 which I suspect is just as fixed as 1593, which is to say... good enough... but I won't get to it until after standup.
[12:20:33 EDT(-0400)] <Justin_o> i just looked at 1334 and was still there
[12:20:42 EDT(-0400)] <Justin_o> the issue still occurs
[12:20:55 EDT(-0400)] <Justin_o> i'm going to be rebuilding the daily build site now
[12:23:50 EDT(-0400)] <Justin_o> the daily build site is back up
[12:32:20 EDT(-0400)] <Justin_o> jacobfarber: The following issues may be styling issues. Not sure if you have any thoughts on these
[12:32:28 EDT(-0400)] <Justin_o> Fluid-1183
[12:32:36 EDT(-0400)] <Justin_o> Fluid-1184
[12:33:29 EDT(-0400)] <jacobfarber> styling is the problem, but not the solution I think
[12:33:57 EDT(-0400)] <Justin_o> jacobfarber: interesting... so styling is the symptom of some other problem?
[12:34:30 EDT(-0400)] <jacobfarber> well, since IE doesnt support :focus we have to apply it manually, through JS
[12:34:57 EDT(-0400)] <jacobfarber> so CSS support is part of the problem, but JS is where the solution lies, I think
[12:35:16 EDT(-0400)] <jacobfarber> at least for 1183
[12:36:10 EDT(-0400)] <jacobfarber> Juston_o im going to play with the tabs a bit
[12:36:14 EDT(-0400)] <jacobfarber> see what happens
[12:36:21 EDT(-0400)] <Justin_o> okay... thanks
[12:37:34 EDT(-0400)] <ecochran> Yes, FLUID-1334 is not the problem that I thought it was. Bummer.
[12:38:16 EDT(-0400)] <Justin_o> ecochran: that's too bad...
[12:38:39 EDT(-0400)] <ecochran> Not sure what the right fix would be
[12:38:41 EDT(-0400)] <michelled> I've attached a fix for Fluid-1323. I'd like Antranig to code review it before commit so I've reassigned it to him.
[12:40:21 EDT(-0400)] <Justin_o> ecochran: i think alisson suggested to have it shrink to the right instead of the left. although I would guess that this would create the same issue but on the other side
[12:40:50 EDT(-0400)] <Justin_o> oops maybe she said shrink to the pointer
[12:41:11 EDT(-0400)] <Justin_o> yes... just checked... she did say shrink to the pointer
[12:41:28 EDT(-0400)] <ecochran> yes, it should shrink to the pointer... the trick would be doing that in an efficient (smart) way
[12:41:36 EDT(-0400)] <ecochran> I'll look at the code
[12:41:56 EDT(-0400)] <Justin_o> okay
[12:41:58 EDT(-0400)] <Justin_o> thanks
[13:02:19 EDT(-0400)] <jessm> ecochran: standup?
[13:02:53 EDT(-0400)] <ecochran> coming, lost in Lint
[14:11:21 EDT(-0400)] <ecochran> I've poked at the Reorderer code to the point were I feel pretty certain that I'll have to leave 1334 for Antranig
[14:12:21 EDT(-0400)] <Justin_o> ecochran: okay
[14:13:19 EDT(-0400)] <Justin_o> if I remember correctly I think I saw somewhere or heard one of the designers mention that the avatar should be the width of the column it is in. So this may be part of a larger issue
[14:15:59 EDT(-0400)] <Justin_o> FLUID-1604 has been added to the bug parade
[14:16:17 EDT(-0400)] <michelled> ecochran: thanks for doing some Reorderer cleanup
[14:16:47 EDT(-0400)] <michelled> I created FLUID-1604 for that purpose in case there's more to be done
[14:17:34 EDT(-0400)] <ecochran> michelled: np, I've been doing it as I stumble on it
[14:17:46 EDT(-0400)] <michelled> yay
[14:41:10 EDT(-0400)] <ecochran> michelled: should we actually code-review this delinting?
[14:41:41 EDT(-0400)] <ecochran> I've been running the automated tests before and after...
[14:43:10 EDT(-0400)] <michelled> ecochran: yes, I think so.
[14:43:18 EDT(-0400)] <michelled> but actually, I just did and it's fine
[14:43:33 EDT(-0400)] <michelled> partly it's to catch little things that may creep in.
[14:43:46 EDT(-0400)] <michelled> yesterday I caught a missing '}' in one of the commits
[14:43:52 EDT(-0400)] <michelled> for example
[14:44:05 EDT(-0400)] <ecochran> which Lint should catch
[14:44:13 EDT(-0400)] <michelled> it was in a css file
[14:44:20 EDT(-0400)] <ecochran> but Aptana definitely catches
[14:44:31 EDT(-0400)] <ecochran> I really like the Aptana validation window
[14:44:42 EDT(-0400)] <michelled> ya, me too.
[14:45:19 EDT(-0400)] <ecochran> michelled: On Colin's prompting I fixed that final Reorderer.js lint error, and will check in now, if you'd take a look.
[14:45:56 EDT(-0400)] <michelled> I will
[14:49:28 EDT(-0400)] <michelled> looks fine ecochran
[14:49:40 EDT(-0400)] <ecochran> michelled: thanks
[14:49:57 EDT(-0400)] <Justin_o> anybody mind if i rebuild the daily build site?
[15:08:19 EDT(-0400)] * phiggins_afk (n=dante@c-68-34-199-67.hsd1.tn.comcast.net) has left #fluid-work
[15:09:17 EDT(-0400)] <Justin_o> Since there were no objections I'll be rebuilding the build site now
[15:15:32 EDT(-0400)] * phiggins (n=dante@c-68-34-199-67.hsd1.tn.comcast.net) has joined #fluid-work
[15:22:01 EDT(-0400)] <jacobfarber> Could anyone pls do a code review on FLUID-1187 (rev. 5656)
[15:52:23 EDT(-0400)] <michelled> jacobfarber: done, looks good
[15:53:17 EDT(-0400)] <jacobfarber> thank you!
[15:56:00 EDT(-0400)] <michelled> np
[16:05:54 EDT(-0400)] * Justin_o (n=Justin@142.150.154.101) has left #fluid-work
Manage space
Manage content
Integrations