[08:22:24 EST(-0500)] * Justin_o (n=Justin@142.150.154.101) has joined #fluid-work <Bosmon> #combo-editable <Bosmon> .editContainer <colinclark_> if (that.queue.isUploading)
[08:24:22 EST(-0500)] * phiggins (n=dante@c-68-34-199-67.hsd1.tn.comcast.net) has joined #fluid-work
[09:31:32 EST(-0500)] * anastasiac (n=team@142.150.154.160) has joined #fluid-work
[09:41:51 EST(-0500)] * jessm (n=Jess@c-24-34-214-137.hsd1.ma.comcast.net) has joined #fluid-work
[09:48:16 EST(-0500)] * clown (n=clown@guiseppi.atrc.utoronto.ca) has joined #fluid-work
[09:58:22 EST(-0500)] * colinclark (n=colin@bas1-toronto09-1279534686.dsl.bell.ca) has joined #fluid-work
[09:59:10 EST(-0500)] <colinclark> Justin_o: Morning.
[09:59:25 EST(-0500)] <Justin_o> colinclark: Hello, good morning
[09:59:40 EST(-0500)] <colinclark> Are our servers all back up now?
[10:00:13 EST(-0500)] <Justin_o> no, the daily build site is still down
[10:00:24 EST(-0500)] <colinclark> ok. That's a drag.
[10:00:36 EST(-0500)] <colinclark> Did you get a chance to take a peek at my FLUID-1768 branch?
[10:00:42 EST(-0500)] <Justin_o> I was thinking it more of a sign
[10:01:06 EST(-0500)] <colinclark> 
[10:01:08 EST(-0500)] <Justin_o> not yet i'm going to be doing that shortly though... i guess i have to pull down the branch seperate from the trunk?
[10:01:49 EST(-0500)] <colinclark> Justin_o: Yep, just check the branch out. I tried to make it as easy as possible to evaluate without actually committing such a substantial change.
[10:02:22 EST(-0500)] <anastasiac> Justin_o, fj4000 asked for reviews of FLUID-1758 and FLUID-1966 - I'll have a look at those
[10:02:55 EST(-0500)] <colinclark> Justin_o: I found a bug this weekend that I wasn't sure if you knew about.
[10:03:09 EST(-0500)] <Justin_o> anastasiac: thanks
[10:03:14 EST(-0500)] <colinclark> It looks like when the Uploader css consolidation happened, it broken the Uploader springboard.
[10:03:28 EST(-0500)] <Justin_o> colinclark: what broke
[10:03:36 EST(-0500)] <colinclark> It throws an error on start.
[10:03:58 EST(-0500)] <Justin_o> hmm... yes... that doesn't sound like something I knew about
[10:04:10 EST(-0500)] <Justin_o> that was part of the fluid-1935 commit
[10:04:11 EST(-0500)] <colinclark> It seems that there are two element .fl-uploader-queue classes within the same container.
[10:04:31 EST(-0500)] <colinclark> It should be insanely easy to fix, but I didn't feel up to it at 2:30 am last night. 
[10:04:47 EST(-0500)] <Justin_o> understandable, i'm surprised you are up already
[10:04:57 EST(-0500)] <colinclark> me too
[10:05:11 EST(-0500)] <colinclark> Couldn't sleep... dreaming of virtual machines and Flash installations. 
[10:07:16 EST(-0500)] <colinclark> Well, I'm glad you guys were into the idea of easing into code freeze...
[10:07:31 EST(-0500)] <colinclark> I just saw so many requests for reviews and interesting questions that hadn't yet been discussions.
[10:07:57 EST(-0500)] <colinclark> It seems to me that we should be very careful not to take on any new bugs, but just do get the reviews done and fix any issues that arise from the current crop of fixes.
[10:08:31 EST(-0500)] <Justin_o> i think anastasiac and I are in total agreement with that... i think i'll send out an updated bug parade with only those needing review on it
[10:08:42 EST(-0500)] <colinclark> Cool.
[10:12:15 EST(-0500)] <colinclark> Justin_o: I think I've found a pretty disappointing bug in my Flash 10 fix.
[10:12:30 EST(-0500)] <colinclark> I'll be curious to see if you encounter it, and then how we decide to classify it.
[10:12:52 EST(-0500)] <colinclark> In short, it looks to me like SWFUpload 2.2.0b3 is broken on the server in FF3 (at least on Windows).
[10:13:40 EST(-0500)] <Justin_o> interesting... i'll take a look at it
[10:14:12 EST(-0500)] <colinclark> That's what kept me up so late last night... tracking it down. This morning I just tripled checked with a totally unmodified version of swfupload.js.
[10:14:27 EST(-0500)] <colinclark> That said, my Firefox installation is somewhat fried.
[10:14:35 EST(-0500)] <colinclark> FF2 decided to upgrade itself to FF3.
[10:14:45 EST(-0500)] <colinclark> And then when I reinstalled 2, confusion ensued.
[10:14:54 EST(-0500)] <colinclark> Wish I had taken a snapshot of my VM.
[10:31:52 EST(-0500)] <anastasiac> Justin_o, my review of FLUID-1758 has been added to the JIRA and emailed to the list.
[10:31:59 EST(-0500)] <anastasiac> It still needs work
[10:32:22 EST(-0500)] <Justin_o> oh well that's what today is for
[10:32:25 EST(-0500)] <anastasiac> but it's a patch that wasn't committed, so no damage actually done
[10:49:39 EST(-0500)] <anastasiac> Justin_o, I've commented on FLUID-1966 and emailed the list. The patch doesn't seem to help
[10:52:22 EST(-0500)] <Justin_o> really... that's too bad
[11:25:07 EST(-0500)] * athena7 (n=athena7@99.129.101.69) has joined #fluid-work
[11:34:57 EST(-0500)] <anastasiac> Justin_o, regarding FLUID-1935: I did review this last week, and commented on the JIRA.
[11:35:14 EST(-0500)] <anastasiac> Same for FLUID-1964
[11:36:13 EST(-0500)] <Justin_o> oh yes.... sorry some of those are still marked because the review, testing, or a resolution may not be complete
[11:44:58 EST(-0500)] <anastasiac> Justin_o, I just had a look at FLUID-1875, the Sakai UI Options sample
[11:45:09 EST(-0500)] <anastasiac> one of the three issues you found is still present
[11:45:14 EST(-0500)] <anastasiac> the other two seem to be fine now
[11:48:58 EST(-0500)] <Justin_o> yes... i have broken that one out into a seperate issue http://issues.fluidproject.org/browse/FLUID-1963
[11:49:09 EST(-0500)] <Justin_o> I believe it was something that was already present
[11:49:45 EST(-0500)] <Justin_o> I'm trying to remember now, but i believe that was the conclusion that we came to when i was speaking with fj4000 about it last weeke
[11:49:53 EST(-0500)] <Justin_o> i should have marked that on the bug
[11:52:05 EST(-0500)] * Bosmon (n=Antranig@ginger.caret.cam.ac.uk) has joined #fluid-work
[11:52:10 EST(-0500)] * michelled (n=team@142.150.154.197) has joined #fluid-work
[11:52:11 EST(-0500)] <Justin_o> in reflections i'm not sure if FLUID-1963 should be a blocker... any thoughts
[11:52:32 EST(-0500)] <Justin_o> it currently isn't but maybe it should be
[11:54:39 EST(-0500)] * ecochran (n=ecochran@dhcp-169-229-212-73.LIPS.Berkeley.EDU) has joined #fluid-work
[12:03:41 EST(-0500)] * colinclark (n=colin@142.150.154.101) has joined #fluid-work
[12:03:58 EST(-0500)] <anastasiac> Justin_o: regarding FLUID-1963, I'd be tempted to make it a blocker. The lack of "pre-popluation" of the dialog with the current settings means it's very easy to lose all your settings
[12:04:50 EST(-0500)] <anastasiac> I'll have a look at FLUID-1947
[12:05:00 EST(-0500)] * everettz (n=chatzill@user147-141.wireless.utoronto.ca) has joined #fluid-work
[12:05:09 EST(-0500)] <Justin_o> anastasiac: that is true
[12:05:24 EST(-0500)] <Justin_o> michelled: how hard do you think FLUID-1936 would be to fix
[12:10:35 EST(-0500)] <everettz> Justin_o: Are you / Colin available to meet with Rob and I tomorrow after lunch?
[12:11:03 EST(-0500)] <michelled> Justin_o: I don't see the error in FF2 or FF3
[12:12:01 EST(-0500)] <michelled> oops - looking at 1936 instead of 1963
[12:13:21 EST(-0500)] <michelled> Justin_o: it's a tiny change.
[12:13:27 EST(-0500)] <michelled> actually, this is a regresstion
[12:13:35 EST(-0500)] <michelled> I'd fixed this problem a long time ago
[12:13:41 EST(-0500)] <Justin_o> oh... really... okay...
[12:13:53 EST(-0500)] <Justin_o> my mistake on that...
[12:14:02 EST(-0500)] <michelled> no, it's not your mistake
[12:14:12 EST(-0500)] <michelled> the problem has been reintroduced at some point
[12:14:24 EST(-0500)] <michelled> shall I create a patch and have it reviewed?
[12:14:48 EST(-0500)] <Justin_o> yes please... you may want to take a look at 1875, i'm not sure if it was reintroduced there
[12:14:57 EST(-0500)] <michelled> it should be a matter of changing the init script to happen only once instead of every time 'edit appearance' is clicked
[12:16:29 EST(-0500)] <Justin_o> michelled: I have set Fluid-1963 as a blocker and will put it on the bug parade
[12:21:29 EST(-0500)] <anastasiac> ok, I said I'd look at 1947, but ecochran has reviewed it, so I will of course defer to the expert
[12:24:52 EST(-0500)] <ecochran> anastasiac: colinclark and I just discussed 1947 and I'm going to commit. There is a very small cosmetic problem that was not introduced with the patch but become more obvious with the patch but it can wait until the release. I'll write that up in my resolution for the bug, and add a new bug.
[12:30:40 EST(-0500)] <anastasiac> Justin_o, I think FLUID-1964 is good to go. The only issue is font size, and I don't think that's sufficient to hold it up.
[12:32:31 EST(-0500)] <anastasiac> Justin_o, I'd concur with ecochran on FLUID-1935 - good to go.
[12:36:26 EST(-0500)] <michelled> I've just attached a patch to FLUID-1963
[12:36:59 EST(-0500)] <anastasiac> michelled, Justin_o, I'll review FLUID-1963
[12:37:07 EST(-0500)] <Justin_o> anastasiac: did you want the name space issues fixed for FLUID-1935
[12:37:57 EST(-0500)] <anastasiac> Justin_o, I think it should be changed eventually, but I'm not sure if it's important for this release. Not sure what others think - michelled, colinclark, ecochran?
[12:39:31 EST(-0500)] <ecochran> Justin_o: I personally think that the CSS name space issue needs a little thoughtful talk before fixing. It's not a hard problem but with a little chatter I think that we could nail it down tight. So not for this release!
[12:39:58 EST(-0500)] <Justin_o> ecochran: it seems that the fix for FLUID-1935 has caused a problem with the uploader springboards
[12:40:19 EST(-0500)] <ecochran> Justin_o: ouch! I thought I checked that...
[12:40:31 EST(-0500)] <ecochran> it looked like the Springboard was independent
[12:40:35 EST(-0500)] <ecochran> I'll look at that now
[12:44:03 EST(-0500)] <Justin_o> thanks... colinclark caught this one, he was saying that it probably has to do with both of the uploaders having the same class
[12:46:16 EST(-0500)] <colinclark> Looks like there are two elements with the ".fl-uploader-queue" class.
[12:46:27 EST(-0500)] <colinclark> And thus the FileQueueView is failing to init.
[12:48:17 EST(-0500)] <michelled> anastasiac, I just realized that the js file didn't have a license and the file had never been linted
[12:48:33 EST(-0500)] <michelled> the changes are just declaring globals and a couple of spaces
[12:48:38 EST(-0500)] <anastasiac> yes, I was wondering about the license
[12:48:38 EST(-0500)] <michelled> do you want me to create a new patch?
[12:48:42 EST(-0500)] <anastasiac> user
[12:48:44 EST(-0500)] <anastasiac> sure
[12:48:47 EST(-0500)] * anastasiac can type!
[12:49:15 EST(-0500)] <ecochran> colinclark: do you want to fix or shall I? Or maybe Jacob? Where fj4000 this morning?
[12:49:35 EST(-0500)] <colinclark> fj4000 is away this morning
[12:49:41 EST(-0500)] <colinclark> if you could fix it, that would be huge
[12:49:45 EST(-0500)] <ecochran> np
[12:49:48 EST(-0500)] <colinclark> i am in the midst of scary debugging hell
[12:50:07 EST(-0500)] <ecochran> colinclark: I don't want to distract you!
[12:50:11 EST(-0500)] <ecochran> I'm on it
[12:52:45 EST(-0500)] <Bosmon> I have looked over FLUID-1768 "generally"
[12:52:54 EST(-0500)] <colinclark> Bosmon:
[12:53:10 EST(-0500)] <Bosmon> Anything specific I could be doing?
[12:53:12 EST(-0500)] <michelled> anastasiac, I've uploaded a fresh patch
[12:54:18 EST(-0500)] * jessm (n=Jess@c-24-34-214-137.hsd1.ma.comcast.net) has joined #fluid-work
[12:55:06 EST(-0500)] <colinclark> ecochran: I think I have uncovered a somewhat horrible bug.
[12:55:25 EST(-0500)] <ecochran> I am so listening!
[12:55:38 EST(-0500)] <colinclark> The layers of evil present in SWFUpload seem to be endless.
[12:55:47 EST(-0500)] <colinclark> evil all the way down
[12:56:08 EST(-0500)] <Bosmon> And in less than 1000 lines of code 
[12:57:02 EST(-0500)] <colinclark> In SWFUploadManager.removeFiles() we call "swfUpload.cancelUpload(fileId);"
[12:57:21 EST(-0500)] <colinclark> This seems to blow up in the demo mode with SWFUpload 2.2.0
[12:57:42 EST(-0500)] <colinclark> It seems as if they have systematically dismantled the functionality of their entire library with this release.
[12:57:49 EST(-0500)] <Bosmon> .....
[12:59:18 EST(-0500)] <anastasiac> Justin_o, I have reviewed michelled's patch for FLUID-1963 and commented on the JIRA. It looks good to me, I think she should commit it.
[13:00:53 EST(-0500)] <colinclark> well, we are all standing up
[13:02:10 EST(-0500)] <ecochran> colinclark: my mind boggles
[13:15:29 EST(-0500)] * fj4000 (n=Main@CPE00095bc35ea1-CM001692f5798c.cpe.net.cable.rogers.com) has joined #fluid-work
[13:18:54 EST(-0500)] <ecochran> fj4000: so maybe I don't need you right away... it looks like I broke a few things in the Uploader Springboard, either when I was updating the CSS (most likely) or with the latest change that I made to events (or both)
[13:19:23 EST(-0500)] <fj4000> ecochran: i'll be here....just ping me when youre ready
[13:19:30 EST(-0500)] <ecochran> I'm going to bang on it and look at code for 10 or 15 and then I'll let you know if I need your intimate knowledge of the code
[13:19:51 EST(-0500)] <fj4000> ok
[13:22:05 EST(-0500)] <Justin_o> fj4000: I'm wondering how closely tied the uploader springboard is to the component. Basically when
[13:22:22 EST(-0500)] <fj4000> it shouldnt be that tight
[13:22:42 EST(-0500)] <Justin_o> when it gets flash 10 support will you need to update it
[13:22:44 EST(-0500)] <fj4000> except the springboard needs to know there is no more uploader.css file
[13:24:07 EST(-0500)] <ecochran> fj4000: the Uploader spring board appears to not use the old uploader.css (now fluid.components.uploader.csss
[13:25:07 EST(-0500)] <fj4000> so there is no css dependency, yet it still broke?
[13:25:53 EST(-0500)] <ecochran> the dependency is in the selectors
[13:25:59 EST(-0500)] <fj4000> ok
[13:26:15 EST(-0500)] <fj4000> so when your done your review, we can see what works and what doesnt
[13:26:25 EST(-0500)] <ecochran> so I updated the selectors in the Springboard to match the selectors in fluid.components.uploader.css and now the code
[13:26:49 EST(-0500)] <ecochran> problem was that you already had a fl-uploader-queue class
[13:26:53 EST(-0500)] <ecochran> so now there are two
[13:27:04 EST(-0500)] <ecochran> but the Remove buttons also stopped working
[13:27:14 EST(-0500)] <ecochran> which is what I'm chewing on now
[13:29:36 EST(-0500)] <ecochran> fj4000: by the way, this was not your problem... this was my sloppy search and replace!
[13:29:40 EST(-0500)] <ecochran> my bad
[13:30:15 EST(-0500)] <ecochran> cut and paste, and search and replace, the power tools that will cut your hand off!
[13:30:21 EST(-0500)] <fj4000>
[13:31:31 EST(-0500)] <Bosmon> I prefer to think of them more as tinker toys
[13:31:50 EST(-0500)] <ecochran> that will poke your eye out? :-P
[13:31:57 EST(-0500)] <Bosmon> yes
[13:32:06 EST(-0500)] <Bosmon> The Tinker Toys that Kill
[13:33:57 EST(-0500)] <ecochran> fj4000: This is a really interesting example of why we might want more than one Fluid CSS namespace... one for the components and one for the skin.
[13:34:34 EST(-0500)] <ecochran> As I go through the CSS, it's hard for me to parse which classes are specific to the component and which is skinning stuff
[13:34:48 EST(-0500)] <fj4000> they should be in separate files
[13:35:01 EST(-0500)] <ecochran> it's when I look at them in mark up
[13:35:31 EST(-0500)] <ecochran> when I scan the markup, it'd be nice to know at a glance
[13:35:36 EST(-0500)] <fj4000> fl-uploader is usually the prefix for the uploader specific stuff
[13:36:03 EST(-0500)] <ecochran> yes, it's just a little more parsing ...
[13:36:04 EST(-0500)] <fj4000> "fl-component-whatItIs" is typically the setup
[13:36:16 EST(-0500)] <fj4000> yes
[13:36:40 EST(-0500)] <fj4000> something simpler would be very cool
[13:37:56 EST(-0500)] <ecochran> fj4000: and I said "might", I'm not wedded to the idea... just a point for discussion
[13:41:01 EST(-0500)] <Bosmon> FEEES has shown me a worrying integration issue with Reorderer
[13:41:07 EST(-0500)] <Bosmon> That I fear is too late to turn into a blocker
[13:41:15 EST(-0500)] <Bosmon> But I think can only really be addressed by fixing the base component
[13:41:23 EST(-0500)] <Bosmon> She is suggesting I turn the fix into a patch for now
[13:41:53 EST(-0500)] <Bosmon> But again, I wonder if this takes priority for anything else I might do for Parade/Freeze
[13:45:13 EST(-0500)] <anastasiac> Justin_o, fj4000, I've reviewed the new patch for FLUID-1966 and commented on the JIRA
[13:45:17 EST(-0500)] <anastasiac> it breaks in Opera
[13:45:28 EST(-0500)] <fj4000> I was just going to ask you
[13:45:39 EST(-0500)] <anastasiac> and I'm not sure about modifying one of the files that come with the jquery plug-in, which is not our code
[13:45:42 EST(-0500)] <fj4000> it seems to work in mine...i dont get it
[13:45:54 EST(-0500)] <fj4000> thats where the problem was
[13:45:54 EST(-0500)] <anastasiac> it breaks in Windows & Mac
[13:46:03 EST(-0500)] <anastasiac> hm..
[13:46:11 EST(-0500)] <fj4000> strange
[13:46:13 EST(-0500)] <anastasiac> so you're saying "it's not our bug" ?
[13:46:16 EST(-0500)] <fj4000> it looks good here
[13:46:29 EST(-0500)] <anastasiac> what version of Opera are you using?
[13:46:30 EST(-0500)] <fj4000> absolutely has nothing to do with our CSS or JS code
[13:46:37 EST(-0500)] <Bosmon> What is going on?
[13:46:43 EST(-0500)] <fj4000> its how their selectbox css works
[13:46:57 EST(-0500)] <Bosmon> No, you are absolutely authorized to change that
[13:47:00 EST(-0500)] <fj4000> Bosmon: just discussing 1966
[13:47:01 EST(-0500)] <Bosmon> It is just some crappy plugin
[13:47:08 EST(-0500)] <fj4000> i was just saying
[13:47:12 EST(-0500)] <anastasiac> fj400, what version of Opera are you testing with?
[13:47:13 EST(-0500)] <fj4000> how I was working on their css
[13:47:18 EST(-0500)] <anastasiac> fj4000^
[13:47:24 EST(-0500)] <fj4000> 9.9.62
[13:47:28 EST(-0500)] <fj4000> sorry
[13:47:29 EST(-0500)] <Bosmon> I just picked it because it was the "most suitable" thing I could lay my hands on
[13:47:29 EST(-0500)] <fj4000> 9.62
[13:47:39 EST(-0500)] <Bosmon> If we can fix it, there's nothing that stops us "keeping" it
[13:47:55 EST(-0500)] <Bosmon> If we decide the most efficient thing to do is to throw it away and start from scratch, we can do that too
[13:48:00 EST(-0500)] <fj4000> i was saying, its working on my local copy in all browsers
[13:48:07 EST(-0500)] <Bosmon> Although the most useful thing would be to be able to push a patch batck them
[13:48:14 EST(-0500)] <Bosmon> fj4000: Is it in trunk? Can I test?
[13:48:20 EST(-0500)] <anastasiac> fj4000, I'm at 9.52. maybe I should upgrade
[13:48:23 EST(-0500)] <fj4000> no, all I have is a patch
[13:48:25 EST(-0500)] <fj4000> but
[13:48:25 EST(-0500)] <Bosmon> OK
[13:48:31 EST(-0500)] <Bosmon> 1966-b patch?
[13:48:32 EST(-0500)] <fj4000> im thinking maybe I made a bad patch
[13:48:33 EST(-0500)] <fj4000> yes
[13:48:44 EST(-0500)] <Bosmon> It's certainly a lot smaller than your other one
[13:48:45 EST(-0500)] <anastasiac> fj4000, let me upgrade Opera first
[13:48:49 EST(-0500)] <fj4000> it could have gotten all wonky
[13:48:50 EST(-0500)] <Bosmon> Weren't you saying that this required a listener in any case?
[13:48:51 EST(-0500)] <fj4000>
[13:48:53 EST(-0500)] <Bosmon> cabberwonky?
[13:48:57 EST(-0500)] <fj4000> Bosmon
[13:48:58 EST(-0500)] <fj4000> yes
[13:49:08 EST(-0500)] <fj4000> but I figured out a css-only solution
[13:49:15 EST(-0500)] <fj4000> i was making it more complicated than it was
[13:49:18 EST(-0500)] <Bosmon> cool
[13:49:20 EST(-0500)] <Bosmon> Let me test it, then
[13:49:46 EST(-0500)] <fj4000> in the end, only about 5 lines needed to be changed in the css file
[13:49:51 EST(-0500)] <Bosmon> Sounds great
[13:50:01 EST(-0500)] <fj4000> so thats all you should get, plus i removed some <br /> tags
[13:50:04 EST(-0500)] <fj4000> just for effect
[13:50:05 EST(-0500)] <Bosmon> Yes
[13:50:07 EST(-0500)] <Bosmon> Why did you do that?
[13:50:13 EST(-0500)] <fj4000> so I could test overlap
[13:50:16 EST(-0500)] <fj4000> behaviour
[13:50:21 EST(-0500)] <Bosmon> ...
[13:50:33 EST(-0500)] <Bosmon> Oh, you mean the general document layout displacement?
[13:50:36 EST(-0500)] <fj4000> yes
[13:50:45 EST(-0500)] <Bosmon> Rather than the original bug, that is
[13:50:55 EST(-0500)] <fj4000> i guess both at the same time
[13:52:07 EST(-0500)] <Bosmon> Although the "concept" of this patch is not "self-contained"....
[13:52:11 EST(-0500)] <Bosmon> But let me test it in any case
[13:52:15 EST(-0500)] <Justin_o> Bosmon: sorry, i've been trying to catch up on the irc channel... a lot going on here... michelled showed me the issue and i think making a patch and giving that to gonzalo is a good start. I'm thinking that with the day about half over it may and the fact that we should have already gone into code freeze, we probably won't have time to include the fix in this release
[13:52:17 EST(-0500)] <anastasiac> fj4000, that bug is still happening for me in opera
[13:52:30 EST(-0500)] <Bosmon> .....
[13:52:31 EST(-0500)] <Bosmon> It is terrible
[13:52:34 EST(-0500)] <fj4000> anastasiac: can you elaborate what files got patched?
[13:52:37 EST(-0500)] <Bosmon> The control jumps to the top left of the window
[13:52:38 EST(-0500)] <fj4000> i think its a bad patch
[13:52:40 EST(-0500)] <Bosmon> Only selectbox.css got patched
[13:52:41 EST(-0500)] <fj4000> yes
[13:52:45 EST(-0500)] <fj4000> thats what shes saying too
[13:52:49 EST(-0500)] <Bosmon> You can see this by looking inside the patch file
[13:52:53 EST(-0500)] <Bosmon> HOw many should be patched?
[13:53:03 EST(-0500)] <fj4000> i dont get that problem
[13:53:20 EST(-0500)] <fj4000> let me see this thing.....
[13:53:24 EST(-0500)] <Bosmon> All that is in the patch is essentially this:
[13:53:25 EST(-0500)]
[13:53:25 EST(-0500)]
[13:53:25 EST(-0500)] <Bosmon> .text {}
[13:53:26 EST(-0500)] * fj4000 is patch hunting
[13:53:35 EST(-0500)] <fj4000> well, thats not right!
[13:53:46 EST(-0500)] <fj4000> there should be 5 lines, not 3
[13:53:55 EST(-0500)] <fj4000> argh
[13:54:03 EST(-0500)] <fj4000> pls give me a moment
[13:54:24 EST(-0500)] <anastasiac> ok, regarding the selectbox bug: I can see the bug in the sample provided by the author, so - confirmed as pre-existing
[13:54:55 EST(-0500)] <fj4000> can i send the contents of the patch to you guys privately, and you can tell me if thats what you have?
[13:55:04 EST(-0500)] <fj4000> something didnt work right
[13:55:28 EST(-0500)] <anastasiac> fj4000, try creating the patch from a higher up folder, like the root folder of the project
[13:55:33 EST(-0500)] <fj4000> ok
[13:57:18 EST(-0500)] <Bosmon> Well, there are a couple more lines yes
[13:57:30 EST(-0500)] <fj4000> ok, Im sending you my latest patch
[13:57:32 EST(-0500)] <Bosmon> You have commented out margin-top
[13:57:36 EST(-0500)] <fj4000> yes
[13:58:00 EST(-0500)] <Bosmon> But there's a problem in that this file now depends on .editContainer
[13:58:05 EST(-0500)] <Bosmon> I am assuming that was just experimental
[13:58:22 EST(-0500)] <fj4000> experimental?
[13:58:29 EST(-0500)] <Bosmon> I mean, you weren't intending to leave it that way
[13:58:56 EST(-0500)] <fj4000> I just took a snapshot of what was in the markup, and used the classnames there
[14:00:07 EST(-0500)] <anastasiac> ah! now the dropdown looks fine in Opera
[14:00:19 EST(-0500)] <anastasiac> ah, nice. much better
[14:00:28 EST(-0500)] <fj4000> there you go
[14:00:30 EST(-0500)] <Bosmon> OK, this patch is the same, only it has "top 1.5em" in as well
[14:00:32 EST(-0500)] <fj4000> bad patch
[14:00:54 EST(-0500)] <fj4000> im going to add a comment to the jira
[14:00:58 EST(-0500)] <Bosmon> wait!
[14:01:15 EST(-0500)] <Bosmon> The point is, it seems to be the removal of the brs that causes this to work
[14:01:20 EST(-0500)] <Bosmon> Which means that it is not a fix
[14:01:31 EST(-0500)] * colinclark (n=colin@142.150.154.101) has joined #fluid-work
[14:01:31 EST(-0500)] <Bosmon> I applied just the portion of the patch which relates to selectbox.css
[14:01:33 EST(-0500)] <Bosmon> And it still jumps
[14:01:48 EST(-0500)] <anastasiac> yes, Bosmon's right
[14:02:00 EST(-0500)] <anastasiac> also, he's going a point about putting the extra css in the selectbox css file
[14:02:16 EST(-0500)] <Bosmon> OK, we will really need to put our heads together on this one
[14:02:17 EST(-0500)] <anastasiac> it's one thing to fix their bug, but "our" css shouldn't be added to that file
[14:02:52 EST(-0500)] <Bosmon> Still, the upside is that the bug is at least fixed on FF2
[14:03:08 EST(-0500)] <Bosmon> The component looks really nice
[14:03:19 EST(-0500)] <fj4000> im really not sure what you guys are seeing, im sending you a screenshot of my opera screen
[14:03:41 EST(-0500)] <Bosmon> I am on Opera 9.6.2
[14:03:45 EST(-0500)] <Bosmon> 9.62
[14:05:34 EST(-0500)] <anastasiac> fj4000, any update on FLUID-1758?
[14:05:49 EST(-0500)] <fj4000> im afraid to patch it now
[14:05:50 EST(-0500)] <fj4000> but yes
[14:05:54 EST(-0500)] <fj4000> i've got a fix
[14:06:03 EST(-0500)] <anastasiac> post the patch, I'll try it out
[14:06:09 EST(-0500)] <fj4000> before I make a patch again, I would like to know whats going wriong with this one
[14:06:33 EST(-0500)] <Bosmon> Well, is there anything wrong with the patch?
[14:06:41 EST(-0500)] <Bosmon> I think the patch contains just what you meant to put in it
[14:06:44 EST(-0500)] <fj4000> anastasiac, Bosmon did you get my email?
[14:06:54 EST(-0500)] <anastasiac> fj4000, checking...
[14:06:57 EST(-0500)] <Bosmon> not yet
[14:07:19 EST(-0500)] <fj4000> Bosmon: I could have done it from the wrong directory, messed it up any # of ways...who knows
[14:07:44 EST(-0500)] <anastasiac> fj4000, I notice that you're essentially serving the demo up
[14:07:53 EST(-0500)] <anastasiac> can you try it with a file url?
[14:08:15 EST(-0500)] <Bosmon> fj4000 why don't you just "pastie" for now
[14:08:19 EST(-0500)] <Bosmon> So we can rule that out as a source of error
[14:08:21 EST(-0500)] <fj4000> ok
[14:08:26 EST(-0500)] <Bosmon> Just pastie your entire copy of the CSS file
[14:08:33 EST(-0500)] <fj4000> yes
[14:08:41 EST(-0500)] <Bosmon> I still haven't got your mail
[14:09:07 EST(-0500)] <anastasiac> fj4000, use fluid.pastebin.com
[14:09:16 EST(-0500)] <fj4000> it said you email address had a permanent error
[14:09:20 EST(-0500)] <fj4000>
[14:09:25 EST(-0500)] <Bosmon> what on earth
[14:09:52 EST(-0500)] <Bosmon> I just got an email from SVN 6 minute ago...
[14:09:53 EST(-0500)] <anastasiac> it's just a screen shot
[14:10:02 EST(-0500)] <anastasiac> it shows that it works for fj4000
[14:10:04 EST(-0500)] <fj4000> http://fluid.pastebin.com/m3f239aa6
[14:10:45 EST(-0500)] <fj4000> ALL i changed was line 3, 8, 56-58
[14:11:10 EST(-0500)] <fj4000> im pretty sure thats it
[14:11:48 EST(-0500)] <anastasiac> fj4000: are you testing using a server?
[14:12:00 EST(-0500)] <fj4000> local server, yes
[14:12:09 EST(-0500)] <anastasiac> can you try it using a regular file url?
[14:12:22 EST(-0500)] <anastasiac> i.e. just open file, and browse on your hard drive to the test file
[14:12:26 EST(-0500)] <fj4000> wont I have to commit for that to work?
[14:12:31 EST(-0500)] <anastasiac> no!
[14:12:38 EST(-0500)] <anastasiac> it's on your hard drive, right?
[14:12:43 EST(-0500)] <Bosmon> fj4000: Your file is identical to mine
[14:12:50 EST(-0500)] <fj4000> very weird
[14:13:00 EST(-0500)] <fj4000> let me try anastasiac
[14:13:04 EST(-0500)] <Bosmon> But I guess you are testing in Opera Mac, right?
[14:13:15 EST(-0500)] <anastasiac> both windows and mac
[14:13:28 EST(-0500)] <anastasiac> Bosmon, do you see the error in Opera?
[14:14:08 EST(-0500)] <fj4000> Ok, I just dragged "dropdown.html" into Opera
[14:14:12 EST(-0500)] <fj4000> and it looks normal
[14:14:18 EST(-0500)] <Bosmon> It does not jump?
[14:14:20 EST(-0500)] <Bosmon> When activated?
[14:14:20 EST(-0500)] <fj4000> no
[14:14:24 EST(-0500)] <Bosmon> GLARG
[14:14:28 EST(-0500)] <anastasiac> indeed
[14:14:29 EST(-0500)] <Bosmon> This is Bedlam
[14:14:29 EST(-0500)] <fj4000> wait
[14:14:33 EST(-0500)] <fj4000> when you say jump
[14:14:41 EST(-0500)] <fj4000> what EXACTLY do you mean?
[14:14:42 EST(-0500)] <Bosmon> The entire control appears at the top left point of the browser
[14:14:43 EST(-0500)] <fj4000> which parts
[14:14:45 EST(-0500)] <fj4000> and where
[14:14:46 EST(-0500)] <Bosmon> Rather than at the point of activation
[14:14:51 EST(-0500)] <Bosmon> Well, actually all I see is the dropdown portion
[14:14:57 EST(-0500)] <fj4000> no, I only get what I sent anastasia
[14:15:11 EST(-0500)] <Bosmon> The section which is meant to be the "dropdown selector" appears to be completely missing
[14:15:12 EST(-0500)] <fj4000> this is very weird
[14:15:16 EST(-0500)] <Bosmon> Perhaps it is above the viewport
[14:15:31 EST(-0500)] <Bosmon> Which Opera version do you have there?
[14:15:36 EST(-0500)] <fj4000> 9.62
[14:15:40 EST(-0500)] <anastasiac> hm. hard for fj4000 to try to fix a bug that he can't reproduce...
[14:15:46 EST(-0500)] <fj4000> yup ")
[14:16:01 EST(-0500)] <fj4000> Im very sure something obvious is missing here
[14:16:10 EST(-0500)] <fj4000> like an update wasnt made by me or something
[14:16:13 EST(-0500)] <fj4000> give me a moment
[14:16:19 EST(-0500)] <Bosmon> Well, why don't you go over to AC's machine
[14:16:25 EST(-0500)] <Bosmon> Isn't she like 3 feet away from you?
[14:16:26 EST(-0500)] <fj4000> nope
[14:16:30 EST(-0500)] <ecochran> Justin_o fj4000 : I've tracked down the problems with the Uploader springboard. They are two fold. The first problem was a search and replace bug that I introduced with the recent CSS refactoring. It was just as Colin said, we ended up with two fl-uploader-queue classes which confused the UploaderFileView code. The fix was to remove the extra class (in the right place) and move the styling that was hanging off of it to anothe
[14:16:31 EST(-0500)] <ecochran> The second problem was introduced in an older refactoring when I changed the name of the Remove button class. This problem was a little more complex to fix, but not a biggie. I renamed the class in the Springboard in one case, and in another I overroad the class in the initter... which is a good test anyway.
[14:16:31 EST(-0500)] <fj4000> 3000
[14:16:36 EST(-0500)] <Bosmon> ....
[14:16:40 EST(-0500)] <fj4000> im at home
[14:16:43 EST(-0500)] <fj4000> shes at u of t
[14:16:47 EST(-0500)] <Bosmon> mega-glarg
[14:16:49 EST(-0500)] <fj4000> roughly 15 km away
[14:16:54 EST(-0500)] <fj4000>
[14:17:00 EST(-0500)] <anastasiac> ok, hold on here.
[14:17:04 EST(-0500)] <Bosmon> More like 30,000 feet
[14:17:09 EST(-0500)] <fj4000> can we skype this?
[14:17:10 EST(-0500)] <Bosmon> Only she does not have a Plane
[14:17:12 EST(-0500)] <Bosmon> ok
[14:17:18 EST(-0500)] <anastasiac> yes, let's Skype
[14:17:20 EST(-0500)] <Bosmon> Don't we have an Everett Skype coming up soon anyway?
[14:17:22 EST(-0500)] * anastasiac goes online
[14:17:34 EST(-0500)] * fj4000 does too
[14:17:37 EST(-0500)] <ecochran> Justin_o fj4000 : I would like to reopen FLUID-1935, and submit a patch for these fixes for fj4000 to review
[14:18:04 EST(-0500)] <Justin_o> ecochran: sounds like a good idea
[14:18:23 EST(-0500)] <ecochran> Justin_o: then I have your blessing! Thanks o'King!
[14:18:27 EST(-0500)] <anastasiac> Bosmon, fj4000: I'm on Skype - a.cheetham
[14:18:32 EST(-0500)] <anastasiac> what are your contacts?
[14:18:36 EST(-0500)] <fj4000> Bosmon anastasiac; ok, I was just going to ask
[14:19:11 EST(-0500)] <Bosmon> Sorry, I just missed your call
[14:19:14 EST(-0500)] <Bosmon> Didn't have my headphones in yet
[14:19:29 EST(-0500)] <fj4000> jacob.farber for me
[14:19:37 EST(-0500)] <fj4000> i cant see either of you
[14:20:07 EST(-0500)] <anastasiac> fj4000, got your call, heard you
[14:20:12 EST(-0500)] <anastasiac> I'm guessing you didn't hear me
[14:20:15 EST(-0500)] <fj4000> nope.
[14:20:19 EST(-0500)] <fj4000> said you were offline
[14:20:20 EST(-0500)] <anastasiac> Bosmon, what is your id?
[14:20:24 EST(-0500)] <fj4000> Ah
[14:27:45 EST(-0500)] <ecochran> to anyone who cares... on the Mac, do not do a file replace when creating a patch in Aptana... Aptana blows up! Grumph!
[14:28:08 EST(-0500)] <Justin_o> ecochran: i was testing your fix for 1947
[14:28:28 EST(-0500)] <Justin_o> i notice that if you stop on the same file, multiple times... it won't finish uploading
[14:28:47 EST(-0500)] <ecochran> how fast did you click the button?
[14:29:21 EST(-0500)] <fj4000> anastasiac, Bosmon: all I have to say is thank goodness for Skype
[14:29:24 EST(-0500)] <ecochran> Justin_o: I'll take a look as soon as I build this patch
[14:29:31 EST(-0500)] <Justin_o> ecochran: depended on how big the file was
[14:29:42 EST(-0500)] <Justin_o> ecochran: it was on the server version
[14:29:53 EST(-0500)] <ecochran> really!?
[14:29:55 EST(-0500)] <ecochran> ah
[14:29:56 EST(-0500)] <anastasiac> fj4000:
[14:29:57 EST(-0500)] <ecochran> good
[14:30:06 EST(-0500)] <Justin_o> ecochran: you know what it is?
[14:30:06 EST(-0500)] <ecochran> Justin_o: let me look
[14:30:10 EST(-0500)] <Justin_o> ecochran: thanks
[14:30:18 EST(-0500)] <ecochran> Justin_o: no, but that gives me more to work with
[14:30:30 EST(-0500)] <Justin_o> ecochran: oh okay...
[14:30:33 EST(-0500)] <ecochran> Justin_o: the server and demo are such different beasts
[14:31:00 EST(-0500)] <ecochran> they share much code and behavior but they also diverge in very specific ways
[14:31:06 EST(-0500)] <ecochran> and Uploading is the heart of it
[14:31:32 EST(-0500)] <Justin_o> because the demo is just a simulation
[14:33:12 EST(-0500)] <ecochran> fj4000: http://issues.fluidproject.org/secure/attachment/10373/FLUID-1935.b.patch
[14:37:29 EST(-0500)] <michelled> Justin_o: what's next for me?
[14:38:04 EST(-0500)] <ecochran> brb
[14:38:07 EST(-0500)] <Justin_o> sending out an update of the bug parade right now
[14:38:08 EST(-0500)] <fj4000> ecochran; got it, thanks. I will apply it when im done with 1758
[14:38:12 EST(-0500)] <anastasiac> fj4000, your second patch for 1758: is that to be applied on top of the first? or instead of the first?
[14:38:19 EST(-0500)] <fj4000> instead of
[14:38:26 EST(-0500)] <anastasiac> k
[14:39:18 EST(-0500)] <fj4000> damn, actually I think not
[14:39:41 EST(-0500)] <anastasiac> I think not, also
[14:39:51 EST(-0500)] <fj4000> your right
[14:39:54 EST(-0500)] <fj4000> on top of
[14:42:44 EST(-0500)] <anastasiac> fj4000, the second patch won't work on top of the first.
[14:42:53 EST(-0500)] <fj4000> what happens?
[14:42:58 EST(-0500)] <anastasiac> it just doesn't work
[14:43:03 EST(-0500)] <fj4000> i need to merge the two patches?
[14:43:04 EST(-0500)] <anastasiac> can you generate a single patch?
[14:43:06 EST(-0500)] <fj4000> yes
[14:43:09 EST(-0500)] <anastasiac> don't merge, just re-generate
[14:43:13 EST(-0500)] <fj4000> ok
[14:45:02 EST(-0500)] <fj4000> anastasiac pls see the jira for 3rd patch
[14:45:09 EST(-0500)] <anastasiac> k
[14:49:08 EST(-0500)] <ecochran> back
[14:49:31 EST(-0500)] <fj4000> anastasiac: any luck?
[14:49:42 EST(-0500)] <anastasiac> fj4000: the patch works, and the drop-markers are all there
[14:49:43 EST(-0500)] <anastasiac> but:
[14:49:46 EST(-0500)] <Bosmon> Shall I look at 1758 too?
[14:49:58 EST(-0500)] <anastasiac> the drop markers for the tabs seem smaller than they were in your first patch
[14:50:06 EST(-0500)] <anastasiac> basically a bit too small for my taste
[14:50:17 EST(-0500)] <fj4000> themed tabs or normal tabs or both?
[14:50:51 EST(-0500)] <anastasiac> themes
[14:50:56 EST(-0500)] <anastasiac> forgot to test normal :-/
[14:51:42 EST(-0500)] <anastasiac> in the normal ones, they seem nice
[14:51:58 EST(-0500)] <anastasiac> just the themed ones look small enough that I'm not sure they're there
[14:52:14 EST(-0500)] <fj4000> ok
[14:52:21 EST(-0500)] <fj4000> heres what I suggest
[14:52:21 EST(-0500)] <anastasiac> they're not tall enought
[14:52:23 EST(-0500)] <anastasiac> that's the problem
[14:52:36 EST(-0500)] <fj4000> can we commit what we've got, to avoid any more patching problems
[14:52:44 EST(-0500)] <fj4000> and then tweak the height
[14:53:19 EST(-0500)] <anastasiac> the patching isn't really a problem, as long as you generate full replacement patches, and not patches on patches
[14:54:05 EST(-0500)] <Justin_o> ecochran: did you get a chance to look at the issue i mentioned to you
[14:54:10 EST(-0500)] <anastasiac> think of it as practice making patches
[14:54:40 EST(-0500)] <ecochran> Justin_o: not yet... will look now. It's running on build? or do I need to fire up my own server right now?
[14:55:01 EST(-0500)] <Justin_o> you can use the online one
[14:55:05 EST(-0500)] <Justin_o> with build
[14:57:11 EST(-0500)] <Justin_o> ecochran: it also looks like the "Add More" button isn't disabled during upload
[14:57:28 EST(-0500)] <ecochran> Justin_o: grrrrr!
[14:57:35 EST(-0500)] <ecochran> Justin_o: not at you
[14:57:39 EST(-0500)] <ecochran> just grrrr
[14:57:49 EST(-0500)] * phiggins (n=dante@c-68-34-199-67.hsd1.tn.comcast.net) has joined #fluid-work
[14:58:26 EST(-0500)] <Justin_o> ecochran: i undestand....
[14:58:35 EST(-0500)] <ecochran> Justin_o: I'm pretty sure that I know the first problem. And there is a very simple test for it.
[15:00:37 EST(-0500)] <michelled> Justin_o: 1970 is reviewed and I commented on the JIRA.
[15:00:38 EST(-0500)] <ecochran> We still have this problem that if you pause the upload right near the end... there is the possibility that the server will report that the file successfully uploaded after the Upload was canceled and the message gets lost. Interestingly, this problem is not all that different than the problem that we have in the demo. (Up until this moment I assumed that I was going to have to fix this problem on the server-side but now I thi
[15:01:36 EST(-0500)] <ecochran> Anyway, the test is to try the upload again... and if the file errors on completion, it is most likely that this is the same bug as before (I'll look it up for you.)
[15:01:41 EST(-0500)] <michelled> ecochran, you got cut off there. The last thing we saw was: "but now I thi"
[15:02:04 EST(-0500)] <ecochran> OK, looks like IRC doesn't like it when you are long winded
[15:02:17 EST(-0500)] <ecochran> (Up until this moment I assumed that I was going to have to fix this problem on the server-side but now I think that I might have another fix, but I digress).
[15:02:18 EST(-0500)] <Bosmon> Yeah, it is designed for small kids
[15:02:22 EST(-0500)] <Bosmon> Who like to flood each other
[15:03:15 EST(-0500)] <Justin_o> flood each other?
[15:03:30 EST(-0500)] <Bosmon> Kids will attempt to generate "message floods"
[15:03:38 EST(-0500)] <ecochran> The reason why the file errors the second time is that it's already on the server and Ray's code throws an error if you try to upload two files with the same binary.
[15:03:44 EST(-0500)] <ecochran> great for testing error cases
[15:03:52 EST(-0500)] <Bosmon> In order, to make each others comments to scroll away as fast as possible
[15:04:37 EST(-0500)] <ecochran> Justin_o: ^did you get all that?
[15:04:47 EST(-0500)] <ecochran> now on to the button
[15:05:47 EST(-0500)] <ecochran> Bosmon flooded me!
[15:05:49 EST(-0500)] <ecochran> wah!
[15:06:28 EST(-0500)] <Justin_o> Bosmon: that was a good demonstration of your explanation
[15:06:45 EST(-0500)] <Justin_o> ecochran: i think i got that... so basically it is a known issue
[15:06:54 EST(-0500)] <ecochran> Justin_o: FLUID-822
[15:06:57 EST(-0500)] <ecochran> found it
[15:07:18 EST(-0500)] <Bosmon>
[15:08:16 EST(-0500)] <Justin_o> ecochran: oh yes that one...
[15:09:13 EST(-0500)] <Justin_o> michelled: thanks for the review of 1970
[15:10:09 EST(-0500)] <michelled> np - do you have another to toss to me?
[15:30:38 EST(-0500)] <ecochran> Justin_o: the Browse button issue is really a bear to fix
[15:30:57 EST(-0500)] <ecochran> the easiest fix is to make the button a real button, right now it is a link...
[15:31:05 EST(-0500)] <ecochran> actually might not be too bad
[15:31:14 EST(-0500)] <ecochran> and it would be consistent with the other buttons
[15:31:26 EST(-0500)] <ecochran> Justin_o: worth fixing?
[15:31:47 EST(-0500)] <ecochran> I'd have to do some CSS work, functionally it seems to be pretty much the same
[15:32:01 EST(-0500)] <anastasiac> fj4000, just tried your latest patch for FLUID-1758
[15:32:06 EST(-0500)] <anastasiac> it looks great
[15:32:10 EST(-0500)] <fj4000> ok, great
[15:32:11 EST(-0500)] <ecochran> might even fix that Opera Browse button bug
[15:32:20 EST(-0500)] <fj4000> so I can commit that then?
[15:32:27 EST(-0500)] <anastasiac> Justin_o, I think fj4000 should go ahead and commit that
[15:32:33 EST(-0500)] <Bosmon> Is this 1758-d?
[15:32:40 EST(-0500)] <anastasiac> yes, -d
[15:32:53 EST(-0500)] <Bosmon> Shall I try it out too, or just wait for trunk
[15:33:56 EST(-0500)] <Bosmon> michelled: Actually 1830 is in
[15:34:18 EST(-0500)] <fj4000> Justin_o: is it ok to commit 1758-d ?
[15:35:17 EST(-0500)] <michelled> Bosmon: meaning it's been done already?
[15:35:23 EST(-0500)] <anastasiac> fj4000, Justin_o is testing some uploader stuff for colinclark
[15:35:26 EST(-0500)] <Bosmon> Yes, it has been in trunk for a week or so...
[15:35:39 EST(-0500)] <michelled> oh, great - do you want to close it then?
[15:35:45 EST(-0500)] <Bosmon> ok
[15:35:48 EST(-0500)] <michelled> thanks
[15:35:54 EST(-0500)] <fj4000> ok, until he gives the go ahead I will hold off
[15:36:36 EST(-0500)] <anastasiac> he is the King...
[15:36:43 EST(-0500)] <Bosmon> Wow, that is some big patch
[15:37:34 EST(-0500)] <Bosmon> Looks more reasonable in Opera now
[15:37:47 EST(-0500)] <Bosmon> fj4000: Were you aware that the last drop target, in Opera, is twice the width of the others?
[15:38:21 EST(-0500)] <fj4000> its not the last, its all of them - but the "last" just pokes through more
[15:38:26 EST(-0500)] <Bosmon> ok
[15:38:30 EST(-0500)] <fj4000> its a fix im getting ready for
[15:38:31 EST(-0500)] <Bosmon> I still don't see any targets in FF2
[15:38:37 EST(-0500)] <fj4000> you'll notice its not in the themed tabs
[15:38:44 EST(-0500)] <fj4000> sorry
[15:38:50 EST(-0500)] <fj4000> its ONLY in the themed tabs
[15:38:59 EST(-0500)] <Bosmon> The extra width?
[15:38:59 EST(-0500)] <Bosmon> Yes
[15:39:14 EST(-0500)] <Bosmon> The unthemed ones look good in every browser
[15:39:21 EST(-0500)] <Bosmon> The themed ones still have no drop targets in FF2
[15:39:25 EST(-0500)] <fj4000> yeah, FF2 is a bit of a problem
[15:39:57 EST(-0500)] <anastasiac> shoot - fj4000, Bosmon's right
[15:39:57 EST(-0500)] <fj4000> yes
[15:39:57 EST(-0500)] <anastasiac> FF2 is bad on the mac too
[15:39:57 EST(-0500)] <fj4000> I noticed too
[15:39:57 EST(-0500)] <ecochran> Poor Justin_o has a lot of catching up to do
[15:39:57 EST(-0500)] <Justin_o> fj4000: if your patch is ready, you can commit
[15:40:01 EST(-0500)] <michelled> ecochran: I'm hearing that you may have a patch that allows me to load the Uploader springboard without getting an error
[15:40:06 EST(-0500)] <fj4000> it should be a separate ticket though, to refactor the tabbing helper to avoid the problems as of late
[15:40:19 EST(-0500)] <Justin_o> ecochran: sorry for the delay, yes i think the button needs to be fixed
[15:40:23 EST(-0500)] <ecochran> michelled: I do
[15:40:34 EST(-0500)] <ecochran> waiting for fj4000 to review
[15:40:39 EST(-0500)] <ecochran> would you like to do it?
[15:40:43 EST(-0500)] <michelled> sure
[15:40:54 EST(-0500)] <fj4000> Justin_o: thanks, but as mentioned ^ I think im going to write another jira ticket for them
[15:40:56 EST(-0500)] <ecochran> I'll point you to the bug
[15:41:27 EST(-0500)] <Justin_o> fj4000: sorry i've been skimming through the channel... can you give me a quick summary
[15:41:33 EST(-0500)] <ecochran> michelled: http://issues.fluidproject.org/browse/FLUID-1935
[15:41:37 EST(-0500)] <ecochran> it's the "b" patch
[15:41:55 EST(-0500)] <ecochran> the other two are committed
[15:41:59 EST(-0500)] <fj4000> Justin_o: 1758 works in all but FF2
[15:42:12 EST(-0500)] <ecochran> Justin_o: OK, I'm working on it now.
[15:42:13 EST(-0500)] <fj4000> and I noticed there are other problems with the way the tabs are made
[15:42:17 EST(-0500)] <michelled> thanks ecochran
[15:42:22 EST(-0500)] <fj4000> so I need to refactor them
[15:42:29 EST(-0500)] <Justin_o> ecochran: i'll write you up a bug for it
[15:42:40 EST(-0500)] <ecochran> Justin_o: cool
[15:43:33 EST(-0500)] <fj4000> Bosmon, anastasiac: did we agree not to patch other people's css for fluid-1966?
[15:44:37 EST(-0500)] <Justin_o> fj4000: you should probably committ what you have so far and then file a patch for the new jira you create
[15:44:46 EST(-0500)] <Justin_o> i guess that's what your idea was though, eh
[15:44:59 EST(-0500)] <fj4000> yes, but thanks for the confirmation
[15:45:09 EST(-0500)] <Justin_o>
[15:45:57 EST(-0500)] <anastasiac> fj4000, Bosmon: We should patch the selectbox css with the fix, but anything that references our classes (i.e. the combo-editable and edit-container stuff) should not be added to the file
[15:46:36 EST(-0500)] <anastasiac> we should probably add a patch file as well, showing our patch to fix the bug, in case we upgrade to any upgraded version and need to re-apply the patch
[15:46:37 EST(-0500)] <fj4000> ok, then I need to talk to Bosmon about whats ours and whats theirs
[15:46:50 EST(-0500)] <anastasiac> the selectbox.css is theirs
[15:47:09 EST(-0500)] <anastasiac> anything inside that folder is theirs
[15:47:25 EST(-0500)] <fj4000> right, but there are some classes that just "appear"
[15:47:27 EST(-0500)] <fj4000> on load
[15:47:31 EST(-0500)] <fj4000> which arent anywhere
[15:47:39 EST(-0500)] <anastasiac> ?
[15:48:25 EST(-0500)] <fj4000> .editContainer is not in the markup
[15:48:29 EST(-0500)] <anastasiac> fj4000, do you want
[15:48:30 EST(-0500)] <fj4000> yet its there on load
[15:48:53 EST(-0500)] <anastasiac> editContainer is in the markup
[15:49:04 EST(-0500)] <anastasiac> dropdown.html, line 29
[15:54:41 EST(-0500)] <ecochran> fj4000: so FF3 will not style buttons with text-decoration: underline... fascists!
[15:55:33 EST(-0500)] <fj4000> yes, it sucks....I ran into this problem a couple weeks ago too
[15:55:53 EST(-0500)] <fj4000> wanted buttons to behave exactly like links
[15:57:50 EST(-0500)] <ecochran> my problem exactly!
[15:58:07 EST(-0500)] <ecochran> now... I'm not sure what to do
[15:58:16 EST(-0500)] <ecochran> do I make it look more button-y?
[15:58:23 EST(-0500)] <fj4000> be forwarned...there is also a width problem in IE too
[15:58:28 EST(-0500)] <fj4000> *forewarned
[15:58:34 EST(-0500)] <fj4000> but its solveable
[15:58:53 EST(-0500)] <ecochran> fj4000: tell me more...
[15:59:42 EST(-0500)] <fj4000> IE forces addition horizontal padding in relation to the width of the content inside the button....the more content, the more padding it "hardwires" into the button
[15:59:55 EST(-0500)] <fj4000> you cant turn it off with setting padding: 0
[16:00:05 EST(-0500)] <fj4000> but you can using overflow:visible
[16:00:07 EST(-0500)] <fj4000> go figure
[16:00:13 EST(-0500)] <ecochran> fj4000: I think that I can live with that
[16:00:49 EST(-0500)] <fj4000> yeah, in the end it looks normal, otherwise you have very stretched IE buttons
[16:00:53 EST(-0500)] <anastasiac> ecochran, Justin_o: Does FLUID-1935 need a review?
[16:01:28 EST(-0500)] <ecochran> anastasiac: michelled said that she'd look at it
[16:01:36 EST(-0500)] <ecochran> Justin_o: ^
[16:01:40 EST(-0500)] <anastasiac> cool, thanks
[16:01:51 EST(-0500)] * anastasiac is having trouble keeping up with the busy logs!
[16:02:13 EST(-0500)] <fj4000> ecochran: the best I could do to simulate the underline was to use border-bottom, but it wasnt the same at all
[16:03:07 EST(-0500)] <michelled> ecochran: the main change in the patch for 1935 seems to be related to fl-uploader-queue-wrapper. I guess the error I was seeing was because of the default selector for fileQueue.
[16:03:20 EST(-0500)] <michelled> yes?
[16:04:34 EST(-0500)] <ecochran> michelled: yes, kind of... the problem was that the Springboard already had a fl-uploader-queue
[16:05:07 EST(-0500)] <ecochran> so when I changed the name of another element to that class, we ended up with two and the FileQueueView code choked
[16:05:26 EST(-0500)] <michelled> yes
[16:06:52 EST(-0500)] <michelled> ok, the patch looks fine to me and the uploader works again in the springboard. One question, do we want all the style information in the html template?
[16:07:29 EST(-0500)] * colinclark (n=colin@142.150.154.101) has joined #fluid-work
[16:07:44 EST(-0500)] <colinclark> So it looks like Justin_o and I have narrowed in on the latest SWFUpload problem.
[16:07:48 EST(-0500)] <colinclark> Though I can't quite explain it.
[16:08:00 EST(-0500)] <colinclark> We've found two issues that appear to ultimately be interrelated.
[16:08:23 EST(-0500)] <colinclark> 1. In FF3, the Upload simply won't start. An error is thrown inside the JS-ActionScript bridge.
[16:08:49 EST(-0500)] <colinclark> 2. In some browsers (FF3, IE, Opera), you can't remove files. Another error is thrown inside the JS-ActionScript bridge.
[16:09:01 EST(-0500)] <colinclark> Interestingly, both of these issues go away if the Flash button is visible, not transparent.
[16:09:48 EST(-0500)] <colinclark> Does this sound correct, Justin_o?
[16:11:10 EST(-0500)] <Justin_o> colinclark: Yes, this is what I'm seeing too
[16:12:09 EST(-0500)] <colinclark> If we have to ship with a visible button, we can.
[16:12:22 EST(-0500)] <colinclark> This is a very unpleasant compromise, though, for a number of reasons.
[16:15:18 EST(-0500)] <ecochran> michelled: fj4000 found another bug with my patch for 1935
[16:15:42 EST(-0500)] <fj4000> one more q for ecochran
[16:15:56 EST(-0500)] <ecochran> fj4000: michelled has a comment above that you should respond to
[16:16:04 EST(-0500)] <ecochran> fj4000: shoot
[16:16:28 EST(-0500)] <fj4000> michelled: re: styles in the template, prob. not
[16:17:19 EST(-0500)] <fj4000> ecochran: did you notice the individual green progress "bars" are sort of showing at the beginnig?
[16:17:39 EST(-0500)] <fj4000> for the second example, after you brwose for a file
[16:17:48 EST(-0500)] <fj4000> there is a little green dot at the end of the name
[16:17:48 EST(-0500)] <ecochran> fj4000: I saw that. I wondered if that was part of your design
[16:17:59 EST(-0500)] <fj4000> no, its not supposed to be there
[16:18:06 EST(-0500)] <ecochran> Ok, I'll fix that too
[16:18:13 EST(-0500)] <fj4000> ok, thank you
[16:19:07 EST(-0500)] <ecochran> fj4000 and michelled: there are no styles in the template... only in the Springboard
[16:19:07 EST(-0500)] <michelled> Is it known that the remove icons stay visible in the second example even after the upload is done?
[16:19:25 EST(-0500)] <ecochran> michelled: I thought that I fixed that
[16:19:41 EST(-0500)] <michelled> I better make sure my cache is clean
[16:19:48 EST(-0500)] <fj4000> no, i noticed that too
[16:19:59 EST(-0500)] <ecochran> michelled: bummer
[16:20:29 EST(-0500)] <ecochran> fj4000 and michelled : OK, let's throw that patch out. Back to the drawing board
[16:20:36 EST(-0500)] <ecochran> I'm getting closer though
[16:20:39 EST(-0500)] <fj4000> yknow, I wonder if we have a tally of how long each components take to make in man-hours....
[16:21:07 EST(-0500)] <fj4000> some seem to pose the greatest challenges
[16:21:09 EST(-0500)] <ecochran> part of the problem was that I wasn't very familar with how these Springboards worked before I started hacking the code. '
[16:22:18 EST(-0500)] <fj4000> ecochran: i dont mean anything in particular, its just with swfupload and all the work going into some components, its like others must feel..a little left out
[16:22:45 EST(-0500)] <fj4000> we should refactor all the little guys just to make them feel special
[16:22:56 EST(-0500)] <colinclark> fj4000: Even the little guys get some attention.
[16:23:04 EST(-0500)] <colinclark> Pager is looking rather shiny, for example.
[16:23:11 EST(-0500)] <fj4000> i was just going to say.....
[16:23:25 EST(-0500)] <fj4000> Pretty little pager
[16:29:20 EST(-0500)] <anastasiac> Justin_o et al: what is left for me to work on/look at/review/whatever?
[16:29:37 EST(-0500)] <Justin_o> i'm just about to send out the latest version of the bug parade
[16:30:18 EST(-0500)] <Justin_o> i've been a little disconnected from what's been going on for the last bit, so if you could make sure it is up to date after i send it out. that would be helpful
[16:32:38 EST(-0500)] <Justin_o> anastasiac: ^ just sent it out
[16:32:52 EST(-0500)] <anastasiac> cool
[16:38:45 EST(-0500)] <ecochran> Justin_o and fj4000 : I have a fix for the Browse button being active during Upload... I have gone ahead and changed the link button to a button button.
[16:38:53 EST(-0500)] <ecochran> I need to test it on Windows
[16:39:00 EST(-0500)] <colinclark> ecochran: Ack!
[16:39:18 EST(-0500)] <colinclark> Can you make sure you test it very well against the FLUID-1768 branch?
[16:39:31 EST(-0500)] <colinclark> It "should work."
[16:39:39 EST(-0500)] <colinclark> But you know how it goes with SWFUpload.
[16:39:53 EST(-0500)] <ecochran> ah... yes... now I'm thinking that this is a bit more risky than I thought
[16:41:11 EST(-0500)] <colinclark> In theory it shouldn't be.
[16:41:29 EST(-0500)] <colinclark> We just seem to be accumulating risk at every level with this Flash 10 nonsense.
[16:42:31 EST(-0500)] <colinclark> So try it.
[16:42:33 EST(-0500)] <colinclark> See how it goes.
[16:42:43 EST(-0500)] <colinclark> It's just that the king is nearly ready to freeze us all.
[16:42:50 EST(-0500)] <fj4000> does this mean we "must" use a button element?
[16:43:21 EST(-0500)] <colinclark> fj4000: Good question.
[16:43:23 EST(-0500)] <ecochran> fj4000: well unless we can think of a way to reliably disabled the link during upload
[16:43:48 EST(-0500)] <fj4000> could we not use CSS + JS ?
[16:43:50 EST(-0500)] <anastasiac> Justin_o, fj4000 has committed the fix for FLUID-1758, and it looks good. He's files the related issue, so I think we're ready for you to test FLUID-1758, and close it if you deem appropriate.
[16:43:57 EST(-0500)] <ecochran> the only other thing that I can think of is for the browse code to check whether we're currently uploading
[16:44:08 EST(-0500)] <colinclark> ecochran: That would be easy to do, yes.
[16:44:12 EST(-0500)] <ecochran> but I didn't want to create that dependancy
[16:44:19 EST(-0500)] <ecochran> OK, let me look at that
[16:44:40 EST(-0500)] <ecochran> we already do the cSS part very nicely
[16:44:51 EST(-0500)] <ecochran> it's the code part that is a little tricky
[16:44:55 EST(-0500)] <ecochran> but not much
[16:44:55 EST(-0500)] <fj4000> oh
[16:45:08 EST(-0500)] <ecochran> and I like it better than what I just did which looks like crap on IE
[16:45:22 EST(-0500)] <ecochran> and is going to need more work anyway
[16:45:45 EST(-0500)] <ecochran> so I'm going to through off a patch, revert and then try this new approach
[16:46:22 EST(-0500)] <ecochran> Justin_o: did you ever write a bug for this bug?
[16:46:27 EST(-0500)] <ecochran> JIRA
[16:46:38 EST(-0500)] <Justin_o> ecochran: yes... sorry i guess i forgot to tell you...
[16:46:43 EST(-0500)] <Justin_o> i think it's 1977
[16:47:01 EST(-0500)] <Justin_o> sorry 1976
[16:47:26 EST(-0500)] <ecochran> thxs
[16:47:29 EST(-0500)] <anastasiac> Justin_o, I think FLUID-1901 is good to go, and can be closed now.
[16:47:40 EST(-0500)] <ecochran> what? you busy or sometin'? :-P
[16:47:55 EST(-0500)] <anastasiac> It will need some work, for the next release, but new JIRAs should be files
[16:47:56 EST(-0500)] <anastasiac> filed
[16:55:49 EST(-0500)] <ecochran> colinclark and fj4000 : that worked much better... much smaller safer fix... thank god for that.queue.isUploading
[16:56:01 EST(-0500)] * apetro (n=apetro@wsip-98-174-242-39.ph.ph.cox.net) has joined #fluid-work
[16:56:07 EST(-0500)] <colinclark>
[16:56:17 EST(-0500)] <colinclark> ecochran: Yes. A visible model is a wonderful thing.
[16:56:34 EST(-0500)] <colinclark> If only Gyphie had thought of that.
[16:56:54 EST(-0500)] <ecochran> colinclark: f- Gyphie!
[16:57:00 EST(-0500)] <colinclark> lol
[16:57:05 EST(-0500)] <fj4000> colinclark: one day, I need to sit down with you so you can explain how that works
[16:57:13 EST(-0500)] <fj4000> the "visible model" part
[16:57:14 EST(-0500)] <ecochran> sorry, I'm getting worked up!
[16:57:20 EST(-0500)] <colinclark> ecochran:
[16:57:22 EST(-0500)] <colinclark> Poor Gyphie.
[16:57:23 EST(-0500)] <ecochran> we're so close!
[16:57:30 EST(-0500)] <colinclark> fj4000: Of course!
[16:57:32 EST(-0500)] <ecochran> and I'm getting low blood sugar
[16:57:46 EST(-0500)] <colinclark> So Justin_o and I have had to make a decision on Flash 10 support.
[16:57:51 EST(-0500)] <colinclark> And I hate it, but it is workable.
[16:58:09 EST(-0500)] <colinclark> We are shipping with a visible, image-based Flash movie as the button.
[16:58:18 EST(-0500)] <colinclark> Transparent overlays appear to be too flaky at this point.
[16:58:24 EST(-0500)] <fj4000> damn
[16:58:36 EST(-0500)] <fj4000> flaky overlays - sound like a nice desert
[16:58:47 EST(-0500)] <fj4000> *dessert
[16:58:52 EST(-0500)] <colinclark> This means that we lose the "Add more" transition in Flash 10 (temporarily), and that when users increase the font size of the browser, Weird Things Happen.
[16:58:54 EST(-0500)] <colinclark> fj4000:
[16:58:55 EST(-0500)] <colinclark> yum
[16:59:12 EST(-0500)] <colinclark> Actually, since the whole holiday thing started, I have eaten too many desserts.
[16:59:22 EST(-0500)] <fj4000> ah, but it can be solved, ya know
[16:59:26 EST(-0500)] <fj4000> the whole scaling thing
[17:00:00 EST(-0500)] <colinclark> fj4000: It's not clear to me how we could do it quickly.
[17:00:13 EST(-0500)] <colinclark> FF3 and IE7 are both smart enough to scale the Flash movie accordingly.
[17:00:21 EST(-0500)] <colinclark> Which reveals the image underneath.
[17:00:26 EST(-0500)] <fj4000> quickly: I have no idea....but its an attribute on the object that does it
[17:00:36 EST(-0500)] <colinclark> And Gyphie doesn't bother to scale larger images down to a smaller size, so we're stuck either way.
[17:00:49 EST(-0500)] <fj4000> yikes.
[17:01:02 EST(-0500)] <ecochran> I've just submitted a patch to FLUID-1976 (the Browse button problem), can someone review it?
[17:01:03 EST(-0500)] <ecochran> http://issues.fluidproject.org/browse/FLUID-1976
[17:01:03 EST(-0500)] <fj4000> Have we tried setting the scaling mode on the object?
[17:01:22 EST(-0500)] <ecochran> colinclark: this'd probably take you a couple of seconds
[17:01:23 EST(-0500)] <colinclark> fj4000: What are the available options for scaling mode?
[17:01:30 EST(-0500)] <colinclark> ecochran: Yep, I'll take a look.
[17:02:22 EST(-0500)] <fj4000> I believe there is a fit-to-container, scale-to-container, and just 100% mode...I could be wrong, and of course those are not the real names....let me hunt a bit
[17:02:56 EST(-0500)] <colinclark> fj4000: that would be great, thanks
[17:03:43 EST(-0500)] <fj4000> colinclark; ok, so its called
[17:03:58 EST(-0500)] <fj4000> Default(Show all), No Border, Exact Fit
[17:04:05 EST(-0500)] <fj4000> all part of the SCALE parameter
[17:04:09 EST(-0500)] <fj4000> http://kb.adobe.com/selfservice/viewContent.do?externalId=tn_14149
[17:04:17 EST(-0500)] <fj4000> perhaps this can help a bit
[17:04:25 EST(-0500)] <fj4000> I hope
[17:04:36 EST(-0500)] * anastasiac (n=team@142.150.154.160) has left #fluid-work
[17:05:33 EST(-0500)] <fj4000> colinclark - so I would guess a strategy might look something like
[17:05:44 EST(-0500)] <fj4000> set the container for the overlay to a relative size in ems
[17:05:47 EST(-0500)] <ecochran> i'm going to go grab a couple of tacos (low bloodsugar). I'll be right back
[17:05:59 EST(-0500)] <fj4000> so when the text is sized, hopefully the container dimensions do too
[17:06:10 EST(-0500)] <colinclark> ecochran: TACOS!
[17:06:12 EST(-0500)] <fj4000> then set the flash object to width=100% height=100%
[17:06:22 EST(-0500)] <fj4000> and then set the appropriate scaling parameter
[17:06:28 EST(-0500)] <colinclark> fj4000: I can't quite figure this out.
[17:06:38 EST(-0500)] <colinclark> The issue here is that we actually don't want the movie to scale at all.
[17:06:42 EST(-0500)] <colinclark> We want it to be very stubborn.
[17:06:46 EST(-0500)] <colinclark> And refuse to change sizes.
[17:06:51 EST(-0500)] <fj4000> then use Exact Fit, I think
[17:07:08 EST(-0500)] <fj4000> oh wait, not that one
[17:07:27 EST(-0500)] <colinclark> Yeah, it looks like none of these will let us force the movie not to scale.
[17:07:38 EST(-0500)] <colinclark> Which is probably a good thing...
[17:07:44 EST(-0500)] <colinclark> ordinarily, it's totally evil not to scale nicely.
[17:08:06 EST(-0500)] <fj4000> what happens when you just set a width and height in real-world units? Very scary, but it might work
[17:08:13 EST(-0500)] <fj4000> like in or cm
[17:08:40 EST(-0500)] <fj4000> meh, even that prob. wont work
[17:09:36 EST(-0500)] <colinclark>
[17:15:41 EST(-0500)] <ecochran> back
[17:23:00 EST(-0500)] * colinclark_ (n=colin@142.150.154.247) has joined #fluid-work
[17:23:36 EST(-0500)] <colinclark_> ecochran: The cancel button in the Upload template is still a bit odd.
[17:23:46 EST(-0500)] <colinclark_> Should we get rid of it for this release, since it doesn't do anything?
[17:23:57 EST(-0500)] <colinclark_> It gets hidden upon upload, and then never reappears.
[17:25:02 EST(-0500)] <ecochran> colinclark: ah yes... I had intended to bring in the Cancel remaining Uploads button
[17:25:09 EST(-0500)] <ecochran> but... well.. we've been busy
[17:25:19 EST(-0500)] <ecochran> We probably should surpress it
[17:25:37 EST(-0500)] <colinclark_> michelled: Here's my FLUID-1768 server instance: http://142.150.154.247:8080/sakai-imagegallery2-web/site/BrowseImages/
[17:25:42 EST(-0500)] <michelled> thanks
[17:26:06 EST(-0500)] <ecochran> colinclark: let me fix this Springboard bug and then I'll think about Cancel
[17:26:12 EST(-0500)] <colinclark_> ecochran: ok
[17:26:14 EST(-0500)] <ecochran> ...we're running out of time
[17:26:17 EST(-0500)] <colinclark_> yep
[17:26:29 EST(-0500)] <colinclark_> reminds me of a month ago
[17:26:34 EST(-0500)] <colinclark_> only with more exciting results
[17:40:05 EST(-0500)] * clown (n=clown@guiseppi.atrc.utoronto.ca) has left #fluid-work
[17:48:07 EST(-0500)] <colinclark_> ecochran: There are still a couple of quirks with the remove buttons when we stop uploading. Have you noticed this before?
[17:48:27 EST(-0500)] <colinclark_> I guess this is probably a known issue that I am forgetting about due to lack of sleep.
[17:48:35 EST(-0500)] <ecochran> colinclark_: the only one that I know of is that you can keyboard into them
[17:48:37 EST(-0500)] <ecochran> is that it?
[17:49:06 EST(-0500)] <colinclark_> ecochran: No, they seem to just not work.
[17:49:12 EST(-0500)] <colinclark_> Let me triple-check here.
[17:49:15 EST(-0500)] <ecochran> oh... that one
[17:49:22 EST(-0500)] <ecochran> yes, I'd forgotten about that
[17:49:43 EST(-0500)] <ecochran> I'm finding a bunch of issues with the Uploader springboard that are not documented
[17:50:12 EST(-0500)] <ecochran> Justin_o: has the Uploader springboard ever been completely tested?
[17:50:28 EST(-0500)] <colinclark_> Unfortunately Justin_o is long gone. He just left his machine logged in.
[17:50:29 EST(-0500)] <michelled> Justin_o has left for the day
[17:50:40 EST(-0500)] <ecochran> bummer
[17:50:50 EST(-0500)] <colinclark_> This particular issue isn't in the springboard, it's in the template.
[17:51:03 EST(-0500)] <colinclark_> I just verified that it's an issue in trunk as well.
[17:51:06 EST(-0500)] <ecochran> no, I know... I just happen to be working on the Springboard right now
[17:51:10 EST(-0500)] <colinclark_> Once you stop, you can't remove files from the queue.
[17:51:14 EST(-0500)] <ecochran> yes
[17:51:18 EST(-0500)] <colinclark_> If you try to, strangeness can ensue.
[17:51:23 EST(-0500)] <ecochran> that should be pretty easy to fix
[17:51:23 EST(-0500)] <colinclark_> Ok, so it's a known issue.
[17:51:25 EST(-0500)] <ecochran> yes
[17:51:29 EST(-0500)] <colinclark_> Do you know what the fix is?
[17:51:30 EST(-0500)] <ecochran> I'm not sure that there is a bug
[17:51:42 EST(-0500)] <ecochran> well, I actually thought that I'd fixed it
[17:51:43 EST(-0500)] <colinclark_> When did it regress? I could have sworn I used to be able to do it.
[17:51:47 EST(-0500)] <colinclark_> I thought you'd fixed it too.
[17:51:48 EST(-0500)] <colinclark_> How odd.
[17:52:08 EST(-0500)] <ecochran> the problem is we have to enable all the buttons again after upload
[17:52:33 EST(-0500)] <ecochran> can I talk about the Uploader Springboard for a minute?
[17:52:42 EST(-0500)] <ecochran> I wish fj4000 was on
[17:53:05 EST(-0500)] <ecochran> I'll look at the remove button right now
[17:53:06 EST(-0500)] <colinclark_> ecochran: yep
[17:53:09 EST(-0500)] <ecochran> ok
[17:53:13 EST(-0500)] <ecochran> Springboard
[17:53:31 EST(-0500)] <ecochran> Jacob made all the buttons into links
[17:53:44 EST(-0500)] <ecochran> but I'm enabling and disabling them in code as if they are buttons
[17:53:51 EST(-0500)] <ecochran> links don't have a disabled attr
[17:54:03 EST(-0500)] <ecochran> so disabled buttons can be clicked in Springboard
[17:54:08 EST(-0500)] <colinclark_> yes, that's a bug in uploader
[17:54:16 EST(-0500)] <ecochran> causing lots of loverly problem
[17:54:18 EST(-0500)] <ecochran> s
[17:54:19 EST(-0500)] <colinclark_> yes
[17:54:29 EST(-0500)] <colinclark_> at this point, we're going to have to ship a non-ideal springboard for the uploader.
[17:54:36 EST(-0500)] <colinclark_> or we could chose to sandbox it this time around
[17:54:36 EST(-0500)] <ecochran> yep
[17:54:46 EST(-0500)] <ecochran> well
[17:54:49 EST(-0500)] <colinclark_> the point of the springboard is to show customization, but we're still not quite there.
[17:54:51 EST(-0500)] <ecochran> it's no worse than it was
[17:55:06 EST(-0500)] <colinclark_> uploader or the springboard?
[17:55:14 EST(-0500)] <ecochran> the Springboard
[17:55:20 EST(-0500)] <ecochran> although I'm wrong about that
[17:55:35 EST(-0500)] <michelled> it might be better to sandbox it
[17:55:45 EST(-0500)] <colinclark_> michelled: I think you're probably right.
[17:55:51 EST(-0500)] <ecochran> one of the things that the old Uploader1 code did was have a lot more state in the code and less in the UI
[17:55:57 EST(-0500)] <michelled> I know it's disheartening but it probably hasn't got the eyes and time it deserves
[17:56:09 EST(-0500)] <ecochran> sigh
[17:56:21 EST(-0500)] <colinclark_> michelled: Yes, I will try not to resent the cycles I've had to put into fixing Gyphie's mess.
[17:56:22 EST(-0500)] <ecochran> I agree
[17:56:23 EST(-0500)] <colinclark_>
[17:56:32 EST(-0500)] <colinclark_> ok, so let's sandbox it
[17:56:36 EST(-0500)] <ecochran> OK
[17:56:44 EST(-0500)] <colinclark_> ecochran: Do you want to look into the remove button issue?
[17:56:49 EST(-0500)] <ecochran> looking now
[17:57:19 EST(-0500)] <ecochran> michelled: I'd like to check in the fixes that I have for Sandbox... even if it feels like the tip of the iceburg
[17:57:35 EST(-0500)] <ecochran> I have improved a number of things in the last hour
[17:58:00 EST(-0500)] <ecochran> colinclark_: ^, you should chime in on this too
[17:58:03 EST(-0500)] <michelled> definitely worth doing
[17:58:22 EST(-0500)] <michelled> sandbox is fair game even in code freeze
[17:58:38 EST(-0500)] <ecochran> well it's not in the sandbox yet!
[17:58:47 EST(-0500)] <michelled> true
[17:58:53 EST(-0500)] <michelled> do you want me to review a patch?
[17:58:59 EST(-0500)] <ecochran> should I wait and save off my fixes and then check them into the sandbox?
[17:59:15 EST(-0500)] <ecochran> yes, I could give you a patch right now... hold on
[18:01:07 EST(-0500)] <colinclark_> ecochran: yeah, a patch will do the trick on all fronts.
[18:01:12 EST(-0500)] <colinclark_> make a patch
[18:01:19 EST(-0500)] <colinclark_> move the springboard to sandbox
[18:01:24 EST(-0500)] <colinclark_> apply the patch to sandbox
[18:01:30 EST(-0500)] <ecochran> OK, I'm adding it to the JIRA
[18:01:41 EST(-0500)] <michelled> 1935?
[18:02:00 EST(-0500)] <ecochran> you know... I'm going to create a new JIRA for these problems
[18:02:10 EST(-0500)] <ecochran> because then we can close 1935!
[18:02:12 EST(-0500)] <michelled> makes sense
[18:04:36 EST(-0500)] <colinclark_> ecochran:
[18:04:44 EST(-0500)] <colinclark_> closing issues is so satisfying
[18:04:51 EST(-0500)] <ecochran> yep
[18:04:56 EST(-0500)] <ecochran> I want to ship!
[18:05:01 EST(-0500)] <ecochran> and then I want to party
[18:05:04 EST(-0500)] <ecochran> and then I want to sleep
[18:09:21 EST(-0500)] <colinclark_> yes i agree
[18:09:31 EST(-0500)] <colinclark_> i think we're going to get some champagne here for thursdday
[18:14:00 EST(-0500)] <ecochran> michelled: colinclark_: FLUID-1980 documents the current Springboard Uploader bugs and contains the patch of todays work
[18:14:08 EST(-0500)] <colinclark_> ecochran: Great!
[18:14:46 EST(-0500)] <colinclark_> I'm about to merge FLUID-1768 into trunk. Do you want to wait to move the springboard until I'm done?
[18:14:50 EST(-0500)] <colinclark_> Just to be safe?
[18:14:59 EST(-0500)] <ecochran> colinclark_: did you ever get a chance to review my patch for 1976?
[18:15:00 EST(-0500)] <colinclark_> And then I'll review your other patch and commit it.
[18:15:02 EST(-0500)] <colinclark_>
[18:15:08 EST(-0500)] <ecochran> OK,
[18:15:33 EST(-0500)] <ecochran> hmm... I've never created a branch before... I assume that it's easy
[18:16:07 EST(-0500)] <ecochran> colinclark_: want to walk me through it?
[18:16:24 EST(-0500)] <colinclark_> ecochran: to move the springboard into the sandbox?
[18:16:37 EST(-0500)] <ecochran> yes
[18:16:46 EST(-0500)] <colinclark_> ecochran: You don't even need to make a branch.
[18:16:48 EST(-0500)] <ecochran> ok
[18:16:56 EST(-0500)] <colinclark_> michelled: Do you have a sec to walk ecochran through it while I merge my branch?
[18:17:12 EST(-0500)] <colinclark_> I don't know what the state of the springboards in the sandbox is like now
[18:17:24 EST(-0500)] <michelled> sure
[18:17:26 EST(-0500)] <colinclark_> But for awhile, Jacob was all set up out there in the sandbox boondocks
[18:17:33 EST(-0500)] <colinclark_> with externals set up and everything
[18:17:39 EST(-0500)] <michelled> I was just looking at your patch ecochran
[18:17:46 EST(-0500)] <ecochran> I think that the springboard sandbox is really really old
[18:17:49 EST(-0500)] <colinclark_> worst case, move it so that it is broken, and then we'll move it back in post-release
[18:17:50 EST(-0500)] <ecochran> and very dusty
[18:17:57 EST(-0500)] <colinclark_> ecochran: Not surprising.
[18:18:36 EST(-0500)] <ecochran> but my stuff is all in one file, that isn't in the current sandbox so I could just check it in there for safe keeping
[18:18:50 EST(-0500)] <ecochran> michelled: what say you?
[18:19:22 EST(-0500)] <michelled> looks fine so far. sorry, I'm a little distracted - trying to do too much at once
[18:19:32 EST(-0500)] <michelled> I haven't applied or tested it
[18:19:49 EST(-0500)] <ecochran> michelled: actually I was asking about the sandbox situation
[18:20:12 EST(-0500)] <michelled> so, I guess we could make a branch and then delete the springboard from the trunk
[18:20:30 EST(-0500)] <michelled> that way we can easily resurrect it once code freeze lifts
[18:20:35 EST(-0500)] <michelled> what do you think?
[18:20:42 EST(-0500)] <ecochran> I'm thinking of stuffing my currently changes in /html/Uploader.html into the Springboard sandbox html directory
[18:20:51 EST(-0500)] <ecochran> there isn't an Uploader one in there
[18:20:52 EST(-0500)] <michelled> because really, I wouldn't want this to stay in sandbox.
[18:20:59 EST(-0500)] <ecochran> makes sense
[18:21:08 EST(-0500)] <ecochran> so my instincts where correct
[18:21:13 EST(-0500)] <ecochran> I want to branch
[18:21:29 EST(-0500)] <ecochran> michelled: can you walk me through creating a branch
[18:21:31 EST(-0500)] <michelled> ya, lets do that
[18:21:41 EST(-0500)] <ecochran> I've done it before but I don't want to mess anything up
[18:21:41 EST(-0500)] <michelled> for sure - it's really easy - just a copy.
[18:21:54 EST(-0500)] <michelled> but I like to double check so one sec ...
[18:22:06 EST(-0500)] <ecochran> should I do it from the command line or from Aptana
[18:23:04 EST(-0500)] <ecochran> colinclark_: michelled thinks that I should branch...
[18:23:05 EST(-0500)] <michelled> I usually do it from the command line but Aptana should work
[18:23:15 EST(-0500)] <ecochran> OK, I think that I have it
[18:23:20 EST(-0500)] <colinclark_> ecochran: ok, that makes sense
[18:23:24 EST(-0500)] <colinclark_> go for it
[18:23:35 EST(-0500)] <michelled> svn copy fluid https://source.fluidproject.org/svn/fluid/components/branches/FLUID-1980
[18:23:36 EST(-0500)] <colinclark_> a lot easier than moving it into sandbox, you're right
[18:24:20 EST(-0500)] <michelled> where 'fluid' is your trunk directory
[18:24:24 EST(-0500)] <ecochran> http://source.fluidproject.org/svn/fluid/components/branches/FLUID-1980
[18:24:27 EST(-0500)] <michelled> does that make sense ecochran?
[18:24:45 EST(-0500)] <ecochran> michelled: does that look right... the path?
[18:24:52 EST(-0500)] <michelled> yes
[18:25:34 EST(-0500)] <michelled> but I think you need 'https'
[18:25:54 EST(-0500)] <ecochran> ah, and it needed a JIRA in the comment
[18:26:01 EST(-0500)] <michelled> yes
[18:27:47 EST(-0500)] <ecochran> OK, that was stupidly easy and I still managed to screw it up.
[18:28:05 EST(-0500)] <michelled> how so?
[18:28:14 EST(-0500)] <michelled> i'm looking at your branch - it's ok, isn't it?
[18:28:17 EST(-0500)] <ecochran> I had already reverted my changes after I created my patch so that I could start work on this other problem
[18:28:31 EST(-0500)] <ecochran> so the change that we wanted to save wasn't actually saved
[18:28:35 EST(-0500)] <ecochran> duh
[18:28:49 EST(-0500)] <michelled> I think that's probably the safer way anyway
[18:28:55 EST(-0500)] <michelled> a clean copy
[18:28:56 EST(-0500)] <michelled> and then apply the patch
[18:28:59 EST(-0500)] <michelled> and commit it
[18:29:15 EST(-0500)] <ecochran> OK, so then I have to check out my new branch
[18:29:20 EST(-0500)] <colinclark_> ecochran: Nice branch.
[18:29:23 EST(-0500)] <ecochran> thanks!
[18:29:32 EST(-0500)] <colinclark_> It does look like perhaps a chance to SWFUploadManager.js went along with it?
[18:29:33 EST(-0500)] <michelled> yup
[18:29:37 EST(-0500)] <colinclark_> Other than that, it's rocking.
[18:29:39 EST(-0500)] <ecochran> yep
[18:30:00 EST(-0500)] <ecochran> that I hadn't rolled back because it's such a small change
[18:30:23 EST(-0500)] <ecochran> that colinclark_ is going to review for me ...!!!! :-P
[18:32:32 EST(-0500)] <colinclark_> ecochran:
[18:33:27 EST(-0500)] * colinclark_ gets so nervous merging branches.
[18:35:41 EST(-0500)] <michelled> you know what ecochran, even though your branch is all new and shiny, I'm wondering if you should actually blow it away and create it anew.
[18:35:56 EST(-0500)] <michelled> colinclark_ is in the middle of a fairly big uploader merge/commit
[18:36:06 EST(-0500)] <ecochran> ok will do
[18:36:08 EST(-0500)] <michelled> and you'll have to go through it as well.
[18:36:22 EST(-0500)] <michelled> so instead you can wait for colin's final commit
[18:36:28 EST(-0500)] <michelled> and branch from there
[18:37:20 EST(-0500)] <michelled> also, if we use URLs for both the trunk and the branch we will avoid introducing uncommitted stuff
[18:37:49 EST(-0500)] <michelled> that should make the merging back into trunk after freeze has melted easier.
[18:38:52 EST(-0500)] <ecochran> michelled: now, I need you to tell me how to delete my shiny new branch
[18:40:02 EST(-0500)] <michelled> generally, I've deleted stuff that I have checked out and then commit that. but you can just use and URL
[18:40:04 EST(-0500)] <michelled> svn delete URL
[18:40:31 EST(-0500)] <ecochran> michelled: great!
[18:42:47 EST(-0500)] <ecochran> michelled: that seemed to go well
[18:42:57 EST(-0500)] <michelled> great
[18:44:34 EST(-0500)] <colinclark_> ok, it's in
[18:44:44 EST(-0500)] <colinclark_> so now you can remake you rbranch
[18:44:48 EST(-0500)] <colinclark_> ecochran
[18:44:53 EST(-0500)] <ecochran> colinclark_: got it
[18:44:58 EST(-0500)] <colinclark_> this time you can use urls on both sides of the equation
[18:44:58 EST(-0500)] <ecochran> just updated
[18:45:05 EST(-0500)] <colinclark_> so that no stray changes will sneak in
[18:45:12 EST(-0500)] <ecochran> michelled: I'm trying to send you a non-work file by IM
[18:45:23 EST(-0500)] <colinclark_> svn copy URL_TO_TRUNK URL_TO_YOUR_BRANCH
[18:47:18 EST(-0500)] <colinclark_> ecochran: A couple of suggestions for 1976
[18:47:27 EST(-0500)] <ecochran> ok
[18:47:35 EST(-0500)] <colinclark_> I think the change to browse is a lot like the 1947 patch...
[18:47:46 EST(-0500)] <colinclark_> Avoiding nested if statements can help improve readability.
[18:48:02 EST(-0500)] <colinclark_> And, weirdly, there have been studies that shows it reduces erros.
[18:48:19 EST(-0500)] <colinclark_> So I might do a "check for the case we don't want, then bail"
[18:48:56 EST(-0500)]
[18:49:03 EST(-0500)] <ecochran> yeah, that's fine... it's just not a pattern that I'm used to
[18:49:29 EST(-0500)] <ecochran> I can make that change
[18:49:30 EST(-0500)] <colinclark_> And then, in the call to browse() down in that.browseForFiles(), you added a third argument...
[18:49:49 EST(-0500)] <ecochran> the that
[18:49:55 EST(-0500)] <colinclark_> but since you need "that" as one of them, there's probably no need to also pass that.swfUploader along too
[18:50:50 EST(-0500)] <ecochran> so just pass the that and parse the other two out of it?
[18:50:56 EST(-0500)] <colinclark_> yep, exactly
[18:50:59 EST(-0500)] <ecochran> cool
[18:51:15 EST(-0500)] <ecochran> I thought of that... but I was trying to make as few changes as possible
[18:51:48 EST(-0500)] <colinclark_> yeah, sometime that can be good if you're trying to tread lightly
[18:51:58 EST(-0500)] <colinclark_> but in most situations, go for the cleaner fix
[18:57:00 EST(-0500)] <ecochran> colinclark_: I'll make you a new patch
[19:02:00 EST(-0500)] <colinclark_> Ok, so I guess there are three things left on my radar before going home to that bottle of wine...
[19:02:12 EST(-0500)] <colinclark_> 1. FLUID-1976, which sounds like it's nearly ready to go
[19:02:17 EST(-0500)] <colinclark_> 2. The cancel button
[19:02:23 EST(-0500)] <colinclark_> 3. The remove buttons being broken.
[19:02:44 EST(-0500)] <colinclark_> At the moment, those are all things you were going to look at ecochran. Can I take on one or more of them?
[19:03:43 EST(-0500)] <ecochran> well, shall I make you a new patch for 1976 or shall I make those changes and check in and you can review?
[19:03:50 EST(-0500)] <colinclark_> ecochran: Go ahead and just commit.
[19:03:55 EST(-0500)] <ecochran> great
[19:04:02 EST(-0500)] * famicom (i=famicom@5ED2FF2D.cable.ziggo.nl) has joined #fluid-work
[19:04:04 EST(-0500)] <colinclark_> You've got the fix, and it's just a tiny change from what you were already doing.
[19:04:08 EST(-0500)] <colinclark_> Ah, there's also 4. Making a branch and removing Springboard.
[19:04:18 EST(-0500)] <colinclark_> ecochran: Do you want me to do that one now?
[19:04:27 EST(-0500)] <ecochran> that would be great!
[19:05:42 EST(-0500)] <colinclark_> k
[19:08:57 EST(-0500)] <ecochran> hmm, this remove button things is troubling... definitely missing some code in there that I wrote
[19:09:54 EST(-0500)] <colinclark_> ecochran: uh oh
[19:09:59 EST(-0500)] <colinclark_> well, at least you wrote it
[19:10:07 EST(-0500)] <colinclark_> and thus we can re-apply if we're lucky
[19:11:34 EST(-0500)] <colinclark_> ecochran: +1 on your 1976 commit
[19:11:46 EST(-0500)] <ecochran> colinclark_: thxs
[19:13:17 EST(-0500)] <ecochran> colinclark_: got a good way to search through old revisions for a string?
[19:13:24 EST(-0500)] <michelled> ok, I'm off for the night - good luck
[19:13:29 EST(-0500)] * michelled (n=team@142.150.154.197) has left #fluid-work
[19:13:43 EST(-0500)] <colinclark_> ecochran: Not off the top of my head, sorry.
[19:13:58 EST(-0500)] <colinclark_> I can search my email for commit logs if that helps
[19:14:02 EST(-0500)] <colinclark_> I keep 'em all archived
[19:15:15 EST(-0500)] <colinclark_> ecochran: ^
[19:15:48 EST(-0500)] <ecochran> colinclark_: that's a good idea... I'm getting tired and not thinking
[19:15:55 EST(-0500)] <colinclark_> no worries
[19:16:00 EST(-0500)] <colinclark_> we're in the home stretch now
[19:16:01 EST(-0500)] <ecochran> although I don't keep all of them
[19:17:57 EST(-0500)] <colinclark_> Ok, uploader springboard is exiled to the FLUID-1980 branch.
[19:18:06 EST(-0500)] <colinclark_> ecochran: Shall I go ahead and remove the Cancel button?
[19:18:14 EST(-0500)] <ecochran> please
[19:18:40 EST(-0500)] <colinclark_> k
[19:27:11 EST(-0500)] <ecochran> colinclark_: I don't even know what bug number this Remove button problem is but I have a patch. I just rewrote it from memory. Luckily it was very memorable because I gave the function an odd name
[19:27:23 EST(-0500)] <colinclark_>
[19:27:25 EST(-0500)] <colinclark_> Does it work?
[19:29:42 EST(-0500)] <colinclark_> The Upload button looks so lonely without its Cancel button friend.
[19:31:19 EST(-0500)] <colinclark_> ecochran: Minor bug in our browse() tweak...
[19:31:32 EST(-0500)] <ecochran> ?
[19:31:37 EST(-0500)] <ecochran> it works
[19:31:43 EST(-0500)] <ecochran> what's my bug?
[19:31:43 EST(-0500)] <colinclark_> It looks like isUploading isn't getting set correctly upon finish.
[19:31:49 EST(-0500)] <colinclark_> our bug
[19:31:50 EST(-0500)] <ecochran> crap!
[19:31:54 EST(-0500)] <colinclark_> And so Add more doesn't work.
[19:32:00 EST(-0500)] <colinclark_> I'll take a look.
[19:32:01 EST(-0500)] <ecochran> hmm
[19:32:04 EST(-0500)] <colinclark_> You keep on your current bug
[19:32:09 EST(-0500)] <colinclark_> We are so close.
[19:32:10 EST(-0500)] <ecochran> I thought that I tested it
[19:32:16 EST(-0500)] <ecochran> but I might have missed it
[19:32:39 EST(-0500)] <ecochran> oh, onComplete!
[19:32:57 EST(-0500)] <ecochran> <smack head with palm of hand>
[19:33:09 EST(-0500)] <colinclark_>
[19:33:30 EST(-0500)] <ecochran> colinclark_: I have to write up another bug for that other problem
[19:33:39 EST(-0500)] <colinclark_> ecochran: Okay
[19:33:46 EST(-0500)] <ecochran> kings away! mice at play
[19:33:51 EST(-0500)] <colinclark_>
[19:33:59 EST(-0500)] <colinclark_> I am keeping an email handy with a list of all the last minute things we have done for the King's benefit.
[19:34:06 EST(-0500)] <colinclark_> Hopefully he won't be displeased.
[19:34:12 EST(-0500)] <ecochran> yes, he deserves no less
[19:34:26 EST(-0500)] <colinclark_> It looks like we only ever set isUploading when an error occurs.
[19:34:27 EST(-0500)] <colinclark_> Oops
[19:34:32 EST(-0500)] * colinclark_ is sheepish.
[19:39:16 EST(-0500)] <ecochran> here is the fix for the disabled Remove buttons: http://issues.fluidproject.org/browse/FLUID-1982
[19:39:35 EST(-0500)] <colinclark_> ecochran: Cool.
[19:39:38 EST(-0500)] <ecochran> my name for the function may be a bit obtuse, it is a play on prepareForUpload
[19:39:44 EST(-0500)] <ecochran> repairFromUpload
[19:39:46 EST(-0500)] <colinclark_> I'll trade you for my isUploading patch momentarily.
[19:42:21 EST(-0500)] <colinclark_> ecochran: http://issues.fluidproject.org/browse/FLUID-1976
[19:42:35 EST(-0500)] <ecochran> great
[19:43:05 EST(-0500)] <colinclark_> ecochran: Should your fix be done in the queue, rather than in Uploader.js itself?
[19:44:28 EST(-0500)] <colinclark_> sorry, sorry
[19:44:39 EST(-0500)] <colinclark_> i am still confused by the fact that i moved code around
[19:45:04 EST(-0500)] <ecochran> you had me confused too
[19:46:59 EST(-0500)] <colinclark_> I'm just testing your patch on the server version.
[19:47:02 EST(-0500)] <colinclark_> ecochran: ^
[19:47:16 EST(-0500)] <ecochran> colinclark_: ^ yes please
[19:49:09 EST(-0500)] <colinclark_> ecochran: Nope, it looks like it broke.
[19:49:30 EST(-0500)] <ecochran> colinclark_: yours looks good
[19:49:35 EST(-0500)] <ecochran> what broke
[19:49:41 EST(-0500)] <ecochran> ?
[19:50:07 EST(-0500)] <colinclark_> ecochran: Well, there seems to be two things here.
[19:50:16 EST(-0500)] <colinclark_> Gimme one more second.
[19:50:58 EST(-0500)] <colinclark_> ecochran: If you delete the next file in line, we throw an error in progressBar.repositionIndicator
[19:51:08 EST(-0500)] <colinclark_> that.progressBar.position() is undefined.
[19:51:18 EST(-0500)] <colinclark_> Presumably because we are trying to update a progress bar that is now gone.
[19:51:32 EST(-0500)] <ecochran> ????
[19:51:34 EST(-0500)] <colinclark_> Otherwise, if we delete something further down in the file, it seems to just stick.
[19:53:09 EST(-0500)] <ecochran> but I don't mess with the progress bars on remove!!!
[19:53:17 EST(-0500)] <ecochran> which might be a bug!
[19:54:04 EST(-0500)] <colinclark_> ecochran: Well, it's getting pretty late. What do you recommend we do?
[19:54:11 EST(-0500)] <colinclark_> Ship it without the ability to remove, or try to fix?
[19:54:39 EST(-0500)] <ecochran> colinclark_: I don't know. I'm pretty tired too...
[19:54:48 EST(-0500)] <ecochran> I don't really understand the error
[19:54:55 EST(-0500)] <colinclark_> ecochran: Ok, let's hold off.
[19:55:00 EST(-0500)] <ecochran> I can try to get my head around it
[19:55:10 EST(-0500)] <colinclark_> So is there anything we can do to make the "can't delete after start" issue a little less awkward?
[19:55:22 EST(-0500)] <colinclark_> Maybe just ensure that all of the remove buttons stay grayed out?
[19:55:37 EST(-0500)] <ecochran> remove remove entirely?
[19:56:10 EST(-0500)] <colinclark_> ecochran: Do you feel comfortable doing that this late in the game?
[19:56:18 EST(-0500)] <colinclark_> Seem to me we have three choices:
[19:56:20 EST(-0500)] <colinclark_> 1. Leave it as is.
[19:56:28 EST(-0500)] <colinclark_> 2. Grey out the one row that seems to ungrey itself.
[19:56:28 EST(-0500)] <ecochran> ah, not reactivate the current one
[19:56:37 EST(-0500)] <colinclark_> 3. remove the buttons altogether.
[19:56:51 EST(-0500)] <colinclark_> Whichever one seems safest this late in the game, along with best for the user. THoughts?
[19:57:18 EST(-0500)] <ecochran> I think that they are all equally bad
[19:57:44 EST(-0500)] <ecochran> I almost think that it's better to ship with one that looks like a bug than one that just makes you go "huh?"
[19:58:04 EST(-0500)] <colinclark_> ecochran: I'm cool with any of the options.
[19:58:04 EST(-0500)] <ecochran> can I see your build?
[19:58:07 EST(-0500)] <colinclark_> yep
[19:58:11 EST(-0500)] <colinclark_> one sec
[19:58:49 EST(-0500)] <colinclark_> http://142.150.154.247:8080/sakai-imagegallery2-web/site/AddImages/
[20:00:38 EST(-0500)] <ecochran> can you show me... I can't repro
[20:00:48 EST(-0500)] <colinclark_> k
[20:12:39 EST(-0500)] <ecochran> colinclark_: comment out line 68 in Uploader.js and test
[20:13:01 EST(-0500)] <ecochran> side-effect is that the success icon is dimmed
[20:13:21 EST(-0500)] <colinclark_> k
[20:15:06 EST(-0500)] <ecochran> OK, here's my un-fix (the better bug), still at line 68
[20:15:07 EST(-0500)] <ecochran> if (file.filestatus === fluid.uploader.fileStatusConstants.COMPLETE) {
[20:15:07 EST(-0500)] <ecochran> that.locate("fileIconBtn", fileRowElm).removeClass("dim");
[20:15:07 EST(-0500)] <ecochran> }
[20:15:23 EST(-0500)] <ecochran> colinclark_: ^
[20:15:26 EST(-0500)] <colinclark_> ecochran: k
[20:15:30 EST(-0500)] <colinclark_> just testing with the server.
[20:16:10 EST(-0500)] <ecochran> colinclark_: sorry, I'm being a lazy ass and not creating a patch
[20:16:15 EST(-0500)] <colinclark_> np
[20:16:16 EST(-0500)] <colinclark_> easy
[20:19:08 EST(-0500)] <colinclark_> ecochran: It works.
[20:19:19 EST(-0500)] <ecochran> sigh
[20:19:23 EST(-0500)] <colinclark_> Interesting side effect is that check items higher up in the queue still get grayed out.
[20:19:26 EST(-0500)] <colinclark_> Bu I think we can live with it.
[20:19:44 EST(-0500)] <ecochran> did you try my revision?
[20:19:46 EST(-0500)] <ecochran> if (file.filestatus === fluid.uploader.fileStatusConstants.COMPLETE) {
[20:19:46 EST(-0500)] <ecochran> that.locate("fileIconBtn", fileRowElm).removeClass("dim");
[20:19:46 EST(-0500)] <ecochran> }
[20:19:56 EST(-0500)] <colinclark_> ecochran: yep, that's with your revision
[20:19:59 EST(-0500)] <ecochran> hmm
[20:20:07 EST(-0500)] <colinclark_> not all the checked items get grayed out, just the ones above the point of stopping
[20:20:10 EST(-0500)] <colinclark_> after they are started
[20:20:16 EST(-0500)] <colinclark_> and they never go back to ungray
[20:20:21 EST(-0500)] <ecochran> yeah,
[20:20:29 EST(-0500)] <ecochran> I kinda knew that one
[20:20:31 EST(-0500)] <colinclark_> k
[20:20:34 EST(-0500)] <ecochran> cool
[20:20:35 EST(-0500)] <colinclark_> let's go with this
[20:20:36 EST(-0500)] <colinclark_>
[20:20:39 EST(-0500)] <ecochran> did you check in your other patch
[20:21:06 EST(-0500)] <colinclark_> ecochran: Yep
[20:21:09 EST(-0500)] <ecochran> cool
[20:22:53 EST(-0500)] <colinclark_> Done. I'll send my email to Justin.
[20:23:00 EST(-0500)] <ecochran> colinclark_: ok, I'm checked in
[20:23:02 EST(-0500)] <colinclark_> Well, we shipped.
[20:23:14 EST(-0500)] <colinclark_> Which is really the hardest part.
[20:23:15 EST(-0500)] <ecochran> I'm a bit bitter-sweet
[20:23:19 EST(-0500)] <ecochran> but it's OK
[20:23:25 EST(-0500)] <colinclark_> It's not a perfect release.
[20:23:29 EST(-0500)] <ecochran> that last bug really took the wind out of my sails
[20:23:32 EST(-0500)] <colinclark_> But it's out there for people to look at.
[20:23:32 EST(-0500)] <ecochran> we were so close
[20:23:50 EST(-0500)] <ecochran> but it's still a much better piece of code than a month ago
[20:23:51 EST(-0500)] <colinclark_> ecochran: Yeah, we probably should have held off a bit on the Stop button, given how many layers of bugs seems to be related to that part of SWFUpload.
[20:23:57 EST(-0500)] <colinclark_> But I guess we didn't know at the time.
[20:24:08 EST(-0500)] <colinclark_> And yes, it's much better code than it's ever been, which is awesome.
[20:24:27 EST(-0500)] <ecochran> nah, we're very close... we just exposed some things that were unexpected
[20:24:36 EST(-0500)] <ecochran> and we improved some things because of it
[20:25:11 EST(-0500)] <colinclark_> yep, true
[20:25:11 EST(-0500)] <colinclark_> ok, I'm going to hit the road
[20:25:15 EST(-0500)] <colinclark_> Darcie has been waiting for me. I feel awful.
[20:25:21 EST(-0500)] <ecochran> me too
[20:25:26 EST(-0500)] <colinclark_> thanks again
[20:25:28 EST(-0500)] <colinclark_> nice work, dudue
[20:25:29 EST(-0500)] <colinclark_> due
[20:25:30 EST(-0500)] <colinclark_> dude
[20:25:32 EST(-0500)] <colinclark_> whatever
[20:25:32 EST(-0500)] <ecochran> Charlotte and Hannah are about to pull up outside
[20:25:33 EST(-0500)] <colinclark_>
[20:25:34 EST(-0500)] <ecochran> you too!
[20:25:38 EST(-0500)] <colinclark_>
[20:25:41 EST(-0500)] <ecochran> good night
[21:52:36 EST(-0500)] * phiggins (n=dante@c-68-34-199-67.hsd1.tn.comcast.net) has joined #fluid-work
Unknown macro: {position}
Unknown macro: {position}
Unknown macro: { return; }
Manage space
Manage content
Integrations