Skip to end of metadata
Go to start of metadata

You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 58 Current »

[05:14:49 CDT(-0500)] <chrispetsos> Hi Justin_o, i know this must be very early there, but any time you are here ping me please, in order to continue our conversation on the new infusion lib

[07:44:26 CDT(-0500)] <Justin_o> chrispetsos: hello

[07:44:50 CDT(-0500)] <chrispetsos> justin_o: hi

[07:45:34 CDT(-0500)] <chrispetsos> Justin_o: do you have some time? have you seen my last email?

[07:46:05 CDT(-0500)] <Justin_o> chrispetsos: yes.. i'm just taking a look at your code now.. so you are getting an error about the iframe still?

[07:46:52 CDT(-0500)] <chrispetsos> Justin_o: yes, if i remove the frame markup and that.jQuery error if i add it

[07:48:10 CDT(-0500)] <Justin_o> chrispetsos: interesting.. looking at the code i would have thought that what you did would have changed the prefsEditor.. let me try to run it.

[07:48:35 CDT(-0500)] <chrispetsos> Justin_o: OK

[07:54:17 CDT(-0500)] <Justin_o> chrispetsos: it has to do with the renaming.. you need to change uioType to prefsEditorType

[07:54:34 CDT(-0500)] <Justin_o> in your demo.js file

[07:55:34 CDT(-0500)] <Justin_o> i'll reply to your e-mail about that as well.

[07:56:58 CDT(-0500)] <chrispetsos> Justin_o: yes that did it, thanks. I'll get back to you if i need something more...

[07:57:23 CDT(-0500)] <Justin_o> chrispetsos: sounds good

[08:51:21 CDT(-0500)] <chrispetsos> Justin_o: OK, managed to create the first adjuster with the new Infusion lib, thanks! And going on...

[08:52:17 CDT(-0500)] <Justin_o> chrispetsos: great, oh by the way, we have a new way to do the strings, but we haven't updated the docs yet.. i'll try to get to that as soon as i can..

[09:05:45 CDT(-0500)] <colinclark> jessm: ux meeting is in an hour, is that right?

[09:05:59 CDT(-0500)] <jessm> colinclark: i believe so

[09:06:02 CDT(-0500)] <colinclark> I guess everything will go back to normal next week

[09:06:16 CDT(-0500)] <jessm> yep

[09:29:49 CDT(-0500)] <jessm> macfans: http://jamesfriend.com.au/pce-js/

[10:17:29 CDT(-0500)] <Justin_o> anastasiac: i have a fix for FLUID-5201 in my branch https://github.com/jobara/infusion/tree/FLUID-5201

[10:17:43 CDT(-0500)] <Justin_o> i'm going to try to fix up the other things as well and send a single pull request for all

[10:18:54 CDT(-0500)] <anastasiac> Justin_o, do you think you know how to fix the other issues?

[10:30:58 CDT(-0500)] <Justin_o> anastasiac: i'm not sure yet.. i'm going to try to investigate them some more..

[11:13:29 CDT(-0500)] <amilchev> hi Justin_o, I'm not sure if you understood my question in the list - [Ux] Combining two or more textfieldSteppers inside one panel

[11:14:24 CDT(-0500)] <Justin_o> amilchev: would you like to talk about it here a bit more

[11:14:34 CDT(-0500)] <amilchev> Justin_o: exactly

[11:15:15 CDT(-0500)] <amilchev> Justin_o: I pushed it in a new branch, you could run this file https://github.com/radmanovi4/prefsEditors/blob/gpii-271/demos/pcp/index.html

[11:15:37 CDT(-0500)] <amilchev> Justin_o: and see how the two textfieldSteppers share the same value

[11:16:59 CDT(-0500)] <amilchev> Justin_o: this is really work in process, ignore anything that seems strange to you (smile) I'm just trying to have 2 textfieldSteppers working in the same panel (with no success).

[11:18:41 CDT(-0500)] <amilchev> Justin_o: you could type "hook.model" in the console to check the current model - the upper textfieldStepper's value is stored in "value", the second one - "value2"

[11:19:47 CDT(-0500)] <amilchev> tell me what you get whenever you can, it's not that urgent

[11:22:42 CDT(-0500)] <Justin_o> amilchev: sorry, was looking through the code.. where is the preference map?

[11:24:03 CDT(-0500)] <amilchev> Justin_o: https://github.com/radmanovi4/prefsEditors/blob/gpii-271/src/shared/adjusters/pcp/js/speakTextPanels.js#L39-L74

[11:26:13 CDT(-0500)] <amilchev> Justin_o: here are the decorators: https://github.com/radmanovi4/prefsEditors/blob/gpii-271/src/shared/adjusters/pcp/js/speakTextCollectivePanel.js#L22-L49

[11:30:35 CDT(-0500)] <Justin_o> i'm going to guess that this is the problem https://github.com/radmanovi4/prefsEditors/blob/gpii-271/src/shared/adjusters/pcp/js/textfieldStepper.js#L149

[11:34:10 CDT(-0500)] <amilchev> yeah, sounds like it is...

[11:34:14 CDT(-0500)] <Justin_o> actually maybe it's line 145 that is the problem

[11:35:24 CDT(-0500)] <Justin_o> i guess they work together.. so you are sharing the model, which is updated externally by the other, and thus triggers model to update on the next one.

[11:35:28 CDT(-0500)] <Justin_o> at least it looks like that..

[11:36:35 CDT(-0500)] <Justin_o> amilchev: by the way, for now you should actually just make these completely separate panels and not worry about combining them into a larger panel.. I'll have the composite panel ready for use soon.. although anastasiac uncovered some bugs in it that i'm trying to weed out at the moment

[11:36:58 CDT(-0500)] <Justin_o> amilchev: but you should fix up this issue too.. i would suggest making use of the modelRelay system for now

[11:37:40 CDT(-0500)] <amilchev> Justin_o: isn't modelRelay useful when we need to coordinate two components' models?

[11:38:52 CDT(-0500)] <Justin_o> amilchev: yes.. but you are sort of doing that now, by sharing a model directly, as is on line 145

[11:39:11 CDT(-0500)] <Justin_o> amilchev: you should just keep the models separate and use the model relay to keep them in sync

[11:39:46 CDT(-0500)] <amilchev> Justin_o: ohh, I don't want them synchronised in any way

[11:40:03 CDT(-0500)] <amilchev> Justin_o: they have nothing to do with each other

[11:40:37 CDT(-0500)] <amilchev> Justin_o: I need them completely independant..

[11:40:54 CDT(-0500)] <Justin_o> amilchev: right not between the two textfieldSteppers for sure.. but you want the model of a textfieldStepper to be inSync with it's parent..

[11:41:27 CDT(-0500)] <amilchev> Justin_o: for that, yes undoubtedly..

[11:41:56 CDT(-0500)] <Justin_o> amilchev: so you'll need the model relay for that

[11:42:05 CDT(-0500)] <Justin_o> amilchev: right now by sharing the model like this https://github.com/radmanovi4/prefsEditors/blob/gpii-271/src/shared/adjusters/pcp/js/textfieldStepper.js#L145

[11:42:29 CDT(-0500)] <Justin_o> you are actually giving both of the textfieldSteppers the same model

[11:43:14 CDT(-0500)] <Justin_o> internally the textfieldStepper only works on the model path "value"

[11:49:53 CDT(-0500)] <amilchev> Justin_o: I think this was a temporary solution Evgeni created..

[11:50:38 CDT(-0500)] <amilchev> Justin_o: thanks, I'll stick to creating separate panels for each adjuster

[11:54:35 CDT(-0500)] <Justin_o> amilchev: okay.. let me know if you need anything else

[11:55:03 CDT(-0500)] <amilchev> Justin_o: thanks (smile)

[13:13:40 CDT(-0500)] <anastasiac> Justin_o, I've tested your branch for FLUID-5201, which fixes the slider rendering, and now this problem (i.e. the controls not reflecting the defaults) is showing up for the slider, as well.

[13:13:50 CDT(-0500)] <anastasiac> I've commented to that effect on the 5202 jira

[13:15:15 CDT(-0500)] <Justin_o> anastasiac: thanks.. i'm working onf FLUID-5202 now, so this is perfect timing

[13:21:11 CDT(-0500)] <anastasiac> Justin_o, I filed the textfieldSlider issue: http://issues.fluidproject.org/browse/FLUID-5203

[13:21:16 CDT(-0500)] <anastasiac> and added it to the iteration page

[13:30:48 CDT(-0500)] <Justin_o> anastasiac: thanks

[13:54:12 CDT(-0500)] <colinclark> hey yzen

[13:54:38 CDT(-0500)] <colinclark> Have you met the-t-in-rtf yet?

[13:57:46 CDT(-0500)] <yzen> colinclark:

[13:57:58 CDT(-0500)] <yzen> hi

[13:58:04 CDT(-0500)] <yzen> hi the-t-in-rtf

[13:58:07 CDT(-0500)] <yzen> i think so last week

[13:58:46 CDT(-0500)] <colinclark> Cool

[13:59:04 CDT(-0500)] <colinclark> So, Tony (i.e. the-t-in-rtf) is working on the Common Terms Registry

[13:59:08 CDT(-0500)] <colinclark> I made a new repo for it today

[13:59:12 CDT(-0500)] <colinclark> in the GPII github org

[13:59:28 CDT(-0500)] <colinclark> He was also mentioning how terribly inadequate our Kettle documentation is, in terms of working examples

[13:59:32 CDT(-0500)] <colinclark> which of course is to be expected

[13:59:37 CDT(-0500)] <colinclark> for such new software

[13:59:55 CDT(-0500)] <colinclark> but I'm hoping you might be able to answer his questions and share some examples of how you've used it, if he needs it

[14:01:30 CDT(-0500)] <yzen> colinclark, the-t-in-rtf definitely

[14:01:37 CDT(-0500)] <colinclark> awesome

[14:01:45 CDT(-0500)] <colinclark> he tends to work on Thursdays and Fridays, I think

[14:08:42 CDT(-0500)] <Bosmon> anastasiac - thanks for all the detail on your composite panels JIRAs

[14:09:00 CDT(-0500)] <Bosmon> In fact, if I'm not mistaken, the detail is now sufficient to allow the problems to be straightforwardly resolved - is this right, Justin_o? : P

[14:09:02 CDT(-0500)] <anastasiac> Bosmon, thanks for your patience. I hope it's enough info

[14:16:51 CDT(-0500)] <Justin_o> Bosmon: i think so.. in fact i have fixes for FLUID-5201 and FLUID-5202 already in branches in my repo

[14:17:02 CDT(-0500)] <Justin_o> Bosmon: any recommendations on how to take care of FLUID-5200 though

[14:17:26 CDT(-0500)] <Bosmon> Justin_o - well, surely the answer is just that you should do the necessary rewriting? : P

[14:18:00 CDT(-0500)] <Justin_o> Bosmon: if i remember correctly "..::" is a reference to some parent.. and these could be or arbitrary length, depending on nesting within the tree.. is that correct?

[14:18:53 CDT(-0500)] <Bosmon> Justin_o - I imagine that's not relevant since you always rewrite the tree in order to keep the original siblings next to each other?

[14:19:05 CDT(-0500)] <Bosmon> So the first segment I imagine will always stay fixed as ..:: ?

[14:19:41 CDT(-0500)] <Bosmon> I imagine all you need to do is insert the correct prefix after that point

[14:20:03 CDT(-0500)] <Justin_o> Bosmon: but what about the trees within the sub panels that could themselves have complex renderer trees

[14:20:23 CDT(-0500)] <Bosmon> Justin_o - I believe you are already rewriting everything?

[14:20:24 CDT(-0500)] <Justin_o> or i guess i'll never change those one

[14:20:41 CDT(-0500)] <Bosmon> So you are presumably already touching the entire protoTree from each panel

[14:20:58 CDT(-0500)] <Justin_o> yes.. just wondering if i might inherit complex trees from the subpanels

[14:21:06 CDT(-0500)] <Justin_o> Bosmon: by the way here's my fluid-5185 branch https://github.com/jobara/infusion/tree/FLUID-5185

[14:21:20 CDT(-0500)] <Bosmon> THanks, Justin_o

[14:21:27 CDT(-0500)] <Bosmon> So many things beginning with J!

[14:21:36 CDT(-0500)] <Justin_o> which has the start of the upgrades, currently qUnit, as well as getting the new jQuery UI and removing old plugins

[14:21:49 CDT(-0500)] <Justin_o> (smile)

[14:22:19 CDT(-0500)] <Justin_o> Bosmon: so you think i could just do a search for ..:: and should not encounter anything more complex than that?

[14:23:34 CDT(-0500)] <Bosmon> Justin_o - that ought to be fine

[14:23:58 CDT(-0500)] <Bosmon> Hopefully we will have a proper renderer by the time people start writing things that are much more complex : P

[14:24:00 CDT(-0500)] <Justin_o> Bosmon: okay.. i'll try to fix that up quickly then so that i can get you a pull request before i leave.. if not i'll try to send you one later tonight

[14:24:07 CDT(-0500)] <Justin_o> Bosmon: (smile)

[14:24:38 CDT(-0500)] <Justin_o> i was telling cindyli we'd hopefully be able to throw this all away soon.. with the new renderer on the horizon

[14:26:13 CDT(-0500)] <Justin_o> Bosmon: is there a name for "..::"

[14:27:04 CDT(-0500)] <Justin_o> i guess it's parentRelativeId

[14:28:45 CDT(-0500)] <Bosmon> That is what it is

[14:38:42 CDT(-0500)] <anastasiac> Yay! Bosmon's 4258 branch has been merged!

[14:39:09 CDT(-0500)] <Bosmon> DECCKLARATTIVE CHANGES are now available for all (smile)

[14:39:17 CDT(-0500)] <Bosmon> All we need to do now is document them : P

[14:48:28 CDT(-0500)] <colinclark> classic DARApplier timing, there

[14:50:58 CDT(-0500)] <colinclark> Justin_o, Bosmon: I just filed this issue http://issues.fluidproject.org/browse/FLUID-5204

[14:51:31 CDT(-0500)] <colinclark> We've got failures in both IE8 and 10

[14:51:36 CDT(-0500)] <colinclark> Some, I think, are overlapping

[14:51:39 CDT(-0500)] <colinclark> others, different

[14:53:41 CDT(-0500)] <Justin_o> Bosmon: can you look at my pull request https://github.com/fluid-project/infusion/pull/432

  • No labels