Skip to end of metadata
Go to start of metadata

You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 147 Next »

[06:17:19 CDT(-0500)] <lahabana> hey is anybody here?
[07:50:21 CDT(-0500)] <lahabana> Hey heidi_ you are here?
[07:52:04 CDT(-0500)] <heidi_> hi charly! lahabana
[07:52:32 CDT(-0500)] <lahabana> So first are u still ok to help me for GSOC docs?
[07:52:54 CDT(-0500)] <lahabana> kinda lost on what should be done (wink)
[07:53:38 CDT(-0500)] <heidi_> lahabana i'll ping anastasiac today and see if she knows details and pass them on to you. did their website have anything more?
[07:53:54 CDT(-0500)] <lahabana> not really
[07:53:59 CDT(-0500)] <heidi_> greggy1 do you have any students applying for gsoc docs ?
[07:54:18 CDT(-0500)] <lahabana> there's almost nothing said in it except the page anastasiac sent us
[07:55:12 CDT(-0500)] <lahabana> ok so heidi_ ping me aswell when you ask anastasiac (wink)
[07:55:34 CDT(-0500)] <lahabana> I also have a few other questions
[07:55:54 CDT(-0500)] <heidi_> lahabana i saw your email about video player controls, i'll get back to you on that today
[07:56:10 CDT(-0500)] <lahabana> do you know if there's a way using the $.browser to make something specific to safari (not webkit)
[07:56:19 CDT(-0500)] <lahabana> heidi_: thx (wink)
[07:56:25 CDT(-0500)] <heidi_> just have to keep in mind that the controls don't affect with the shortcuts the AT uses
[07:56:38 CDT(-0500)] <lahabana> AT?
[07:56:46 CDT(-0500)] <heidi_> lahabana assistive technologies
[07:56:51 CDT(-0500)] <lahabana> yes true
[07:56:55 CDT(-0500)] <heidi_> like a screen reader or special keyboard etc
[07:57:10 CDT(-0500)] <heidi_> re: safari only... not sure off hand. there must be
[07:57:19 CDT(-0500)] <lahabana> yes but it's weird
[07:57:26 CDT(-0500)] <heidi_> what's safari doing that needs special attention?
[07:57:28 CDT(-0500)] <lahabana> http://api.jquery.com/jQuery.browser
[07:57:41 CDT(-0500)] <lahabana> cause safari has a thing for real fullscreen
[07:57:51 CDT(-0500)] <lahabana> and no other browser has ity
[07:58:14 CDT(-0500)] <heidi_> ah, i see
[07:58:22 CDT(-0500)] <lahabana> http://developer.apple.com/library/safari/#documentation/appleapplications/reference/WebKitDOMRef/HTMLVideoElement_idl/Classes/HTMLVideoElement/index.html
[07:58:30 CDT(-0500)] <heidi_> how are you doing full screen for the other browsers?
[07:59:01 CDT(-0500)] <heidi_> lahabana this is one of my fav accessible vid players btw: http://wac.osu.edu/examples/jwpc/ have you seen it?
[07:59:07 CDT(-0500)] <lahabana> well it becames full window
[07:59:17 CDT(-0500)] <heidi_> i would follow their shortcuts i think
[07:59:25 CDT(-0500)] <heidi_> (click help icon to see)
[07:59:37 CDT(-0500)] <lahabana> ho yes I already had a look at it
[08:00:02 CDT(-0500)] <lahabana> but the problem with their shortcuts
[08:00:06 CDT(-0500)] <lahabana> is the complexity
[08:00:27 CDT(-0500)] <lahabana> alt + control + somthing is not that easy to do no?
[08:01:28 CDT(-0500)] <heidi_> lahabana it depends on the AT, but it would be better to use an unique shortcut than interfere with those of the browser/AT
[08:01:51 CDT(-0500)] <lahabana> hmm I see
[08:02:27 CDT(-0500)] <lahabana> "Jump increments determined by movie length: Jump forward and back in the movie by preset percentages (5% by default). For keyboard and screen reader users, this form of navigation is more efficient that using the scrubber alone." That's really good!
[08:02:31 CDT(-0500)] <lahabana> think I'll do the same
[08:02:38 CDT(-0500)] <lahabana> ftm it was only 1sec
[08:02:47 CDT(-0500)] <lahabana> but think that is way better!
[08:03:52 CDT(-0500)] <lahabana> also heidi_: I was wondering jquery UI is already aria compatible no?
[08:03:52 CDT(-0500)] <heidi_> lahabana cool! yeah i get the sense there's been a lot of thought put into this vid player re: a11y... all of the hidden screen reader instructions are v helpful as well
[08:04:20 CDT(-0500)] <heidi_> lahabana for some widgets, but not all - i think it's still a work in progress. any widget in particular?
[08:04:41 CDT(-0500)] <lahabana> I use the slider and the button only ftm
[08:04:51 CDT(-0500)] <lahabana> which are both amazing (smile)
[08:05:13 CDT(-0500)] <heidi_> lahabana Justin_o didn't we have to add extra stuff to the slider for a11y?
[08:05:28 CDT(-0500)] <heidi_> lahabana i think the button one is ok, doesn't need aria
[08:06:43 CDT(-0500)] <Justin_o> heidi_, lahabana: the current set of jquery ui widgets are not all fully aria compliant yet... the ones for jQuery UI 1.9 will be though, but they aren't out yet. So you should check them when you use them
[08:07:07 CDT(-0500)] <lahabana> ok thx Justin_o (smile)
[08:07:18 CDT(-0500)] <heidi_> Justin_o we added stuff to make the slider accessible right? can't remember
[08:07:27 CDT(-0500)] <Justin_o> heidi_: i think we did
[08:07:58 CDT(-0500)] <heidi_> so lahabana will be using our version of the slider i think? Justin_o is there a wrapper for it?
[08:10:58 CDT(-0500)] <Justin_o> heidi_: no, you can use it directly or as part of the textfield slider component
[08:11:41 CDT(-0500)] <lahabana> ?
[08:15:22 CDT(-0500)] <lahabana> also I've got a last question heidi_
[08:15:36 CDT(-0500)] <lahabana> it's about fluid("activatable");
[08:15:52 CDT(-0500)] <lahabana> I've got a problem on some elements it launches the function twice...
[08:17:23 CDT(-0500)] <lahabana> for eg I wanted the video tag to be activatable so that a press on the space bar would toggle the play/pause of the video
[08:17:40 CDT(-0500)] <lahabana> the only thing is that the event is thrown twice
[08:20:11 CDT(-0500)] <heidi_> Justin_o are you familiar with activatable ?
[08:20:23 CDT(-0500)] <heidi_> or anastasiac
[08:20:28 CDT(-0500)] <Justin_o> heidi_: somewhat
[08:20:57 CDT(-0500)] <heidi_> Justin_o thoughts on lahabana's problem?
[08:21:10 CDT(-0500)] <lahabana> Justin_o: so I've got keyBindings that work perfectly well
[08:21:10 CDT(-0500)] <heidi_> i wonder if it's something to do with putting it on the video tag
[08:22:01 CDT(-0500)] <lahabana> the only thing is that I want my video tag (whose got the default focus) to launch the video when space bar or enter is pressed
[08:22:38 CDT(-0500)] <lahabana> so I did : "that.locate("video").fluid("activatable",that.play);"
[08:22:53 CDT(-0500)] <lahabana> video is the selector for my video tag
[08:23:22 CDT(-0500)] <lahabana> and that.play starts or pauses the video depending on the model
[08:23:48 CDT(-0500)] <lahabana> the only issue is that everytime I press the space bar that event is triggered twice
[08:27:26 CDT(-0500)] <lahabana> no guesses?
[08:27:55 CDT(-0500)] <heidi_> lahabana i'm not sure offhand ... yura_ would you have any thoughts ?
[08:33:12 CDT(-0500)] <lahabana> heidi_: it's really weird in fact
[08:33:24 CDT(-0500)] <yura_> heidi_, lahabana, it
[08:33:50 CDT(-0500)] <yura_> s hard to say, could it be that the event is triggered by more than one element
[08:34:08 CDT(-0500)] <yura_> e.g. the bubbling is happening and not handled correctly ?
[08:34:40 CDT(-0500)] <lahabana> well the thing is that I've link all the keyboard shortcuts on the main container
[08:35:08 CDT(-0500)] <lahabana> so that wherever it is focused on the videoPlayer you can still use them
[08:35:56 CDT(-0500)] <lahabana> that works well and no main handler is linked there: that.container.fluid("activatable", [null, opts]); (opts contains the keyboards bindings)
[08:36:14 CDT(-0500)] <lahabana> so in that container there's a video tag
[08:36:25 CDT(-0500)] <lahabana> and this is what I want to make activatable
[08:36:36 CDT(-0500)] <lahabana> but when I focus on it
[08:36:43 CDT(-0500)] <lahabana> it sents the event twice
[08:37:16 CDT(-0500)] <lahabana> and it also does it when I use the keyboard shortcut to play/pause
[08:37:35 CDT(-0500)] <lahabana> however when focused somewhere else (in the controllers for eg)
[08:37:47 CDT(-0500)] <lahabana> the keyboard shortcut works well
[08:37:53 CDT(-0500)] <lahabana> same for the space bar
[08:38:08 CDT(-0500)] <lahabana> any guesses?
[08:38:53 CDT(-0500)] <lahabana> in conclusion here is the keyboard part:
[08:38:55 CDT(-0500)] <lahabana> that.container.fluid("activatable", [null, opts]);
[08:38:55 CDT(-0500)] <lahabana> //that.container.fluid("tabbable");
[08:38:56 CDT(-0500)] <lahabana> var video = that.locate("video");
[08:38:56 CDT(-0500)] <lahabana> video.fluid("tabbable");
[08:38:56 CDT(-0500)] <lahabana> video.fluid("activatable", [that.play, null]);
[08:38:56 CDT(-0500)] <lahabana> video.focus();
[08:39:30 CDT(-0500)] <lahabana> (the container doesn't need to be tabbable as it is of no controlling use)
[08:44:34 CDT(-0500)] <Justin_o> lahabana: so are you adding activatable to both the video tag and the container?
[08:44:50 CDT(-0500)] <lahabana> no just the video tag
[08:45:08 CDT(-0500)] <lahabana> at first I wanted to add to the container
[08:45:20 CDT(-0500)] <lahabana> but when u used tabs to control the buttons
[08:45:30 CDT(-0500)] <lahabana> 2 things were done at the same time
[08:45:47 CDT(-0500)] <lahabana> so thought that having it only on the video was preferable
[08:48:13 CDT(-0500)] <Justin_o> lahabana: so i'm a bit confused about the code snippet you sent then.. since it seems that you are adding it to both
[08:49:08 CDT(-0500)] <lahabana> well tell me if I'm wrong Justin_o but I've linked the keyboard bindings (opts) to the container
[08:49:37 CDT(-0500)] <lahabana> but it hasn't got default handler (that's why there's a null)
[08:50:10 CDT(-0500)] <lahabana> what I call "default handler" is the handler launched by the space bar
[08:51:49 CDT(-0500)] <lahabana> http://wiki.fluidproject.org/display/fluid/Keyboard+Accessibility+Plugin+API
[08:55:21 CDT(-0500)] <huslage> fluid-everyone Caph is not accessible this morning. looking into it with OCAD IT
[08:55:35 CDT(-0500)] <colinclark> What's on Caph, huslage?
[08:55:45 CDT(-0500)] <huslage> builder, dev.snow
[08:56:21 CDT(-0500)] <lahabana> Justin_o: well still seems like this is the error cause if I remove the key binding it works...
[09:05:54 CDT(-0500)] <Justin_o> lahabana: yah.. i'm not really sure what is..
[09:06:02 CDT(-0500)] <Justin_o> lahabana: maybe colinclark might know
[09:06:10 CDT(-0500)] <colinclark> I'm in a meeting at the moment
[09:06:15 CDT(-0500)] <colinclark> make me a pastie of your code
[09:06:19 CDT(-0500)] <colinclark> or put it into Github
[09:06:20 CDT(-0500)] <Justin_o> lahabana: meant to say, "why that is?
[09:06:23 CDT(-0500)] <colinclark> and I'll take a look as soon as I can
[09:12:29 CDT(-0500)] <lahabana> colinclark: sorry was away
[09:12:45 CDT(-0500)] <lahabana> well I managed to make it work slightly diferently
[09:13:39 CDT(-0500)] <lahabana> Justin_o: colinclark my only question is that isn't it possible not to add a default handler (space bar and enter) but only keyboard binding?
[09:14:06 CDT(-0500)] <colinclark> I'm not sure what that means
[09:18:16 CDT(-0500)] <lahabana> colinclark: just tell me when u're available I'll try to explain you in a better way
[09:30:58 CDT(-0500)] <jessm> fluid-everyone: this may be too basic for a number of you, but there is a nice HTML 5 article here: http://radar.oreilly.com/2011/07/what-is-html5.html "What is HTML5?"
[09:33:52 CDT(-0500)] <Justin_o> jessm: thanks
[10:12:39 CDT(-0500)] <colinclark> anastasiac: Do you think we should be involved in this? https://sites.google.com/site/docsprintsummit/
[10:13:09 CDT(-0500)] <colinclark> Also, Janet is organizing another online MDN Sprint next week
[10:13:10 CDT(-0500)] <anastasiac> colinclark, I'm talking to the various Fluid-related GSoC projects about the possibilities
[10:13:21 CDT(-0500)] <colinclark> Cool
[10:13:27 CDT(-0500)] <colinclark> What are you saying? And what are they saying?
[10:13:53 CDT(-0500)] <colinclark> exciting (smile)
[10:15:36 CDT(-0500)] <anastasiac> colinclark: pulkit is interested in submitting something for the Image Editor; charly is interested for the video player, though he'll be back in school at the time of the summit; care and I are discussing the possibility of a manual for the visualiser
[10:15:52 CDT(-0500)] <colinclark> neat
[10:16:17 CDT(-0500)] <colinclark> I imagine it could be broadened to cover aspects of Infusion related to their work, too
[10:16:27 CDT(-0500)] <colinclark> and some of the issues that they encountered with our documentation along the way
[10:17:05 CDT(-0500)] <anastasiac> colinclark, yes, that's a possibility. Keep in mind, though, that the applications themselves are proposals for a Quick Start manual for a GSoC project
[10:18:22 CDT(-0500)] <colinclark> Right
[10:18:34 CDT(-0500)] <colinclark> but given that we hope these projects will be part of Infusion
[10:18:44 CDT(-0500)] <colinclark> does that not speak to a broader scope?
[10:27:29 CDT(-0500)] <heidi_> anastasiac lahabana was looking for more info on what should be in the docs proposal - thoughts?
[10:27:44 CDT(-0500)] <lahabana> hey
[10:35:18 CDT(-0500)] <jessm> fluid-everyone: i'm going to miss standup
[10:35:28 CDT(-0500)] <jessm> working with Bert on CFI quote right now and working on CFI and JDs today
[10:49:48 CDT(-0500)] <jameswy> fluid-everyone: fyi, the site I was talking about at standup: http://beta.theexpressiveweb.com/
[10:50:09 CDT(-0500)] <anastasiac> colinclark, sorry about not responding - I was pulled into a conversation. Yes, the projects will be part of infusion, and certainly, any quick start guide for them would have to include an introduction to infusion.We could also submit a proposal for a separate book sprint focussed on Infusion itself, given that it is the basis for all three projects. Do you have any ideas to add?
[10:50:16 CDT(-0500)] <colinclark> no worries, anastasiac
[10:50:30 CDT(-0500)] <colinclark> I think that sounds good
[11:01:24 CDT(-0500)] <huslage> can fluid-everyone check out builder and dev.snow please
[11:01:33 CDT(-0500)] <huslage> they should be back
[11:12:51 CDT(-0500)] <lahabana> so anastasiac : what should be in the proposal for the doc camp?
[11:13:03 CDT(-0500)] <lahabana> cause I read through and couldn't find much
[11:13:26 CDT(-0500)] <anastasiac> lahabana, heidi_, regarding a doc camp proposal: I don't know anything more than you do, but I'd imagine that a proposal could include:
[11:13:40 CDT(-0500)] <anastasiac> A bit of background on the project itself
[11:13:58 CDT(-0500)] <anastasiac> a brief outline of what topics might go into a quick start guide
[11:15:17 CDT(-0500)] <lahabana> ok I see
[11:15:32 CDT(-0500)] <lahabana> should I talk of the more technical points too?
[11:16:37 CDT(-0500)] <anastasiac> lahabana, I'm not sure, but I suspect the docs proposals should be a bit less technical. The application form says "Please be detailed about why you or your org would like to participate, who will come if you participate, what you hope to get out of the sprint, and how it will help you or your org"
[11:17:35 CDT(-0500)] <lahabana> ok I see
[11:18:08 CDT(-0500)] <lahabana> well I'll right a draft today or tomorrow morning and I'll send it to you in order to have ur opinion?
[11:18:11 CDT(-0500)] <lahabana> is that ok?
[11:18:20 CDT(-0500)] <lahabana> who wants to come btw?
[11:22:58 CDT(-0500)] <lahabana> colinclark: do you know if there's a recommended protocomponent types for radio buttons?
[11:23:15 CDT(-0500)] <lahabana> that makes it easier to auto bind everything
[11:23:15 CDT(-0500)] <lahabana> ?
[11:23:24 CDT(-0500)] <anastasiac> lahabana, draft by tomorrow is fine. I'd be happy to join you and help with the docs writing. heidi_, unfortunately, will not be able to travel by that time (smile)
[11:23:39 CDT(-0500)] <lahabana> anastasiac: yes I've seen that
[11:23:55 CDT(-0500)] <heidi_> (smile)
[11:24:23 CDT(-0500)] <anastasiac> and lahabana, for radio buttons, I believe the 'selection' protocomponent is the right one
[11:24:24 CDT(-0500)] <lahabana> fluid-everyone: if anybody else wants to join gsoc doc camp please make a sign before tomorrow eve
[11:24:57 CDT(-0500)] <lahabana> ok also another question how do I make the renderer repeat a thing
[11:25:06 CDT(-0500)] <lahabana> I mean, I'm doing a menu atm
[11:25:17 CDT(-0500)] <lahabana> so the number of elements is variable
[11:25:49 CDT(-0500)] <lahabana> I want to make radio buttons for each track of caption for eg
[11:26:04 CDT(-0500)] <lahabana> and I can't find in the doc how to do that...
[11:28:56 CDT(-0500)] <anastasiac> lahabana, you'd want to use the "repeat" expander... let me find the link
[11:29:07 CDT(-0500)] <anastasiac> http://wiki.fluidproject.org/display/docs/Renderer+Component+Tree+Expanders
[11:29:15 CDT(-0500)] <lahabana> ho ok
[11:29:59 CDT(-0500)] <lahabana> ok
[11:31:19 CDT(-0500)] <lahabana> anastasiac: so the id in my html needs to end by ":"?
[11:34:43 CDT(-0500)] <colinclark> The nightly Builder instance appears to be broken: http://build.fluidproject.org/infusionBuilder/html/InfusionBuilder.html
[11:34:59 CDT(-0500)] <colinclark> The stable 1.3.1 version is fine
[11:35:47 CDT(-0500)] <anastasiac> lahabana, I believe that ids for repeated elements do still need to end with a colon (":"), yes
[11:50:37 CDT(-0500)] <harriswong> michelled: added some more testcases to #122, https://github.com/fluid-project/infusion/pull/122. Please let me know if there is any problem.
[12:34:40 CDT(-0500)] <Justin_o> fluid-everyone: I've been trying to tackle some more UIO issues. Basically in regards to the sliders not showing up correctly when the contrast themes are applied. So it seems that this is because or our generated style sheets. What's happening is that our generated style sheets are scoped to a different class than the themes generally are. Example .fl-theme-uio-yellowBlack as opposed to .fl-theme-yellowBlack
[12:35:21 CDT(-0500)] <Justin_o> the jQuery ui style sheets that we use are all only scoped to the original class name, so they do not get applied with the contrast themes any more.
[12:35:21 CDT(-0500)] <Justin_o> '
[12:36:23 CDT(-0500)] <Justin_o> we could try a few things to fix this 1) include the themes jQuery UI themes twice 2) do some build process to copy and modify the jQuery UI themes
[12:36:31 CDT(-0500)] <Justin_o> does anyone else have any thoughts on this
[12:36:47 CDT(-0500)] <Justin_o> colinclark, heidi_, Bosmon, fluid-everyone ^
[12:40:57 CDT(-0500)] <michelled> Justin_o: are there benefits to each option?
[12:42:18 CDT(-0500)] <heidi_> Justin_o why are the generated ones using a different scoping?
[12:42:42 CDT(-0500)] <Justin_o> heidi_: that's so that they won't override someones theme just by being on the same page
[12:46:55 CDT(-0500)] <heidi_> Justin_o thinking...
[12:48:28 CDT(-0500)] <heidi_> Justin_o don't we want UIO styles to over-ride everything?
[12:48:43 CDT(-0500)] <Justin_o> heidi_: i should clarify..
[12:48:57 CDT(-0500)] <Justin_o> so if they were to use one of the themes as the default theme
[12:49:38 CDT(-0500)] <Justin_o> heidi_: although in thinking about this more I'm not sure I'm convinced of the need.. can you think of a reason why the uio generated themes and the regular uio themes should not have the same scoping
[12:59:48 CDT(-0500)] <michelled> I guess there are a few reasons that we had.
[13:00:31 CDT(-0500)] <michelled> we wanted to be clear that these themes are different then the FSS ones - they use important everywhere and we wanted to remove important from the fss themes so that they plan nicely with integrator's styling
[13:00:33 CDT(-0500)] <heidi_> Justin_o yes if you're using yellowBlack as a base, then over-riding parts of it with custom styles, you'd want that. you wouldn't want the UIO theme to not be over-ridable
[13:03:52 CDT(-0500)] <michelled> there is also the issue Justin_o was alluding to which might be theoretical - using an FSS theme as a default and having the user select the UIO version of the theme
[13:05:35 CDT(-0500)] <azeckoski> hi again folks
[13:05:50 CDT(-0500)] <michelled> of course right now we require integrators to include all the UIO CSS files in the page so if we didn't have two different theme names then the integrator would not be able to use an FSS theme as their base without imporant
[13:05:58 CDT(-0500)] <michelled> azeckoski: hello! welcome back (smile)
[13:06:42 CDT(-0500)] <azeckoski> just dropping in to see if anyone had any ideas about the pager issue I mentioned yesrerday
[13:06:48 CDT(-0500)] <azeckoski> yesterday that is
[13:07:16 CDT(-0500)] <azeckoski> 4 of us at unicon have looked at it and the concensus is that it is a bug in fluid maybe
[13:07:25 CDT(-0500)] <michelled> azeckoski: yesterday was a holiday for a bunch of us - I'll need to check the logs
[13:07:39 CDT(-0500)] <azeckoski> http://wiki.fluidproject.org/display/fluid/fluid-work+IRC+Logs-2011-08-01
[13:08:22 CDT(-0500)] <colinclark> AZ!
[13:09:08 CDT(-0500)] <azeckoski> CC!
[13:09:39 CDT(-0500)] <azeckoski> oh I like that, it is your new nickname
[13:09:45 CDT(-0500)] <azeckoski> for today
[13:09:47 CDT(-0500)] <azeckoski> (smile)
[13:11:21 CDT(-0500)] <azeckoski> so, right now we are trying to convert things to not use the rsf:id
[13:12:06 CDT(-0500)] <colinclark> I suspect Justin_o or Bosmon are the likely best candidates to be familiar with it
[13:15:33 CDT(-0500)] <azeckoski> we do have a simple demo working again
[13:15:50 CDT(-0500)] <azeckoski> just can't seem to get from simple demo to making our complex stuff work
[13:26:17 CDT(-0500)] <azeckoski> let me know if there is any information I can provide
[13:26:41 CDT(-0500)] <colinclark> azeckoski: It's a quiet day today, but we'll definitely take a look and see what we can come up with for you
[13:26:45 CDT(-0500)] <colinclark> sorry for the inconvenience
[13:26:52 CDT(-0500)] <colinclark> bugs suck
[13:26:57 CDT(-0500)] <azeckoski> this is actually fairly urgent for us so if there is anything I can do to make it easier for someone to take a look then let me know
[13:27:12 CDT(-0500)] <azeckoski> indeed
[13:28:42 CDT(-0500)] <heidi_> hi azeckoski !
[13:29:01 CDT(-0500)] <azeckoski> sweet! More canadians!
[13:29:03 CDT(-0500)] <azeckoski> (smile)
[13:29:07 CDT(-0500)] <heidi_> (smile)
[14:16:46 CDT(-0500)] <Justin_o> heidi_, colinclark, michelled: i'm wondering if the cost of trying to support jQuery UI Themes with another scoping class is worth it for the case where the same contrast theme is used as the default and a choice
[14:17:38 CDT(-0500)] <heidi_> Justin_o i wonder if the uio version can have the slider styles within it? or is that bad...
[14:17:53 CDT(-0500)] <heidi_> were there other widgets or just it?
[14:17:55 CDT(-0500)] <Justin_o> heidi_: you mean not use a jquery ui theme?
[14:18:07 CDT(-0500)] <Justin_o> heidi_: but what about any other jquery ui widget that might be used on the page
[14:18:09 CDT(-0500)] <heidi_> i guess that is bad n/m
[14:18:10 CDT(-0500)] <colinclark> azeckoski: Bosmon just pinged me and said he'd take a look at your issue
[14:18:18 CDT(-0500)] <azeckoski> sweet
[14:19:17 CDT(-0500)] <heidi_> Justin_o i think over-riding someone's custom theme (that happens to use an fss theme as a base) wouldn't be good
[14:19:27 CDT(-0500)] <heidi_> unless they've chosen that theme from UIO
[14:19:38 CDT(-0500)] <Bosmon> azeckoski - I am looking into your issue now
[14:19:47 CDT(-0500)] <azeckoski> double sweet
[14:19:48 CDT(-0500)] <Bosmon> Is there an HTML file I can load up that will demonstrate the problem directly?
[14:20:18 CDT(-0500)] <Bosmon> If not, a live URL on the web will do
[14:20:23 CDT(-0500)] <Justin_o> heidi_: you mean a user shouldn't for example use the hci theme as both the basis for their default and as an option in UIO
[14:20:26 CDT(-0500)] <azeckoski> let me get the live url
[14:21:25 CDT(-0500)] <heidi_> Justin_o no the opposite - i think they should be able to
[14:21:49 CDT(-0500)] <heidi_> where the default one is over-ridable but when chosen as a UIO theme it's not
[14:22:05 CDT(-0500)] <heidi_> so like what you're going for now
[14:22:34 CDT(-0500)] <azeckoski> http://kaltura.unicon.net:8080/portal/site/3674fc9f-8d5c-4ede-86f0-2f7432edb0db/page/d675d698-3f77-4173-b183-65619402f9a8
[14:22:39 CDT(-0500)] <azeckoski> login fluid / fluid
[14:22:48 CDT(-0500)] <azeckoski> click on "Site Library" tab
[14:22:49 CDT(-0500)] <heidi_> and again the issue is that if the UIO theme is chosen, jquery ui widgets aren't being affected because of the scoping
[14:23:06 CDT(-0500)] <azeckoski> and you will see the alert (there is try catch around the failure point right now)
[14:23:29 CDT(-0500)] <Justin_o> heidi_: so the only difference between the original and generated fss theme is the use of !importants in the generated one
[14:24:22 CDT(-0500)] <Bosmon> Ok, I get alert "pager failed to init, columnDef is undefined"
[14:24:28 CDT(-0500)] <Bosmon> Is this what I should see?
[14:24:36 CDT(-0500)] <azeckoski> yep
[14:24:42 CDT(-0500)] <colinclark> I see a video of AZ
[14:24:49 CDT(-0500)] <colinclark> looking typically stylish
[14:24:50 CDT(-0500)] <azeckoski> well, ideally no you should not see that failure
[14:24:58 CDT(-0500)] <azeckoski> but that is what we are seeing
[14:25:03 CDT(-0500)] <azeckoski> (smile)
[14:25:21 CDT(-0500)] <azeckoski> yes.... stylish
[14:25:24 CDT(-0500)] <azeckoski> (wink)
[14:25:43 CDT(-0500)] <heidi_> Justin_o right. so the jquery ui widgets aren't being affected by the UIO theme, right? when a theme is added to the page, is it using fl-theme-ui-yellowBlack AND fl-theme-yellowBlack? would using both solve this?
[14:29:33 CDT(-0500)] <Justin_o> heidi_: so the jquery ui theme at the moment is only scoped to fl-theme-ui-yellowBlack
[14:29:48 CDT(-0500)] <Justin_o> so we could do something to scope it to both, but not sure it is worth the trouble
[14:30:34 CDT(-0500)] <Bosmon> Hi azeckoski - this looks like a bug we introduced in 1.3.1
[14:30:38 CDT(-0500)] <Bosmon> I think we even have a patch for it
[14:30:48 CDT(-0500)] <azeckoski> hm
[14:30:59 CDT(-0500)] <heidi_> Justin_o you mean it's only scoped to fl-theme-yellowBlack right
[14:31:01 CDT(-0500)] <azeckoski> I should say we tried 1.3 and we get the same failure
[14:31:10 CDT(-0500)] <azeckoski> or at least, a similar failure
[14:31:13 CDT(-0500)] <Bosmon> But for a quick fix, just pass the option annotateColumnRange: null into your pager options
[14:31:23 CDT(-0500)] <Bosmon> It may have been similar, but not the same (tongue)
[14:31:28 CDT(-0500)] <azeckoski> ok, trying it now
[14:31:56 CDT(-0500)] <Bosmon> The default for 1.3.1 unfortunately became to apply annotation to a standard column name "column1" to illustrate the defaults
[14:32:05 CDT(-0500)] <Bosmon> Unfortunately the effect of this is to cause a failure unless you override the defaults
[14:32:08 CDT(-0500)] <Bosmon> Let me find our JIRA number for tis
[14:32:46 CDT(-0500)] <Justin_o> heidi_: yes.. currently that's the issue with the jquery ui theme
[14:32:49 CDT(-0500)] <Bosmon> http://issues.fluidproject.org/browse/FLUID-4213
[14:32:53 CDT(-0500)] <Bosmon> Ah, actually this is a lightly different issue
[14:33:14 CDT(-0500)] <heidi_> Justin_o your prev msg said "so the jquery ui theme at the moment is only scoped to fl-theme-ui-yellowBlack" so just checking
[14:33:44 CDT(-0500)] <Bosmon> No, this is the same issue
[14:33:51 CDT(-0500)] <Justin_o> heidi_: oh.. oops
[14:33:56 CDT(-0500)] <Bosmon> This issue should only have affected 1.3.1
[14:34:24 CDT(-0500)] <heidi_> Justin_o i think the options would be to add another version of the jquery ui theme that is scoped to ui, or add both class names to the body
[14:34:40 CDT(-0500)] <heidi_> the latter seems less work maybe ?
[14:35:17 CDT(-0500)] <azeckoski> Bosmon: definitely a change
[14:35:19 CDT(-0500)] <azeckoski> pager failed to init: Object 1 has no method 'replace'
[14:36:17 CDT(-0500)] <Bosmon> hah
[14:36:49 CDT(-0500)] <Bosmon> So, this probably explains why the stuff fails on 1.3 as well... there are clearly 2 bugs rather than 1
[14:36:57 CDT(-0500)] <Bosmon> Can you update the live site with that change? (tongue)
[14:37:06 CDT(-0500)] <azeckoski> yep
[14:37:10 CDT(-0500)] <Bosmon> tanx
[14:40:28 CDT(-0500)] <Justin_o> heidi_: okay.. so for adding another version we have a couple of options.. we could either statically generate one with themeroller with the correct scoping, or we could do a build time process. we'd still have work to do to re-write urls if they don't live in the same location (to prevent duplication of the images). If we do the static generation then we'd have to ship two copies. If we did the build time, we'd have to do more work to build the gener
[14:40:50 CDT(-0500)] <Justin_o> the putting both class names seems intersesting.. not sure what the side effects would be though..
[14:41:31 CDT(-0500)] <Justin_o> i suppose it could be dangerous depending on how much someone modifies a file and we'd have to then worry about specificity too then.. i guess
[14:41:34 CDT(-0500)] <Justin_o> heidi_: any thoughts
[14:41:55 CDT(-0500)] <heidi_> Justin_o the theme-ui- would over-ride the theme- one, so i think it'd be fine
[14:42:21 CDT(-0500)] <Justin_o> heidi_: could we guarantee that 100% of the time though.. if someone modified the file
[14:42:36 CDT(-0500)] <Justin_o> meaning if someone extended it
[14:42:41 CDT(-0500)] <heidi_> Justin_o modified which file?
[14:42:52 CDT(-0500)] <Justin_o> the base contrast theme file
[14:43:09 CDT(-0500)] <Justin_o> i expect that's the only situation we are really worried about
[14:43:15 CDT(-0500)] <heidi_> Justin_o it would be over-ridden by the ui-theme
[14:43:37 CDT(-0500)] <heidi_> unless it's using importants, but you can't guarantee anything in that case
[14:43:44 CDT(-0500)] <Justin_o> heidi_: true (smile)
[14:43:59 CDT(-0500)] <Justin_o> colinclark: we're putting !important on all colors?
[14:44:37 CDT(-0500)] <colinclark> https://github.com/fluid-project/infusion/blob/master/build-scripts/uiOptions/js/StylesheetImportant.js#L29-45
[14:44:47 CDT(-0500)] <azeckoski> Bosmon: ok, updates
[14:44:49 CDT(-0500)] <azeckoski> updated
[14:44:50 CDT(-0500)] <colinclark> borders and backgrounds, Justin_o
[14:44:51 CDT(-0500)] <azeckoski> that is
[14:44:56 CDT(-0500)] <azeckoski> tense is not important
[14:46:43 CDT(-0500)] <Justin_o> colinclark: thanks
[14:46:44 CDT(-0500)] <Justin_o> {color}
[14:47:17 CDT(-0500)] <Justin_o> heidi_: okay, next question, how often do you think this would happen?

[14:47:40 CDT(-0500)] <Justin_o> meaning how often would someone use one of the contrast themes as the bases for their default theme.. in your opinion
[14:48:28 CDT(-0500)] <heidi_> Justin_o not often (smile)
[14:48:41 CDT(-0500)] <Justin_o> heidi_: (smile) that's what i figured too...
[14:48:50 CDT(-0500)] <Justin_o> that's why i'm wondering if it's worth supporting that at the moment
[14:49:05 CDT(-0500)] <heidi_> Justin_o tho often enough that the uportal folks requested removing theme's importants
[14:49:14 CDT(-0500)] <heidi_> so that they could over-ride parts of it
[14:49:18 CDT(-0500)] <heidi_> so maybe more often than we think
[14:49:44 CDT(-0500)] <Justin_o> heidi_: yes.. but we don't use the mist, coal, slate, and etc themes in UIO anymore
[14:49:56 CDT(-0500)] <heidi_> Justin_o i imagine we will for 1.5
[14:50:00 CDT(-0500)] <Justin_o> heidi_: really
[14:50:06 CDT(-0500)] <heidi_> since medium/low contrast will still be important
[14:50:18 CDT(-0500)] <heidi_> i think jameswy had +1'd that
[14:50:22 CDT(-0500)] <Justin_o> it's too bad jameswy is in another meeting
[14:50:29 CDT(-0500)] <Justin_o> oh okay.. you talked already
[14:50:39 CDT(-0500)] <heidi_> we talked about adding those themes to UIO awhile ago
[14:50:44 CDT(-0500)] <Bosmon> azeckoski - i still get the same failure
[14:50:45 CDT(-0500)] <heidi_> we might as well, right? they're still useful
[14:51:10 CDT(-0500)] <Justin_o> heidi_: okay.. well if those themes or something relatively like them are introduced then the use case seems more likely
[14:51:18 CDT(-0500)] <colinclark> (smile)
[14:51:19 CDT(-0500)] <Bosmon> azeckoski - sorry, I forgot to shift-reload in the iframe
[14:51:22 CDT(-0500)] <Bosmon> Gotta love iframes (smile)
[14:51:26 CDT(-0500)] <azeckoski> ha
[14:51:27 CDT(-0500)] <colinclark> USER ERROR, Bosmon
[14:51:38 CDT(-0500)] <Justin_o> heidi_: at the moment we don't have a good way to not make our users load a bunch of css that they'll likely only use one of
[14:53:20 CDT(-0500)] <Justin_o> colinclark: i guess i can read that two ways, by that time we'll have figured it out, or we won't add more till we do
[14:53:29 CDT(-0500)] <colinclark> lol
[14:53:38 CDT(-0500)] <colinclark> I was hoping it would read towards the former
[14:53:43 CDT(-0500)] <Bosmon> azeckoski - in this case the problem is the "attrs" decorator on line 200 of KalturaMediaSelector.js
[14:53:51 CDT(-0500)] <Justin_o> colinclark: okay, just checking :0
[14:53:53 CDT(-0500)] <Justin_o> (smile)
[14:53:56 CDT(-0500)] <Bosmon> The value of media.id is a number rather than a string, so it fails to pass XMLEncoding
[14:54:00 CDT(-0500)] <azeckoski> Bosmon: stupid attrs
[14:54:10 CDT(-0500)] <Bosmon> I'll add a note for us to fix this up automatically in the next framework version
[14:54:18 CDT(-0500)] <Bosmon> But right now you can just convert it to a String yourself
[14:54:24 CDT(-0500)] <azeckoski> so I need to force it to be a string
[14:55:34 CDT(-0500)] <Bosmon> either media.id.toString() or String(media.id)
[14:55:42 CDT(-0500)] <Justin_o> heidi_, colinclark, michelled: Okay... so anyone have a preferred method for solving the issue
[14:55:58 CDT(-0500)] <colinclark> Can someone very briefly summarize our most promising options?
[14:56:40 CDT(-0500)]

<azeckoski>

Unknown macro: { attrs}

,


[14:56:46 CDT(-0500)] <azeckoski> Bosmon: so like that?
[14:56:55 CDT(-0500)] <azeckoski> and I need to do that for all attributes which are not strings?
[14:57:01 CDT(-0500)] <Bosmon> azeckoski - that's right
[14:57:33 CDT(-0500)] <azeckoski> conveniently all the others are stringhs
[14:57:35 CDT(-0500)] <azeckoski> (smile)
[14:57:41 CDT(-0500)] <Bosmon> good oh (tongue)
[14:57:52 CDT(-0500)] <Justin_o> colinclark, michelled, heidi_: 1) provide two versions of the jquery ui themes generated through themeroller 2) use a build time process to generate the jquery ui themes with the correct scoping 3) in uio attach both class names to the body
[14:58:05 CDT(-0500)] <Justin_o> i think that's them generally
[14:58:57 CDT(-0500)] <colinclark> ah, I had forgotten the option of #3
[14:59:00 CDT(-0500)] <colinclark> interesting
[14:59:05 CDT(-0500)] <colinclark> let me finish my current meeting
[14:59:06 CDT(-0500)] <colinclark> a
[14:59:08 CDT(-0500)] <colinclark> nd then i'll vote
[14:59:32 CDT(-0500)] <Justin_o> colinclark: i have to go at 4, but i'm happy to go with whatever you all decide
[14:59:35 CDT(-0500)] <heidi_> i think i vote #3 for easiness
[14:59:37 CDT(-0500)] <colinclark> ok
[14:59:45 CDT(-0500)] <Bosmon> colinclark votes 259-190 in favour of the Style Deficit Reduction!
[14:59:57 CDT(-0500)] <Justin_o> as long as we don't have duplicate copies of the images
[15:06:51 CDT(-0500)] <michelled> I think I like 3 best also - it feels more maintainable then another build time process or more themeroller generated themes
[15:10:01 CDT(-0500)] <azeckoski> Bosmon: that looks like it fixed it
[15:10:16 CDT(-0500)] <azeckoski> you may want to update some docs or something to save other poor souls like me
[15:10:17 CDT(-0500)] <azeckoski> (smile)
[15:19:22 CDT(-0500)] <Bosmon> We'll do better than that - we'll fix the underlying issue (tongue)
[15:24:44 CDT(-0500)] <Bosmon> Hey cindyli - I wanted to check on on MUNGING
[15:24:49 CDT(-0500)] <Bosmon> How are things going?
[15:25:03 CDT(-0500)] <cindyli> Bosmon: going well overall
[15:25:23 CDT(-0500)] <Bosmon> Did you manage to unify "OtherWorld" with "inline" in the way we were hoping?
[15:25:32 CDT(-0500)] <cindyli> yes, i did
[15:25:42 CDT(-0500)] <Bosmon> That's excellent
[15:25:48 CDT(-0500)] <Bosmon> So, the result should be just details (tongue)
[15:25:52 CDT(-0500)] <cindyli> and removed all the demands blocks from 3 views
[15:25:56 CDT(-0500)] <Bosmon> Super
[15:25:58 CDT(-0500)] <cindyli> exactly
[15:26:06 CDT(-0500)] <Bosmon> So, does "mapOptions" now support literal RHS values as we were planning?
[15:26:13 CDT(-0500)] <cindyli> yes
[15:26:23 CDT(-0500)] <Bosmon> Winning all round (tongue)
[15:26:25 CDT(-0500)] <cindyli> both strings and objects
[15:26:35 CDT(-0500)] <Bosmon> A clean sweep
[15:27:03 CDT(-0500)] <cindyli> i am implementing the suggestions that anastasia mentioned last friday
[15:27:54 CDT(-0500)] <cindyli> having a problem with configuring defaultSiteSettings as a top level option in fat panel
[15:28:02 CDT(-0500)] <Bosmon> Aha
[15:28:05 CDT(-0500)] <Bosmon> What kind of problem is it
[15:28:40 CDT(-0500)] <cindyli> the main page and iframe page are enhanced properly according to the given defaults
[15:29:02 CDT(-0500)] <cindyli> but the default values on the ui options settings field are still the defaulted defaults from the script
[15:29:13 CDT(-0500)] <Bosmon> Hmm
[15:29:24 CDT(-0500)] <Bosmon> even though you "sent down" a properly munged set of user values into the correct position?
[15:29:36 CDT(-0500)] <cindyli> i traced in and found that the uiEnhancer that's used by the uiOptonsLoader is somehow still with the defaulted default
[15:30:28 CDT(-0500)] <cindyli> it seems this uiEnhancer is not the one from any of the pageEnhancer
[15:30:33 CDT(-0500)] <Bosmon> That's interesting
[15:30:44 CDT(-0500)] <Bosmon> It isn't being overridden by a demand block?
[15:30:52 CDT(-0500)] <cindyli> no
[15:30:55 CDT(-0500)] <Bosmon> Very odd
[15:30:59 CDT(-0500)] <cindyli> i've got rid of all the demands
[15:31:03 CDT(-0500)] <Bosmon> Do you want to check something in, and tell me to look at something?
[15:31:16 CDT(-0500)] <cindyli> i will check further tomorrow
[15:31:22 CDT(-0500)] <cindyli> just to let u know
[15:33:01 CDT(-0500)] <Bosmon> Ok - so long as you think it is more likely it is a munging failure rather than a framework issue
[15:34:38 CDT(-0500)] <cindyli> Bosmon: honestly, i don't know yet. the way we inject uiEnhancer into uiOptions is to use "{}" and leave it to framework to find the right uiEnhancer
[15:35:25 CDT(-0500)] <cindyli> as fat panel has 2 uiEnhancers by default, i'm not sure if certain confusion somehow happens
[15:36:28 CDT(-0500)] <cindyli> or a third uiEnhancer is created by a sub-component with type "fluid.uiEnhancer" with the script defaults somewhere.
[15:37:23 CDT(-0500)] <cindyli> have to look further

  • No labels