Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: Migrated to Confluence 4.0

[09:55:08 CDT(-0500)] <anastasiac> cindyli, alexn1, can we meet in the collab room for a check-in meeting?

[09:55:20 CDT(-0500)] <cindyli> sure, anastasiac

[10:08:33 CDT(-0500)] <logiclord> yura1: is there any standard header that I need to place in code ?

[10:08:47 CDT(-0500)] <yura1> logiclord: you mean like a license ?

[10:09:04 CDT(-0500)] <logiclord> yura1: yes or my email id etc

[10:12:09 CDT(-0500)] <yura> logiclord: i think this should do http://pastie.org/4556840

[10:12:25 CDT(-0500)] <yura> woops, just remove OCAD from second line

[10:12:27 CDT(-0500)] <yura> just your name

[10:13:01 CDT(-0500)] <logiclord> yura: in all files or just js files.. since component itself is divided into 6 files

[10:13:21 CDT(-0500)] <yura> logiclord: just js yes

[10:13:32 CDT(-0500)] <logiclord> yura: okay

[10:37:52 CDT(-0500)] <logiclord> yura: done (smile)

[10:38:35 CDT(-0500)] <yura> logiclord: congrats (smile)

[10:38:56 CDT(-0500)] <logiclord> yura: so i passed ??

[10:39:09 CDT(-0500)] <yura> logiclord: you definitely will (smile)

[10:39:27 CDT(-0500)] <logiclord> yura: Thanks (big grin)

[10:39:55 CDT(-0500)] <yura> logiclord: thanks for the work you've put in as well

[10:40:27 CDT(-0500)] <logiclord> yura: I just loved working on this one

[10:44:36 CDT(-0500)] <yura> logiclord: ya i think you did a really good job, so you are always welcome to apply again next year

[10:46:20 CDT(-0500)] <logiclord> yura: I will not be eligible for next year because I have just completed my undergrad studies and accepted an offer... may be in post graduation (wink)

[10:46:47 CDT(-0500)] <yura> logiclord: oh right

[11:11:18 CDT(-0500)] <anastasiac> alexn1, cindyli, michelled: I've updated the iteration wiki page. if I've missed anything, feel free to update

[11:13:10 CDT(-0500)] <cindyli1> thanks, anastasiac. i also added a new jira 4775 onto the wiki page for video player ie8 support

[11:13:42 CDT(-0500)] <anastasiac> ah, I added that (smile) I'll remove the duplicate

[12:01:02 CDT(-0500)] <thealphanerd> anyone have much experience with voiceover

[12:01:02 CDT(-0500)] <thealphanerd> ?

[12:02:03 CDT(-0500)] <Justin_o> thealphanerd: a bit, what's up?

[12:02:27 CDT(-0500)] <thealphanerd> so I have an application landmark

[12:02:32 CDT(-0500)] <thealphanerd> aria-labelledby works

[12:02:34 CDT(-0500)] <thealphanerd> and it is labelle

[12:02:43 CDT(-0500)] <thealphanerd> but I don't know how to hear the description

[12:02:46 CDT(-0500)] <thealphanerd> to see if my code is working

[12:12:21 CDT(-0500)] <kasper> morning Bosmon

[12:15:43 CDT(-0500)] <yura> hey kasper

[12:15:52 CDT(-0500)] <kasper> morning yura

[12:16:03 CDT(-0500)] <kasper> I was looking at testing

[12:16:10 CDT(-0500)] <Justin_o> thealphanerd: not entirely sure i follow.. i assume you just need to listen to the page

[12:16:13 CDT(-0500)] <kasper> using bosmons node-jqunit

[12:16:20 CDT(-0500)] <yura> oh (sad)

[12:16:30 CDT(-0500)] <yura> have you found it broken slightly

[12:16:31 CDT(-0500)] <yura> ?

[12:16:39 CDT(-0500)] <kasper> and was wondering if there is any way to force an ordering of the tests

[12:16:43 CDT(-0500)] <yura> haha

[12:16:44 CDT(-0500)] <yura> yes

[12:16:55 CDT(-0500)] <yura> i think he removed some code from the version we have now in universal

[12:16:59 CDT(-0500)] <yura> and i committed it in

[12:17:15 CDT(-0500)] <yura> only he knows which version we should be using

[12:17:27 CDT(-0500)] <yura> but i think it right now works if you put your async tests first (smile)

[12:17:33 CDT(-0500)] <kasper> yura: yeah... but actually it seems to be working better now than it did before.. it seems you can now mix synced and asynced funtions

[12:17:42 CDT(-0500)] <kasper> that I'm doing

[12:17:47 CDT(-0500)] <yura> me too (smile)

[12:17:50 CDT(-0500)] <kasper> but it's actually the synced tests causing problems

[12:18:20 CDT(-0500)] <kasper> so I have 2 synced tests, calling them A and B where A is defined first in the code

[12:18:35 CDT(-0500)] <kasper> ... still the damn framework insists on firing off test B first

[12:19:06 CDT(-0500)] <yura> ya Bosmon would know which jqunit we should ues

[12:19:11 CDT(-0500)] <yura> i think

[12:19:25 CDT(-0500)] <kasper> ok, will ping him later or tomorrow (getting late here)

[12:19:29 CDT(-0500)] <kasper> thanks

[12:48:40 CDT(-0500)] <michelled> cindyli1: was there a reason you needed to add another video to the repo in order to write integration tests? http://issues.fluidproject.org/browse/FLUID-4645

[12:50:16 CDT(-0500)] <cindyli1> michelled: the only reason is to separate the demo video and the test video so the integration tests don't rely on the demo path. for instance, if the demo video is moved to another path, we don't need to adjust the integration tests

[12:51:00 CDT(-0500)] <michelled> cindyli1: I'm thinking for integration tests we might actually prefer to have the dependence.

[12:51:12 CDT(-0500)] <cindyli1> why?

[12:51:50 CDT(-0500)] <michelled> so we know that we are testing a real use case and so we don't clutter the repo with unnecessary videos

[12:53:03 CDT(-0500)] <cindyli1> i agree with the 2nd: don't clutter the repo with unnecessary videos, but don't quite buy the 1st.

[12:53:23 CDT(-0500)] <cindyli1> anyway, i could change that, michelled

[12:53:36 CDT(-0500)] <michelled> cindyli1: tell me more about why you don't buy the first

[12:53:52 CDT(-0500)] <cindyli1> the test video is also a real case

[12:57:18 CDT(-0500)] <michelled> I guess you're right cindyli1. but let's remove it anyway please

[12:57:33 CDT(-0500)] <cindyli1> will do it, michelled

[13:05:40 CDT(-0500)] <asteig> Hey Justin_o.

[13:06:12 CDT(-0500)] <Justin_o> asteig: hello, how are things

[13:07:13 CDT(-0500)] <asteig> Justin_o: Good, had a question about the JSON export though. Would that just be text that's exported to the screen that contains the JSON object or what?

[13:09:30 CDT(-0500)] <Justin_o> asteig: sure.. i guess it would be nice to have a file, but i'm not sure that it's possible to do without a server side

[13:11:40 CDT(-0500)] <michelled> cindyli1: what browsers did you test FLUID-4664 in? It seems to me that even with your pull request the fat panel frame is getting keyboard focus while closed

[13:11:42 CDT(-0500)] <Justin_o> asteig: for this it should be fine to just provide it on screen. as long as when they copy and paste that it would be usable..

[13:11:46 CDT(-0500)] <michelled> at least in FF and Chrome cindyli1

[13:12:47 CDT(-0500)] <cindyli1> as i rmb, i tested with those browsers. i will double check, michelled

[13:12:56 CDT(-0500)] <michelled> thx

[13:16:30 CDT(-0500)] <Justin_o> asteig: looks like i got dropped from IRC, did you get my replies?

[13:16:46 CDT(-0500)] <asteig> Justin_o: Yep, working on them now.

[13:17:14 CDT(-0500)] <Justin_o> asteig: great

[13:26:44 CDT(-0500)] <cindyli1> michelled: my 4645 branch, integration tests, is ready to be further reviewed

[13:27:36 CDT(-0500)] <michelled> thx cindyli1

[13:27:41 CDT(-0500)] <cindyli1> np

[13:37:58 CDT(-0500)] <cindyli1> michelled: regarding 4664, the fat panel frame focus issue, seems the pull request fixes ff and ie9, still an issue with chrome and safari

[13:38:41 CDT(-0500)] <cindyli1> we can still merge in this pull request since it contains the latest infusion, and fire another jira for chrome and safari. what do you think, michelled?

[13:39:31 CDT(-0500)] <cindyli1> no, don't need another jira, a comment on 4664 should be enough

[13:39:36 CDT(-0500)] <michelled> cindyli1: yeah, I can merge the pull request if you want to update the JIRA

[13:39:51 CDT(-0500)] <cindyli1> ok. thanks, michelled

[13:40:24 CDT(-0500)] <michelled> cindyli1: I was just looking at FLUID-4652 - it looks like escape doesn't close the volume slider

[13:40:36 CDT(-0500)] <michelled> I wonder if it should - maybe jameswy has an opinion

[13:49:41 CDT(-0500)] <michelled> alexn1: if you need a break from dealing with screen reader issues, here's another thing you can look at: http://issues.fluidproject.org/browse/FLUID-4664

[13:52:32 CDT(-0500)] <anastasiac> cindyli1, michelled: the volume controls interactions have been considered already, and are ok: http://issues.fluidproject.org/browse/FLUID-4746

[13:52:41 CDT(-0500)] <michelled> thx anastasiac

[13:58:10 CDT(-0500)] <alexn1> michelled: thx I will look into it

[13:58:34 CDT(-0500)] <asteig> Justin_o: Super close, but I can't figure out the easiest way to convert the data object to text to display in a text area....

[13:58:53 CDT(-0500)] <Justin_o> asteig: you should be able to use JSON.stringify

[13:59:05 CDT(-0500)] <Justin_o> JSON.stringify(jsonObj)

[14:00:41 CDT(-0500)] <asteig> Justin_o: Good call! Pushed with changes.

[14:07:48 CDT(-0500)] <asteig> Justin_o: Hopefully I didn't break anything with the last couple of pushes. I think it's the official end of GSoC. :-p

[14:16:50 CDT(-0500)] <thealphanerd> !!!!

[14:16:54 CDT(-0500)] <thealphanerd> GSOC complete (big grin)

[14:30:49 CDT(-0500)] <Justin_o> asteig: great, thanks.. i'll check it out

[14:31:01 CDT(-0500)] <Justin_o> asteig, thealphanerd : congrats on completing GSoC

[14:33:09 CDT(-0500)] <thealphanerd> thank you

[14:33:10 CDT(-0500)] <thealphanerd> !

[14:41:33 CDT(-0500)] <Justin_o> asteig: just trying it out, not seeing the json data populate though

[14:41:38 CDT(-0500)] <Justin_o> do i need to do anything special

[14:45:11 CDT(-0500)] <asteig> Hm, it should fill in the textarea when you click export/

[14:45:43 CDT(-0500)] <asteig> Justin_o: ^

[14:51:04 CDT(-0500)] <Justin_o> asteig: yes.. it's working now.. i guess my browser had cached something.. looks good now.. thanks

[15:34:35 CDT(-0500)] <michelled> alexn1: I'm looking at your pull request: https://github.com/fluid-project/videoPlayer/pull/41/files

[15:34:54 CDT(-0500)] <michelled> I'm wondering why you close and open the tooltip

[15:35:50 CDT(-0500)] <alexn1> michelled: it is the only way to refresh it immediately. Otherwise use had to "request" the tooltip again to see the change

[15:36:06 CDT(-0500)] <michelled> sounds like a bug in the tooltip?

[15:36:18 CDT(-0500)] <michelled> this looks pretty hacky to me

[15:36:43 CDT(-0500)] <alexn1> well it seems that the initial implementation was OK with that -we even had a test with a comment // tooltip not updated until 'requested' again

[15:37:06 CDT(-0500)] <alexn1> but yes it feels very hacky

[15:37:20 CDT(-0500)] <michelled> yeah, I think we'd better fix the bug in the tooltip - not work around it

[15:37:31 CDT(-0500)] <michelled> I think that it should have a test too (smile)

[15:37:57 CDT(-0500)] <alexn1> well the initial test is a good test

[15:38:10 CDT(-0500)] <alexn1> if you remove the "toggleButton.blur().focus(); // tooltip not updated until 'requested' again"

[15:38:16 CDT(-0500)] <michelled> well, if the fix is going into Infusion, than you'll need to add a test

[15:38:30 CDT(-0500)] <alexn1> oh I see what you mean

[15:39:04 CDT(-0500)] <alexn1> we have a test in ToggleButtonTests which uses tooltip but instead we better have a test in a tooltip test files

[15:41:04 CDT(-0500)] <michelled> alexn1: one more minor thing in that request - I'd keep the casing consistent with other places "tooltip" versus "toolTip"

[15:42:41 CDT(-0500)] <alexn1> michelled: ok

[15:47:21 CDT(-0500)] <michelled> anastasiac: once I apply your pull request, should I be able to mute and unmute by pressing enter? http://issues.fluidproject.org/browse/FLUID-4745

[15:47:51 CDT(-0500)] <anastasiac> michelled, yes

[15:48:04 CDT(-0500)] <michelled> anastasiac: what browsers did you test with?

[15:48:28 CDT(-0500)] <anastasiac> hm. don't remember the full list, michelled. I take it you're finding that it works in some, but not in others?

[15:48:43 CDT(-0500)] <michelled> well, I don't see it working in FF or Chrome

[15:48:52 CDT(-0500)] <anastasiac> let me test it here

[15:52:01 CDT(-0500)] <anastasiac> michelled, it's working for me in FF and Chrome so far. I haven't yet updated to the latest code from upstream, tho, so possibly there's some interference with something else you've merged recently

[15:52:24 CDT(-0500)] <michelled> there was an upgrade of Infusion today

[15:52:32 CDT(-0500)] <michelled> that could have caused something

[15:52:40 CDT(-0500)] <anastasiac> I'll merge, and see if it breaks

[15:52:47 CDT(-0500)] <michelled> thx

[15:53:01 CDT(-0500)] <anastasiac> yep, that's it, michelled

[15:53:16 CDT(-0500)] <michelled> interesting

[15:53:20 CDT(-0500)] <anastasiac> I'll have a look at what the change was, and why it's interfering

[15:53:34 CDT(-0500)] <michelled> thx