Versions Compared

Old Version 85

changes.mady.by.user Fluid IRC Log Bot

Saved on

compared with

New Version Current

changes.mady.by.user Fluid IRC Log Bot

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: Migrated to Confluence 4.0

[08:03:27 CDT(-0500)] <heidi_> morning jameswy ! i can't open .ai files of this version (one attached to http://issues.fluidproject.org/browse/FLUID-4351) - could i view a pdf?
[08:04:02 CDT(-0500)] <heidi_> actually n/m i see there's a png of the front page. guessing that's prob enough
[08:07:10 CDT(-0500)] <huslage> hello
[08:08:01 CDT(-0500)] <jameswy> heidi_: Just tried to upload a pdf of it. Wouldn't let me.
[08:08:27 CDT(-0500)] <Justin_o> huslage: jameswy is having trouble uploading files to jira.. any ideas?
[08:08:37 CDT(-0500)] <huslage> what's he error
[08:08:52 CDT(-0500)] <jameswy> huslage: "Cannot attach file UI Options context demo.pdf: Unknown server error (201)."
[08:08:53 CDT(-0500)] <heidi_> jameswy the png is cool i think, just confirming the demo matches the mockup. anastasiac did a good job
[08:09:07 CDT(-0500)] <huslage> ugh
[08:09:08 CDT(-0500)] <huslage> ok
[08:09:59 CDT(-0500)] <heidi_> Justin_o found a UIO bug tho - not all fonts change to the select text style - known? see demos/uiOptions/html/uiOptions.html
[08:10:52 CDT(-0500)] <heidi_> same w line spacing. think we need some more importants in there
[08:11:22 CDT(-0500)] <Justin_o> heidi_: which text in particular should i be looking at?
[08:11:41 CDT(-0500)] <heidi_> Justin_o the first few lines
[08:12:25 CDT(-0500)] <Justin_o> heidi_: you're seeing this in the project repo?
[08:13:06 CDT(-0500)] <heidi_> Justin_o ah, no i guess this would be anastasia's pull req. her branch is https://github.com/acheetham/infusion/tree/FLUID-4351-newUIOContextDemo
[08:14:53 CDT(-0500)] <heidi_> the links on the side aren't affected by text size either
[08:16:53 CDT(-0500)] <heidi_> Justin_o i'm also noticing that when opening the panel w keyboard, the user has to back-tab to get into its contents. i wonder if opening the tab should move the focus to the first element
[08:17:30 CDT(-0500)] <Justin_o> heidi_: that's pretty interesting
[08:17:51 CDT(-0500)] <Justin_o> that might make sense
[08:18:15 CDT(-0500)] <heidi_> i wonder if that's standard behaviour for sliding panels
[08:18:16 CDT(-0500)] <greggy1> heidi_: FYI I found that when integrating UIO with the mediawiki themes, UIO only function properly when relative measures are used. Just an observation. Not sure if there's going to be a good solution to that.
[08:19:04 CDT(-0500)] <heidi_> greggy1 i think that makes sense. it's expected the implementer would use ems for text that can be resized
[08:19:37 CDT(-0500)] <greggy1> heidi_: that's what I figured.
[08:21:32 CDT(-0500)] <heidi_> greggy1 do you know off hand how sliding panels work for keyboard users. does the focus move to the beginning of the opened panel?
[08:39:58 CDT(-0500)] <greggy1> heidi_: not sure
[08:42:32 CDT(-0500)] <huslage> jameswy: can you try to rename the file without spaces
[08:49:00 CDT(-0500)] <jameswy> huslage: Same error: "Cannot attach file UI_Options_context_demo.pdf: Unknown server error (201)."
[09:00:07 CDT(-0500)] <lahabana> hey colinclark can you remind where I can find the component that is being deleveloped to fallback to normal tags for browsers that don't support HTML5?
[09:01:53 CDT(-0500)] <colinclark> lahabana: oh yes
[09:02:06 CDT(-0500)] <colinclark> It's one of Justin_o's repositories
[09:02:19 CDT(-0500)] <colinclark> we made it for a presentation we gave earlier in the summer about HTML5 accessibility
[09:02:53 CDT(-0500)] <colinclark> Here it is, lahabana: https://github.com/jobara/workshops/blob/master/examples/HTML5-inputs/js/HTML5-backcompat.js
[09:03:05 CDT(-0500)] <lahabana> colinclark: thx a lot (smile)
[09:03:34 CDT(-0500)] <lahabana> colinclark where is it about in the development?
[09:04:38 CDT(-0500)] <colinclark> I'm not sure what you mean?
[09:06:24 CDT(-0500)] <lahabana> well is it really buggy?
[09:06:35 CDT(-0500)] <lahabana> or almost ready to be added to the framework
[09:06:45 CDT(-0500)] <lahabana> I mean how strong can I rely on it colinclark
[09:07:58 CDT(-0500)] <colinclark> Ah, good question
[09:08:05 CDT(-0500)] <colinclark> I don't want to speak for Justin_o
[09:08:12 CDT(-0500)] <colinclark> but I think we're confident that the idiom works
[09:08:25 CDT(-0500)] <colinclark> It was written quickly for a demo, so it's never undergone any formal QA
[09:08:41 CDT(-0500)] <lahabana> ok
[09:08:48 CDT(-0500)] <colinclark> but I think it's probably pretty stable, given that it's all of seven lines of code, plus some configuration
[09:08:57 CDT(-0500)] <lahabana> true (wink)
[09:09:04 CDT(-0500)] <colinclark> I'd say go for it
[09:09:12 CDT(-0500)] <lahabana> if ever I see odd things I'll tell Justin
[09:09:16 CDT(-0500)] <colinclark> The alternative would be to use Modernizer
[09:09:25 CDT(-0500)] <colinclark> which is more widely used, but has a lot more code you don't need in it
[09:09:52 CDT(-0500)] <colinclark> that sounds good, lahabana
[09:10:37 CDT(-0500)] <lahabana> ok
[09:34:37 CDT(-0500)] <Justin_o> lahabana: just catching up, if you do use it and you find any issues, please let me know
[10:03:44 CDT(-0500)] <huslage> i imagine our attachment issues and our login issues on JIRA are related
[10:04:06 CDT(-0500)] <huslage> if i hit JIRA directly, no problems.
[10:07:13 CDT(-0500)] <huslage> Justin_o: can you try hitting: http://issues.fluidproject.org:18080/
[10:08:41 CDT(-0500)] <Justin_o> huslage: that one looks like it's working
[10:08:52 CDT(-0500)] <huslage> ok. that's our workaround. can you try to attach a file?
[10:09:47 CDT(-0500)] <Justin_o> huslage: i tried a bunch of things that weren't working and they look good.. i didn't go all the way with trying to upload a file, but as far as we got to show the error before.. and it was all working fine now
[10:09:58 CDT(-0500)] <huslage> ok.
[10:10:02 CDT(-0500)] <Justin_o> huslage: is this a new instance.. or something to do with the port
[10:10:05 CDT(-0500)] <huslage> so use it that way until atlassian can help
[10:10:20 CDT(-0500)] <huslage> we're bypassing apache and hitting tomcat directly
[10:10:27 CDT(-0500)] <huslage> i didn't change anything in jira
[10:10:47 CDT(-0500)] <Justin_o> huslage: okay.. great.. good to know
[10:11:04 CDT(-0500)] <huslage> i'm still waiting for atlassian
[10:11:46 CDT(-0500)] <Justin_o> huslage: thanks for your help with this
[10:11:54 CDT(-0500)] <huslage> (smile)
[10:11:55 CDT(-0500)] <Justin_o> i didn't try bonfire.. will that work?
[10:12:30 CDT(-0500)] <Justin_o> huslage: just tried bonfire and that doesn't work.. that's okay though.. the most important things do
[10:12:44 CDT(-0500)] <huslage> yeah i may be able to reconfigure it. not sure
[10:23:14 CDT(-0500)] <alison-benj> colinclark: hello. in a future version of mobile fss, is it planned to support non-webkit browsers?
[12:39:56 CDT(-0500)] <michelled> Bosmon: are you around?
[12:40:09 CDT(-0500)] <Bosmon> I am sort of a little bit around... but need to dash off to a meeting shortly
[12:40:26 CDT(-0500)] <michelled> cool
[12:40:34 CDT(-0500)] <Bosmon> Was just talking over my branch with the KINGG
[12:40:46 CDT(-0500)] <Bosmon> Which exposes some of the hazards of iframe-based programming
[12:40:54 CDT(-0500)] <michelled> I heard that you might know a thing or two about url validation using regular expressions
[12:41:03 CDT(-0500)] <Bosmon> http://issues.fluidproject.org/browse/FLUID-4399 emerged as an extremely hard to debug issue last night
[12:41:04 CDT(-0500)] <Bosmon> Hmm
[12:41:09 CDT(-0500)] <michelled> Bosmon: the css parser we are using has a bug in its reg exp
[12:41:12 CDT(-0500)] <Bosmon> I'm not sure I know an awful lot about that (tongue)
[12:41:14 CDT(-0500)] <Bosmon> Oh dear
[12:41:18 CDT(-0500)] <michelled> and it's rejecting valid urls
[12:41:21 CDT(-0500)] <Bosmon> Interesting
[12:41:27 CDT(-0500)] <Bosmon> Why do you want to validate them?
[12:41:36 CDT(-0500)] <Bosmon> Or - what do you want to do with them?
[12:41:39 CDT(-0500)] <michelled> well, I don't, but it does it already
[12:41:43 CDT(-0500)] <Bosmon> (smile)
[12:41:47 CDT(-0500)] <Bosmon> You could always make it stop (tongue)
[12:41:50 CDT(-0500)] <michelled> if I remove that part of the parser then we have our solution
[12:41:51 CDT(-0500)] <michelled> (smile)
[12:42:03 CDT(-0500)] <Bosmon> The LEVITHAN parser that I put into URLUtilities is generally pretty good
[12:42:07 CDT(-0500)] <michelled> but I figured it would be nicer and better to fix the issue
[12:42:12 CDT(-0500)] <Bosmon> Although I wouldn't really trust it to VALIDATE urls as such
[12:42:18 CDT(-0500)] <Bosmon> But it does generally parse them pretty well
[12:43:03 CDT(-0500)] <colinclark> So, this is interesting
[12:43:09 CDT(-0500)] <colinclark> michelled, Bosmon: just so I understand...
[12:43:18 CDT(-0500)] <colinclark> There is a bug in the CSS parser we use
[12:43:25 CDT(-0500)] <colinclark> and it's related to validation--it causes valid URLs to fail
[12:43:31 CDT(-0500)] <michelled> yes
[12:43:36 CDT(-0500)] <colinclark> And we don't really use our parser for validation purposes
[12:43:42 CDT(-0500)] <Bosmon> Sure
[12:43:44 CDT(-0500)] <colinclark> because our CSS is always so amazing exceptional (wink)
[12:43:48 CDT(-0500)] <Bosmon> Who wants validated URLs (tongue)
[12:43:53 CDT(-0500)] <michelled> (smile)
[12:44:03 CDT(-0500)] <colinclark> So, the short fix would be to just disable this aspect of the parser?
[12:44:19 CDT(-0500)] <colinclark> But michelled, I'm figuring you were thinking it wouldn't be such a bad thing to just fix the bad code while you were at it?
[12:46:02 CDT(-0500)] <michelled> yes, I thought it would be better to fix the issue especially if it's not too difficult to do
[12:46:07 CDT(-0500)] <colinclark> ok
[12:46:08 CDT(-0500)] <michelled> the problem is in the current reg exp
[12:46:13 CDT(-0500)] <colinclark> so it would involve either finding a new, cool regexp
[12:46:18 CDT(-0500)] <Bosmon> I don't think it would be in general an easy problem to fix
[12:46:20 CDT(-0500)] <colinclark> or unpacking a pretty insane one?
[12:46:26 CDT(-0500)] <Bosmon> To really properly validate URLs is a remarkably hard task
[12:46:31 CDT(-0500)] <colinclark> you should paste it in, just for fun, michelled
[12:46:31 CDT(-0500)] <colinclark> (smile)
[12:46:37 CDT(-0500)] <Bosmon> And ironically, may not actually be entirely possible using a regexp (tongue)
[12:46:39 CDT(-0500)] <colinclark> it traumatized me on first glance
[12:46:49 CDT(-0500)] <Bosmon> I'm sure this regexp is trying very hard
[12:46:54 CDT(-0500)] <Bosmon> It should be given points for effort (tongue)
[12:46:59 CDT(-0500)] <michelled> colinclark: http://pastie.org/2361463
[12:47:05 CDT(-0500)] <Bosmon> But similarly to the way it's not actually possible to parse HTML using a regexp....
[12:47:18 CDT(-0500)] <colinclark> my eyes are burning!
[12:47:33 CDT(-0500)] <colinclark> What is this LEVITHAN thing you are referring to, Professor Bosmon?
[12:47:44 CDT(-0500)] <Bosmon> Fascinating
[12:47:48 CDT(-0500)] <colinclark> Doctor Ant!
[12:47:49 CDT(-0500)] <Bosmon> It consists of 2 nested regexps
[12:48:02 CDT(-0500)] <Bosmon> That model might conceivably be powerful enough to parse URLs (tongue)
[12:48:04 CDT(-0500)] <Bosmon> But clearly this one fails
[12:48:18 CDT(-0500)] * jhung contemplates clicking the "report abuse" button on Michelled's link. (tongue)
[12:48:23 CDT(-0500)] <Bosmon> The LEVITHAN parser is one that has been doing the rounds for a long time...
[12:48:24 CDT(-0500)] <colinclark> lol
[12:48:35 CDT(-0500)] <Bosmon> An earlier version of it used to be in RSF.js
[12:48:49 CDT(-0500)] <Bosmon> I picked up the most current version of it I could find and put it into URLUtilities.js last week
[12:48:53 CDT(-0500)] <colinclark> I hate to ask such boring questoins... what is its license?
[12:48:59 CDT(-0500)] <colinclark> Are we cool on that front?
[12:49:04 CDT(-0500)] <Bosmon> But it doesn't pretend to validate URLs, just to parse them into segments
[12:49:05 CDT(-0500)] <colinclark> Do we need to make reference to it in our README?
[12:49:08 CDT(-0500)] <Bosmon> Yes, it is an MIT licence snippet
[12:49:13 CDT(-0500)] <Bosmon> No worries there
[12:49:20 CDT(-0500)] <michelled> Bosmon: does that mean it's not yet in master?
[12:49:26 CDT(-0500)] <Bosmon> It is in master already
[12:49:37 CDT(-0500)] <Bosmon> Oh wait
[12:49:45 CDT(-0500)] <Bosmon> I don't actually know if my relative URL fix was committed yet
[12:49:53 CDT(-0500)] <colinclark> Nope
[12:49:56 CDT(-0500)] <colinclark> that would be my fault
[12:49:59 CDT(-0500)] <colinclark> I'm on it
[12:49:59 CDT(-0500)] <Bosmon> It is in my pull request for fixing the relative URL bug colin founda at the weekend
[12:50:01 CDT(-0500)] <colinclark> sort of
[12:50:10 CDT(-0500)] <colinclark> colin founda a bug
[12:50:34 CDT(-0500)] <colinclark> ok, i'll do my best to get it in this aft
[12:50:39 CDT(-0500)] <colinclark> I guess, Fish, it's an interesting question
[12:50:49 CDT(-0500)] <colinclark> do you want to find a viable URL validator...
[12:50:55 CDT(-0500)] <colinclark> or do you want to disable it and run?
[12:51:06 CDT(-0500)] <michelled> to be honest I want to rewrite the parser - or at least strip it down
[12:51:09 CDT(-0500)] <Bosmon> I might actually be willing to lay money you wouldn't find a viable URL validator (smile)
[12:51:45 CDT(-0500)] <colinclark> how much, Bosmon?
[12:51:54 CDT(-0500)] <michelled> Bosmon, colinclark, Justin_o: if you all are good with removing url validation then I'm happy to go that route.
[12:51:58 CDT(-0500)] <Bosmon> Bottle of Bowmore (smile)
[12:52:00 CDT(-0500)] <colinclark> woah
[12:52:08 CDT(-0500)] <colinclark> what age?
[12:52:10 CDT(-0500)] <michelled> hmmmm maybe I should look
[12:52:10 CDT(-0500)] <colinclark> (tongue)
[12:52:14 CDT(-0500)] <michelled> or write one ...
[12:52:17 CDT(-0500)] <michelled> (smile)
[12:52:25 CDT(-0500)] <Bosmon> writing one doesn't count (smile)
[12:52:27 CDT(-0500)] <colinclark> depending on the bottle, it might be a worthy investment
[12:52:35 CDT(-0500)] <colinclark> no fair
[12:52:42 CDT(-0500)] <colinclark> "Look, I found a viable URL parser!"
[12:52:46 CDT(-0500)] <colinclark> "It's here on my hard drive!"
[12:52:47 CDT(-0500)] <Bosmon> Viable URL validator counts as one that is i) in existence, ii) has at least a dozen test cases (tongue)
[12:52:53 CDT(-0500)] <colinclark> ooooh
[12:52:54 CDT(-0500)] <anastasiac> heidi_, quick question about the new uiOptions demo: as you saw, the line-spacing adjustments aren't applying to the header and tagline. I had to actually set the line-height in the css (line 48 of the CSS file) to make it work properly when wrapping, and I'm guessing that's the problem. Is there another way to fix the wrap problem that wouldn't interfere with the line-spacing adjustments?
[12:53:00 CDT(-0500)] <colinclark> that's raising the stakes quite a bit
[12:53:07 CDT(-0500)] <colinclark> how old is the bowmore, then?
[12:53:32 CDT(-0500)] <Bosmon> 17 or more (tongue)
[12:53:51 CDT(-0500)] <colinclark> so, if fish finds nothing
[12:53:54 CDT(-0500)] <colinclark> is she buying the bottle?
[12:54:04 CDT(-0500)] <michelled> hey, that wasn't in the agreement (tongue)
[12:54:08 CDT(-0500)] <Bosmon> hahaha
[12:54:09 CDT(-0500)] <colinclark> lol
[12:54:22 CDT(-0500)] <colinclark> Finding anyone's code with a dozen test cases is hardly worth risking
[12:54:38 CDT(-0500)] <Bosmon> I'm sure a nice bottle of wine would be considered an acceptable alternative forfeit (tongue)
[12:55:02 CDT(-0500)] <colinclark> this is a great bet
[12:55:15 CDT(-0500)] <Bosmon> I'd be willing to even lower the stakes to 6 test cases
[12:55:20 CDT(-0500)] <Bosmon> But I still don't think you'll find anything (tongue)
[12:55:20 CDT(-0500)] <michelled> it's actually pretty ironic that one of the reasons we liked this parser was the fact that it wasn't based on regular expressions
[12:55:25 CDT(-0500)] <colinclark> I wonder what the King would say about us betting away his kingdom like this (tongue)
[12:55:36 CDT(-0500)] <michelled> finding anything with testcases it highly unlikely
[12:55:52 CDT(-0500)] <Bosmon> It's hard to say how you could know something could "validate" something if it had no test cases (tongue)
[12:56:01 CDT(-0500)] <colinclark> "I bet you three pull request reviews that you can't drink Bosmon's bottle of Bowmore in one sitting"
[12:56:01 CDT(-0500)] <Bosmon> michelled - what do you mean that it isn't based on regexps?
[12:56:07 CDT(-0500)] <Bosmon> hahahah
[12:56:25 CDT(-0500)] <colinclark> Well, most of the parser doesn't use regexps
[12:56:26 CDT(-0500)] <michelled> do I have to be alive after?
[12:56:30 CDT(-0500)] <Bosmon> michelled - it is based on TWO regexps - which is twice as bad (tongue)
[12:56:37 CDT(-0500)] <colinclark> the CSS parser as a whole, she means
[12:56:43 CDT(-0500)] <Bosmon> Oh, I see
[12:56:48 CDT(-0500)] <Bosmon> That's interesting
[12:56:51 CDT(-0500)] <michelled> it's only the url validation part that uses regular expressions - the rest doesn't
[12:57:03 CDT(-0500)] <colinclark> not to say that we think it's an amazing parser
[12:57:05 CDT(-0500)] <Bosmon> That's probably just as well
[12:57:15 CDT(-0500)] <colinclark> I actively had to restrain michelled from rewriting it with Jison the other day
[12:57:22 CDT(-0500)] <michelled> (smile)
[12:57:22 CDT(-0500)] <colinclark> by shouting "SHIP!" at her
[12:57:34 CDT(-0500)] <michelled> not just shouting - chanting!
[12:57:36 CDT(-0500)] <Bosmon> The "XML" parser I found works in a similar piecemeal kind of way
[12:57:52 CDT(-0500)] <colinclark> the pull parser, you mean?
[12:57:55 CDT(-0500)] <Bosmon> You could say it either has a lot of test cases now, or none (tongue)
[12:57:57 CDT(-0500)] <Bosmon> Yes, that one
[12:58:01 CDT(-0500)] <colinclark> ah, yes
[12:58:11 CDT(-0500)] <michelled> I don't think it's worth the time right now to fix this issue - I'm tempted to go with removing the url validation section
[12:58:11 CDT(-0500)] <huslage> back
[12:58:30 CDT(-0500)] <Bosmon> If you look at the actual spec for URLs, you will see it is not a thing to be taken lightly....
[12:58:56 CDT(-0500)] <huslage> drupal is evil
[12:59:04 CDT(-0500)] <huslage> i don't need an OS on top of my OS
[12:59:06 CDT(-0500)] <colinclark> what did you learn, huslage?
[12:59:07 CDT(-0500)] <michelled> what this probably means though is that we won't be able to push our modifications upstream
[12:59:08 CDT(-0500)] <huslage> it's really unnecessary
[12:59:10 CDT(-0500)] <colinclark> about drupal
[12:59:15 CDT(-0500)] <huslage> it's evil
[12:59:29 CDT(-0500)] <colinclark> what's the nature of the evil?
[12:59:30 CDT(-0500)] <michelled> I can at least let the author or the other person who forked the code what I've found and point them to our fork
[12:59:37 CDT(-0500)] <colinclark> like, is it stored in a pie?
[12:59:42 CDT(-0500)] <Bosmon> Can we write a test case? (tongue)
[12:59:46 CDT(-0500)] <huslage> it is just naturally evil.
[12:59:48 CDT(-0500)] <colinclark> that part is done (smile)
[12:59:48 CDT(-0500)] <michelled> I've got test cases (smile)
[12:59:48 CDT(-0500)] <huslage> like
[12:59:58 CDT(-0500)] <huslage> Drush? who thought THAT was a good idea?!
[13:00:21 CDT(-0500)] <michelled> there could be better test cases written but the ones I have show the issue quite well
[13:00:29 CDT(-0500)] <Bosmon> michelled - that's cool
[13:00:39 CDT(-0500)] <Bosmon> out of interest, what kind of URL does it fail on?
[13:00:43 CDT(-0500)] <michelled> the problem is when we get urls with slashes in them
[13:00:57 CDT(-0500)] <michelled> "../mouse.png"
[13:01:04 CDT(-0500)] <michelled> "../images/chipmunk.png"
[13:01:11 CDT(-0500)] <michelled> "http://racoons.ca/racoon.png&#034;"
[13:02:00 CDT(-0500)] <colinclark> wow, racoons!
[13:02:02 CDT(-0500)] <colinclark> scary things
[13:03:00 CDT(-0500)] <huslage> http://knowyourmeme.com/i/000/039/080/original/5008_9c00_420.gif?1265669754
[13:04:30 CDT(-0500)] <heidi_> anastasiac sorry missed yr msg. the line-height issue is a UIO thing instead of a demo thing, i think. UIO should be able to "win" over any line-height setting already there, right Justin_o ?
[13:05:08 CDT(-0500)] <anastasiac> ok, cool, heidi_, I just wasn't sure if maybe I was doing something I shouldn't be doing in the css
[13:06:14 CDT(-0500)] <Justin_o> heidi_: i think it should
[13:07:31 CDT(-0500)] <colinclark> michelled: umm, I just read that more closely
[13:07:33 CDT(-0500)] <colinclark> umm
[13:07:39 CDT(-0500)] <colinclark> Since when do URLs not have slashes in them?
[13:07:44 CDT(-0500)] <Bosmon> Well, that's pretty astounding
[13:07:50 CDT(-0500)] <colinclark> that is a very borked validator
[13:07:52 CDT(-0500)] <Bosmon> Yes, colinclark's remark (tongue)
[13:08:03 CDT(-0500)] <michelled> https://github.com/michelled/JSCSSP/blob/FLUID-4395/tests/jscssp/js/jscsspTests.js#L38-56
[13:08:06 CDT(-0500)] <michelled> that's my test (smile)
[13:08:16 CDT(-0500)] <michelled> all the other animals pass
[13:08:19 CDT(-0500)] <colinclark> hey, I see more than a dozen here
[13:08:22 CDT(-0500)] <colinclark> Do I get free scotch?
[13:09:16 CDT(-0500)] <Bosmon> I presume I didn't need to specify that the tests actually need to pass (smile)
[13:09:29 CDT(-0500)] <michelled> oh, now you tell us!
[13:09:33 CDT(-0500)] <Bosmon> hah
[13:09:41 CDT(-0500)] <colinclark> michelled: What about a test for "url('/hamster.jpg')"?
[13:09:43 CDT(-0500)] <Bosmon> I was SURE raccoon had 2 cs....
[13:10:12 CDT(-0500)] <colinclark> "The raccoon (pronounced /ræˈkuːn/ ( listen), Procyon lotor), sometimes spelled as racoon..."
[13:10:26 CDT(-0500)] <colinclark> michelled saved by Wikipedia
[13:11:01 CDT(-0500)] <colinclark> oh wait
[13:11:04 CDT(-0500)] <Bosmon> I wonder why it is unhappy about the racoon then
[13:11:05 CDT(-0500)] <colinclark> you've used hamster already
[13:11:17 CDT(-0500)] <colinclark> my repertoire of animals is running out
[13:11:21 CDT(-0500)] <colinclark> how's this?
[13:11:33 CDT(-0500)] <colinclark> "url('beerWolf.jpg')"
[13:11:44 CDT(-0500)] <colinclark> with a slash in there
[13:12:00 CDT(-0500)] <Bosmon> "mauseBeer.jpg"
[13:13:03 CDT(-0500)] <michelled> beerWolf fails
[13:13:08 CDT(-0500)] <michelled> with the slash in front
[13:13:13 CDT(-0500)] <colinclark> interesting
[13:13:58 CDT(-0500)] <michelled> one of the things I should have mentioned is that not all urls were passing through this section of code before. I'm sure that was not intentional
[13:14:16 CDT(-0500)] <michelled> urls specified with 'background' were but 'background-image' were not
[13:15:08 CDT(-0500)] <colinclark> I can imagine the spec for the url() declaration is consistent
[13:15:17 CDT(-0500)] <michelled> it is
[13:21:35 CDT(-0500)] <colinclark> huslage: I think people are starting to feel a little cranky about how rough our JIRA instance is feeling these days
[13:21:44 CDT(-0500)] <colinclark> with nearly everything Ajaxy being broken
[13:21:48 CDT(-0500)] <colinclark> any update on how that is all going?
[13:21:59 CDT(-0500)] <huslage> i provided a work around in lieu of atlassian actually helping me
[13:22:12 CDT(-0500)] <huslage> go to http://issues.fluidproject.org:18080/
[13:22:18 CDT(-0500)] <huslage> which bypasses the proxy
[13:22:45 CDT(-0500)] <colinclark> Can you send an email to fluid-work explaining the issue, what's you're doing to address it (i.e. the conversation so far with Atlassian) and the workaround?
[13:22:48 CDT(-0500)] <colinclark> Just so everyone knows
[13:22:53 CDT(-0500)] <huslage> sure
[13:22:53 CDT(-0500)] <colinclark> I'm sure a couple of sentences is enough
[13:22:55 CDT(-0500)] <colinclark> thanks, dude
[13:23:01 CDT(-0500)] <huslage> sorry i haven't
[13:24:13 CDT(-0500)] <michelled> ah, so much better huslage (smile)
[13:25:50 CDT(-0500)] <Bosmon> michelled - perhaps you could turn URL validation into a configuration option?
[13:26:09 CDT(-0500)] <Bosmon> That might be a way we might still be able to push patches upstream...
[13:28:01 CDT(-0500)] <michelled> that's a possibility Bosmon - I'll look at doing that as soon as I get something we can test against for UIO
[13:30:53 CDT(-0500)] <Bosmon> huslage - what happens to me if I carry on using the old URLs?
[13:30:58 CDT(-0500)] <Bosmon> Do I turn into a PUMKIN?
[13:31:02 CDT(-0500)] <huslage> you explode
[13:31:07 CDT(-0500)] <huslage> it's disgusting really
[13:31:23 CDT(-0500)] <Bosmon> Do I explode before or after I turn into a PUMKIN...
[13:31:52 CDT(-0500)] <anastasiac> Bosmon, do you know whether or not I should be able to render a set of radio buttons using images for the labels, and if so, what the $!@%& would the prototree look like for that?
[13:32:14 CDT(-0500)] <Bosmon> anastasiac - certainly, you can render that (smile)
[13:32:29 CDT(-0500)] <Bosmon> I wouldn't think there's anything very unusual about the protoTree...
[13:32:32 CDT(-0500)] <michelled> if you turn into PUMPKIN are you required to get the lion haircut?
[13:32:53 CDT(-0500)] <Bosmon> anastasiac - I guess you are still using the label element, right?
[13:32:55 CDT(-0500)] <Bosmon> Is that the idea?
[13:33:04 CDT(-0500)] <Bosmon> That you want to render an img inside label? Assuming HTML allows that...
[13:33:17 CDT(-0500)] <Bosmon> huslage - Google "spispopd"
[13:33:27 CDT(-0500)] <anastasiac> Bosmon, yes, and I don't know how to specify the src of the img element using the prototree
[13:33:30 CDT(-0500)] <huslage> do i really want to do that?
[13:33:42 CDT(-0500)] <anastasiac> and yes, html does allow that Bosmon
[13:36:08 CDT(-0500)] <Bosmon> anastasiac - you just use a UILink component
[13:36:44 CDT(-0500)] <anastasiac> and how do I get the ui link component into the "optionlist" of the selection tree, Bosmon?
[13:37:11 CDT(-0500)] <Bosmon> You don't - it becomes part of the "exploded material" which also contains the UISelectChoice components peering with the radio buttons
[13:39:16 CDT(-0500)] <anastasiac> Bosmon, here's my radio-buttons demo without images: https://github.com/acheetham/Infusion-Instructional-Demos/blob/master/src/webapp/demos/instructional/renderer/js/radio.js How to I change the prototree to add the UILink?
[13:40:38 CDT(-0500)] <Bosmon> anastasiac - you can't use the selection to inputs expander any more for this case
[13:40:44 CDT(-0500)] <Bosmon> You need to write out the prototree longhand
[13:40:54 CDT(-0500)] <Bosmon> You can probably find a way to use the repetition expander for this though
[13:41:02 CDT(-0500)] <anastasiac> ah, that makes more sense
[13:41:26 CDT(-0500)] <anastasiac> good! a chance for me to learn to use the repetition expander!
[13:41:31 CDT(-0500)] <Bosmon> You may want to look at the old RSF "monkey choosing demo" for inspiration for this (tongue)
[13:41:38 CDT(-0500)] <Bosmon> Since we are in the model of choosing animals...
[13:42:25 CDT(-0500)] <Bosmon> http://rsf.fluidproject.org/wiki/Wiki.jsp?page=ComponentTest
[13:43:14 CDT(-0500)] <huslage> what is that site?
[13:43:24 CDT(-0500)] <huslage> OMG WHAT A CUTE MONKEY.
[13:43:25 CDT(-0500)] <huslage> lol
[13:43:31 CDT(-0500)] <Bosmon> hahaha
[13:43:47 CDT(-0500)] <Bosmon> huslage is disturbed from his sysadminly horror by the power of the SMALLEST MONKEY
[13:43:55 CDT(-0500)] <huslage> it is true
[13:44:05 CDT(-0500)] <huslage> i've stopped monkeying with the evil drupal
[13:44:09 CDT(-0500)] <huslage> lol
[13:44:54 CDT(-0500)] <huslage> oh i remember spispopd
[13:45:13 CDT(-0500)] <huslage> god that's been long enough that my brain stopped having to think about it
[13:50:49 CDT(-0500)] <anastasiac> Bosmon, do we have a prototree format for UISelectChoice (not UISelect, that I know)? and not a tree format, that I know, I mean a *proto*tree format... In a prototree, the keys are the IDs, but for UISelectChoice, all the IDs are the same...
[13:56:23 CDT(-0500)] <anastasiac> have I stumped Bosmon, or has he stepped away? (wink)
[14:00:57 CDT(-0500)] <anastasiac> apparently, Bosmon is in a meetings (I should have known I couldn't stump him)
[14:02:20 CDT(-0500)] <colinclark> Bosmon: I wonder if, in the long run, this might be a more robust implementation than jsdom: https://github.com/andreasgal/dom.js
[14:14:02 CDT(-0500)] <colinclark> Justin_o: oh king
[14:14:10 CDT(-0500)] <colinclark> I'd like to petition you to do something very unorthodox
[14:14:23 CDT(-0500)] <Justin_o> colinclark: okay.. what is it?
[14:14:23 CDT(-0500)] <colinclark> I'd like to push this straight to the project repo
[14:14:25 CDT(-0500)] <colinclark> https://github.com/colinbdclark/infusion/commit/59905622e23de4edcaddcd1f8bc288ef70d6a1b8
[14:24:04 CDT(-0500)] <colinclark> it works on my machine
[14:24:11 CDT(-0500)] <colinclark> you're probably the best to review it
[14:24:33 CDT(-0500)] <colinclark> fortunately it's one line (smile)
[14:24:39 CDT(-0500)] <colinclark> of a properties file, no less
[14:24:47 CDT(-0500)] <Justin_o> colinclark: it looks safe enough (smile)
[14:24:55 CDT(-0500)] <Justin_o> i think you should go for it
[14:25:16 CDT(-0500)] <colinclark> Do you want to bug parade-ize the issue? http://issues.fluidproject.org/browse/FLUID-4389
[14:42:34 CDT(-0500)] <Justin_o> colinclark: it's paradized
[14:43:13 CDT(-0500)] <colinclark> thanks
[15:11:45 CDT(-0500)] <colinclark> hey Justin_o
[15:11:48 CDT(-0500)] <colinclark> Can I break the rules again?
[15:11:55 CDT(-0500)] <colinclark> This one works: https://github.com/colinbdclark/infusion/commit/0b2068cffe66fb1b594980aa372a4cc566058c01
[15:11:59 CDT(-0500)] <colinclark> do you want to review and push?
[15:12:01 CDT(-0500)] <colinclark> Or shall I?