Page Comparison

[08:59:00 CDT(-0500)] <heidi_> Justin_o i'll do that linearization tweak before lunch
[08:59:40 CDT(-0500)] <Justin_o> heidi_: thanks.. let me know when it's in for me to look at
[09:10:11 CDT(-0500)] <anastasiac> Justin_o, heidi, I've just filed a bug against the FSS: http://issues.fluidproject.org/browse/FLUID-4204 Not sure what it's priority should be - the "rust" theme isn't working on menus
[09:12:15 CDT(-0500)] <Justin_o> heidi_: do you have any thoughts on that?
[09:12:38 CDT(-0500)] <heidi_> the rust theme was deprecated i thought? it's missing tons of stuff
[09:13:03 CDT(-0500)] <anastasiac> oh, I didn't know it was deprecated
[09:13:08 CDT(-0500)] <anastasiac> that would explain it
[09:14:06 CDT(-0500)] <anastasiac> ok, if it's deprecated, I'll close the issue as "won't fix" with a note
[09:14:10 CDT(-0500)] <heidi_> anastasiac i'm not really sure what the deal is with rust... it doesn't seem to be used, and it's missing a lot of styles
[09:14:33 CDT(-0500)] <heidi_> Justin_o didn't you say it was going to be deprecated? jacob mentioned it or something?
[09:15:21 CDT(-0500)] <heidi_> if i'm wrong, then we should add the menu style in, ya
[09:15:25 CDT(-0500)] <anastasiac> well, we should decide if it's officially deprecated or not, and if so document that, both on the wiki and in the file itself. If not, we should fix it
[09:16:34 CDT(-0500)] <Justin_o> heidi_, anastasiac: right jacob had told me once that he wanted to drop rust
[09:17:04 CDT(-0500)] <heidi_> it seems there's a lot missing from it so it might take more time to get it up to speed with the rest
[09:17:12 CDT(-0500)] <heidi_> but not sure it's worth keeping
[09:17:25 CDT(-0500)] <Justin_o> cindyli: could you do me a favour and make sure that the daily build of the builder isn't using the same database as the production build
[09:17:45 CDT(-0500)] <cindyli> sure, Justin_o
[09:17:50 CDT(-0500)] <Justin_o> cindyli: thanks
[09:19:08 CDT(-0500)] <Justin_o> heidi_: so i think anastasiac is right though, we should either officially deprecate it or update it
[09:19:19 CDT(-0500)] <heidi_> totally
[09:19:20 CDT(-0500)] <Justin_o> do either of you have a preference?
[09:19:28 CDT(-0500)] <heidi_> deprecate
[09:19:29 CDT(-0500)] <Justin_o> should we take it to the list
[09:19:32 CDT(-0500)] <Justin_o> ?
[09:19:46 CDT(-0500)] <heidi_> unless it's meaningful somehow to the accessibility world vs. just diff colour scheme, but i don't think it is
[09:20:11 CDT(-0500)] <Justin_o> heidi_: i don't think it had any specific meaning for a11y... at least not that i'm aware of
[09:20:26 CDT(-0500)] <heidi_> i'm guessing that's why it got left behind
[09:20:36 CDT(-0500)] <cindyli> Justin_o: confirmed that the production and daily build are not using the same db.
[09:20:41 CDT(-0500)] <heidi_> we'll be adding two new themes as well (yellow/black)
[09:21:20 CDT(-0500)] <Justin_o> cindyli: thanks
[09:21:26 CDT(-0500)] <cindyli> np, Justin_o
[09:21:57 CDT(-0500)] <Justin_o> heidi_: right...
[09:22:05 CDT(-0500)] <Justin_o> anastasiac: what do you think about depricating it
[09:23:29 CDT(-0500)] <anastasiac> Justin_o, I guess I'm ok with deprecating it. I guess it depends on why we have themes in the FSS - if they're mainly for a11y helpfulness, then rust doesn't really do that; if they're also for niceness, then the argument might be different
[09:23:53 CDT(-0500)] <Justin_o> jamon: i've made some updates for the daily builds of things.. the builder is working again.. the nightly builds have been rescheduled to happen nightly instead of hourly.. there are hourly builds of infusion and an uploader server
[09:25:01 CDT(-0500)] <Justin_o> jamon: some things that still need to be done though are 1) that the builder still reports a successful build even when the scripts to run the build fail 2) is it possible to expose the hourly builds of infusion and the uploader server?
[09:25:11 CDT(-0500)] <Justin_o> jamon: did you have any thoughts on those things?
[09:25:55 CDT(-0500)] <jamon> Justin_o: i guess the successful status needs changing because it is a bash script instead of ant
[09:26:10 CDT(-0500)] <jamon> and exposing them should be easy enough, do you have an admin login?
[09:26:53 CDT(-0500)] <Justin_o> jamon: i think so
[09:28:05 CDT(-0500)] <Justin_o> anastasiac: i'm not entirely sure
[09:28:12 CDT(-0500)] <Justin_o> so maybe we should take this to the list then
[09:28:25 CDT(-0500)] <anastasiac> maybe
[09:28:43 CDT(-0500)] <Justin_o> i don't quite remember the full history or intentions of the themes
[09:33:38 CDT(-0500)] <heidi_> Justin_o anastasiac if we go by fss's usefulness to UIO, only themes with a11y help are choices
[09:33:45 CDT(-0500)] <heidi_> ie. all but rust
[09:35:57 CDT(-0500)] <Justin_o> heidi_: is mist that useful for a11y though?
[09:36:24 CDT(-0500)] <heidi_> Justin_o not sure - is it a UIO choice?
[09:37:17 CDT(-0500)] <heidi_> hm, i see rust is used too... is it really?
[09:37:18 CDT(-0500)] <heidi_> "mist": "fl-theme-mist",
[09:37:18 CDT(-0500)] <heidi_> "rust": "fl-theme-rust",
[09:37:18 CDT(-0500)] <heidi_> "highContrast": "fl-theme-hc",
[09:37:20 CDT(-0500)] <heidi_> "highContrastInverted": "fl-theme-hci",
[09:37:20 CDT(-0500)] <heidi_> "lowContrast": "fl-theme-slate",
[09:37:20 CDT(-0500)] <heidi_> "mediumContrast": "fl-theme-coal",
[09:37:20 CDT(-0500)] <heidi_> "default": ""
[09:38:59 CDT(-0500)] <heidi_> there's only 5 choices in the dropdown on the build site tho... odd. i think mist is "medium contrast" and coal is "medium contrast grey scale"
[09:41:04 CDT(-0500)] <heidi_> Justin_o i'm wrong "medium contrast" = no theme. so no mist isn't used here
[09:41:51 CDT(-0500)] <heidi_> Justin_o we're also going to have a new theme soon for "Infusion" so that will be more nice vs a11y
[09:47:38 CDT(-0500)] <Justin_o> heidi_, anastasiac, so i think what we're saying here is that fss themes are more than a11y
[09:47:47 CDT(-0500)] <heidi_> yep
[09:47:49 CDT(-0500)] <Justin_o> however do we still want rust, and if so, then we should update it
[09:48:11 CDT(-0500)] <heidi_> i think we should spend our time/energy elsewhere and let rust go
[09:56:09 CDT(-0500)] <cindyli> Justin_o: i sent a pull request to merge my FLUID-4171 branch (https://github.com/cindyli/infusion/tree/FLUID-4171) into project repo. all the tests are fixed.
[10:00:24 CDT(-0500)] <cindyli> Justin_o, heidi_: my next step is to re-construct UIEnhancer with IoC.
[10:00:37 CDT(-0500)] <heidi_> cindyli awesome!
[10:02:46 CDT(-0500)] <Justin_o> cindyli: nice... i'll try to take a look at that
[10:02:58 CDT(-0500)] <cindyli> thx, Justin_o
[10:20:24 CDT(-0500)] <cindyli> oh, heidi_, in terms of the live preview, let me know if i can help with.
[10:20:52 CDT(-0500)] <heidi_> cindyli thanks! i'm going to give it a go soon. colin was a big help yesterday so i think we're almost there
[10:21:07 CDT(-0500)] <cindyli> great.
[10:21:28 CDT(-0500)] <Justin_o> cindyli: just starting to look at your pull request.. did michelle code review any of this stuff yet?
[10:21:48 CDT(-0500)] <cindyli> she didn't mention it, Justin_o
[10:21:57 CDT(-0500)] <cindyli> probably no
[10:24:11 CDT(-0500)] <Justin_o> cindyli: okay.. thanks
[10:24:25 CDT(-0500)] <cindyli> np
[10:37:49 CDT(-0500)] <jessm> woah, did i just miss standup?!
[10:51:04 CDT(-0500)] <Justin_o> jessm: yes.. sorry.. i guess we got through it pretty quick.. not too many people were there
[10:51:20 CDT(-0500)] <Justin_o> we have a small crowd in the office today
[10:52:55 CDT(-0500)] <Justin_o> jhung: jessm just saw this mentioned on the mcn list
[10:52:56 CDT(-0500)] <Justin_o> http://www.smugmug.com/
[10:53:10 CDT(-0500)] <Justin_o> apparently they have free accounts for non profits
[10:53:22 CDT(-0500)] <Justin_o> i wonder if we want use something like that for IDRC photos and etc.
[11:11:28 CDT(-0500)] <jessm> Justin_o: nice!
[11:11:30 CDT(-0500)] <jessm> thanks for the pointer
[11:11:47 CDT(-0500)] <Justin_o> jessm: np
[11:57:43 CDT(-0500)] <heidi_> Justin_o is my FLUID-4150 the most up to date linear branch? i forget if you added stuff
[11:58:02 CDT(-0500)] <Justin_o> heidi_: nope i don't think i added anything
[11:58:09 CDT(-0500)] <heidi_> k gonna tweak now
[11:58:15 CDT(-0500)] <Justin_o> heidi_: okay
[12:03:31 CDT(-0500)] <heidi_> Justin_o i pushed the change, can you test?
[12:11:32 CDT(-0500)] <Justin_o> heidi_: will do.. thanks
[12:20:23 CDT(-0500)] <cindyli> Justin_o: regarding ur question of updateModelAndAria(). u r right that this func does not update model, it actually fires the slider's modelChanged event.
[12:21:13 CDT(-0500)] <Justin_o> heidi_: so couple of questions... 1) what happens to the asolutely positioned elements now.. it looks like in the test page they over lap 2) is there a problem with the tabs when linearized.. it looks like they move down lower and now will overlap the text
[12:22:18 CDT(-0500)] <cindyli> since this func is called by textfieldSlider.refreshView() that is called by the listener of modelChanged event, so the setting of the aria is already as u suggested. let me know if i'm wrong, Justin_o
[12:22:48 CDT(-0500)] <Justin_o> cindyli: sorry.. not sure i followed that last part
[12:23:19 CDT(-0500)] <cindyli> Justin_o: line 86, updateModelAndAria() is called by fluid.textfieldSlider.refreshView()
[12:23:25 CDT(-0500)] <heidi_> Justin_o the abs positioned divs do what all divs do - fill out width wise, except now they're not linear. not sure about tabs... maybe compare to what it did before and see if it's fix able?
[12:23:36 CDT(-0500)] <cindyli> line 99, that.applier.modelChanged.addListener("value", that.refreshView);
[12:24:23 CDT(-0500)] <cindyli> that .refreshView is the listener func of modelChanged event
[12:25:00 CDT(-0500)] <Justin_o> heidi_: okay.. i'll take a look
[12:25:53 CDT(-0500)] <cindyli> Justin_o: i'm thinking to get rid of updateModelAndAria() and move these 2 lines into refreshView()
[12:27:49 CDT(-0500)] <Justin_o> cindyli: i see.. so you listen for a changeApplier event which triggers a call to refreshview which calls updatemodelandaria which fires the actual model changed event
[12:28:11 CDT(-0500)] <cindyli> exactly, Justin_o
[12:29:22 CDT(-0500)] <Justin_o> cindyli: i don't think you'd want the refreshview to actually fire the modelChanged event
[12:29:37 CDT(-0500)] <cindyli> why
[12:29:41 CDT(-0500)] <Justin_o> what if someone just invoked the refreshview function without actually changing the model
[12:29:46 CDT(-0500)] <Justin_o> since it is a public function
[12:30:33 CDT(-0500)] <cindyli> good point, Justin_o
[12:30:36 CDT(-0500)] <Justin_o> however.. i think you'd always want to call refreshView after the model has changed
[12:30:45 CDT(-0500)] <Justin_o> correct me if that's a bad assumption
[12:32:12 CDT(-0500)] <Justin_o> so maybe what you want is for your that.applier.modelChanged.listener to actually just immediately call the modelChanged event
[12:32:21 CDT(-0500)] <Justin_o> and have a listener for that, which calls refresh view
[14:03:47 CDT(-0500)] <cindyli> Justin_o: mlam, checking on fluid.staticEnvironment works like a charm. now i can hide configration section along with the single file uploader. thanks a lot, guys
[14:06:03 CDT(-0500)] <colinclark> sounds like Justin_o and mlam taught you some cool IoC tricks, cindyli
[14:06:14 CDT(-0500)] <cindyli> yes, they did
[14:06:30 CDT(-0500)] <colinclark> awesome
[14:20:38 CDT(-0500)] <colinclark> lahabana: Hey, glad you could join us in the channel. How's it going?
[14:24:36 CDT(-0500)] <mlam> cool, cindyli!
[14:33:28 CDT(-0500)] <jameswy> heidi_: Pushed up changes.
[14:33:53 CDT(-0500)] <heidi_> jameswy happen to move stand-alone demo stuff into /demos ?
[14:34:06 CDT(-0500)] <jameswy> heidi_: Not yet.
[14:34:13 CDT(-0500)] <heidi_> i want to start separating global styles (in UIOptions.css) from the particular layout styles
[14:34:34 CDT(-0500)] <heidi_> jameswy is the full preview still using just UIOptions.css or does it have a sep css now too
[14:34:46 CDT(-0500)] <jameswy> heidi_: Still using the original file.
[14:34:50 CDT(-0500)] <heidi_> ok
[14:49:58 CDT(-0500)] <heidi_> Justin_o git add -u doesn't stage deleted files, right? is there a flag that does?
[14:53:27 CDT(-0500)] <Justin_o> heidi_: for deleting files you should do "git rm path/to/file"
[14:53:55 CDT(-0500)] <Justin_o> heidi_: if you've already deleted them though.. i think there's a work around.. one second
[14:56:20 CDT(-0500)] <heidi_> hm, i think -u should do it...
[14:56:28 CDT(-0500)] <heidi_> doesn't seem to be tho
[14:57:56 CDT(-0500)] <heidi_> Justin_o maybe -u did work
[14:59:35 CDT(-0500)] <Justin_o> heidi_: not sure.. i remember running into this problem.. and it was because you couldn't stage something that wasn't there
[14:59:42 CDT(-0500)] <Justin_o> but can't remember if -u was the work around or not
[15:00:13 CDT(-0500)] <Justin_o> heidi_: yes.. git add -u should have done it http://stackoverflow.com/questions/1402776/how-do-i-commit-all-deleted-files-in-git