Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: Migration of unmigrated content due to installation of a new plugin

...

[15:02:39 CDT(-0500)] <anastasiac> but I can't add a listener to onReady right in the fluid.uiOptions.prefsEditor() options block, cindyli

[15:03:01 CDT(-0500)] <cindyli> anastasiac: i'm coming over

[15:21:31 CDT(-0500)] <Justin_o> Bosmon: it is a bit of a problem.. first the slidingPanel is outside the scope of panels.. so if we want to use the functionality that I have just written, we will need to move it out somewhere more general. Perhaps it could be part of a new grade that the rendererComponent uses as a base grade 2) the sliding panel has an expectation of having a

[15:21:31 CDT(-0500)] <Justin_o> messageResolver, but it doesn't have one by default. I don't think.

[15:22:08 CDT(-0500)] <Bosmon> Justin_o - this can just be an additional dynamic grade supplied to the slidingPanel

[15:23:13 CDT(-0500)] <Bosmon> All it requires is 2 strings named "showText" and "hideText" in any case

[15:23:26 CDT(-0500)] <Bosmon> So this isn't going to break the abstraction bank : P

[15:23:33 CDT(-0500)] <Justin_o> Bosmon: i'm worried about this https://github.com/fluid-project/infusion/blob/master/src/components/slidingPanel/js/SlidingPanel.js#L32-L45

[15:23:41 CDT(-0500)] <Bosmon> Justin_o

[15:23:44 CDT(-0500)] <Bosmon> You can just override it!

[15:23:48 CDT(-0500)] <Bosmon> This is how configuration works : P

[15:24:18 CDT(-0500)] <Justin_o> that by default it expects a msgBundle.. but when it is out of the context of the preference framework it doesn't actually have one

[15:24:38 CDT(-0500)] <Bosmon> Justin_o ^

[15:24:49 CDT(-0500)] <Justin_o> Bosmon: ^ (smile)

[15:24:56 CDT(-0500)] <Bosmon> Justin_o ^ : P

[15:24:59 CDT(-0500)] <Bosmon> Configuration!

[15:25:00 CDT(-0500)] <Bosmon> Override!

[15:25:16 CDT(-0500)] <Justin_o> i can override, sure i just think the default configuration is broken as it stands

[15:25:35 CDT(-0500)] <Justin_o> that by default it should have plain strings and not expect the message bundle

[15:25:42 CDT(-0500)] <Bosmon> Oh yes, it may well be

[15:25:51 CDT(-0500)] <Bosmon> We should have sorted that out when we broke it out as a new component

[15:26:19 CDT(-0500)] <Justin_o> Bosmon: yes, very true.. okay... i'll take care of this with my changes for FLUID-5180 as well

[15:26:34 CDT(-0500)] <Bosmon> As well as its dreadful use of the hard-coded constant "400" etc.

[15:26:58 CDT(-0500)] <Bosmon> And its awful old-fashioned "finalInit" function etc.

[15:27:05 CDT(-0500)] <Bosmon> This one received very little attention during the upgrade

[15:28:11 CDT(-0500)] <Justin_o> Bosmon: yes.. it's a bit on the ancient side.. could use dome attention

[15:28:14 CDT(-0500)] <Justin_o> some