Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

[14:29:28 CDT(-0500)] <Bosmon> Hi Justin_o

[14:31:14 CDT(-0500)] <Justin_o> Bosmon: hello.. so i realized that i missed something in the protoTree rebasing which is to handle repeatingSelectors

[14:31:43 CDT(-0500)] <Justin_o> Bosmon: so I've fixed up the tree rebasing and etc. but the repeatingSelectors aren't showing up in my cutPoints

[14:32:05 CDT(-0500)] <Justin_o> Bosmon: i'm assuming this is because the flud.renderer.selectorsToCutpoints function is only run once during component initialization

[14:32:12 CDT(-0500)] <Bosmon> Justin_o - can you explain the problem further?

[14:32:25 CDT(-0500)] <Justin_o> but that's before i can move the repeatingSelectors from the subpanels up to the parent

[14:32:30 CDT(-0500)] <Justin_o> which i'm doing onCreate

[14:32:34 CDT(-0500)] <Justin_o> does that make sense

[14:32:58 CDT(-0500)] <Justin_o> basically i want to surface the repeatingSelectors option from the subPanels to the compositePanel and have it used for generating cutpoints

[14:33:03 CDT(-0500)] <Justin_o> Bosmon: ^

[14:33:22 CDT(-0500)] <Bosmon> Justin_o - in general doing anything useful during an onCreate method will be too late

[14:33:46 CDT(-0500)] <Bosmon> Anything related to a component's initialisation process should be expressed in a ginger way

[14:33:49 CDT(-0500)] <Bosmon> Increasingly in the future

[14:34:01 CDT(-0500)] <Bosmon> And the future is really sort of dating from now : P

[14:34:03 CDT(-0500)] <Justin_o> Bosmon: but if i make it an expander, you wouldn't be able to set the repeatingSelectors of the compostiePanel if it needs it's own rendering

[14:34:21 CDT(-0500)] <Bosmon> I already made some improvements to the RendererComponent workflow so that crucial things happen "on time"

[14:34:34 CDT(-0500)] <Bosmon> For example the fabrication of the "refreshView" method which used to be the source of numerous problems

[14:34:35 CDT(-0500)] <Justin_o> Bosmon: any suggestions for when to do this?

[14:34:42 CDT(-0500)] <Bosmon> You and cindyli may remember that we had to patch over this for some years

[14:34:58 CDT(-0500)] <Bosmon> Justin_o - nothing prevents the user from overriding your configuration

[14:35:04 CDT(-0500)] <Bosmon> But you will need to write it using an expander, yes

[14:35:07 CDT(-0500)] <Justin_o> Bosmon: yes.. much nicer now that the craziness i employed for decapod

[14:35:28 CDT(-0500)] <Justin_o> Bosmon: but if i put an expander there and the user overrides it, wont the expander be removed

[14:35:34 CDT(-0500)] <Bosmon> Justin_o - yes, it will

[14:35:45 CDT(-0500)] <kasparnet> Jess_, michelled: cool - talk to you tomorrow

[14:35:46 CDT(-0500)] <Justin_o> Bosmon: so that's the problem

[14:35:55 CDT(-0500)] <Bosmon> Justin_o - can you explain the usage model a bit further?

[14:36:12 CDT(-0500)] <Bosmon> You want to be able to get your cutpoints, but you want the user to be able to add further to them?

[14:36:17 CDT(-0500)] <Justin_o> Bosmon: i want to both be able to surface the repeatingSelectors from the subPanels and supply ones at the compositePanel level as well

[14:36:39 CDT(-0500)] <Bosmon> In that case you can write an invoker that computes the ones from the subpanels and call it from your expander

[14:36:41 CDT(-0500)] <Justin_o> Bosmon: pretty much yes.. other than this, you can specify rendering values at both levels

[14:36:42 CDT(-0500)] <Bosmon> And the user can too

[14:36:54 CDT(-0500)] <Bosmon> This will be a bit clunky, but this isn't "permanent infrastructure" anyway

[14:37:09 CDT(-0500)] <Bosmon> We can't really afford to engineer this solution better than we need (smile)

[14:37:20 CDT(-0500)] <Justin_o> Bosmon: that's true i guess.. it will be a hassle as you won't be able to just have it work like others

[14:38:04 CDT(-0500)] <Justin_o> Bosmon: would it be better to create my own cutpoint generation function that pulls values from both the repeatingSelectors field and some other option, like subPanelRepeatingSelectors

[14:38:07 CDT(-0500)] <Justin_o> ?

[14:39:35 CDT(-0500)] <Bosmon> Justin_o yes, you could do that

[14:39:56 CDT(-0500)] <Bosmon> It would be slightly less messy to have a new strangely named option that it would be to explain to users that they should write an expander that calls an invoker...

[14:39:57 CDT(-0500)] <Justin_o> okay.. let me give that a go and if it doesn't work i'll fall back to just using the expander

[14:40:13 CDT(-0500)] <Justin_o> cool

[14:56:46 CDT(-0500)] <Justin_o> Bosmon: looks like it worked, thanks

[15:02:35 CDT(-0500)] <Bosmon> Justin_o - good job (smile)

[15:03:43 CDT(-0500)] <Justin_o> Bosmon: thanks

[15:04:04 CDT(-0500)] <Justin_o> cindyli: i've updated my FLUID-5131 branch. It now supports repeatedSelectors

[15:04:21 CDT(-0500)] <cindyli> thanks, Justin_o, will merge in

[15:04:42 CDT(-0500)] <cindyli> Justin_o: i've fixed 5187 in my branch and pushed up

[17:31:50 CDT(-0500)] <jhernandez> colinclark: btw

[17:31:57 CDT(-0500)] <colinclark> hey

[17:32:03 CDT(-0500)] <jhernandez> how's that nexus?

[17:32:30 CDT(-0500)] <colinclark> I haven't made it much further yet

[17:32:38 CDT(-0500)] <colinclark> Travelling without much of an internet connection

[17:32:42 CDT(-0500)] <colinclark> I'm just about to get back to it

[17:33:03 CDT(-0500)] <jhernandez> ok ok

[17:33:54 CDT(-0500)] <jhernandez> so, when do you have to demo it?

[17:34:04 CDT(-0500)] <colinclark> tomororw

[17:34:07 CDT(-0500)] <colinclark> so I better get on it

[17:34:27 CDT(-0500)] <jhernandez> heh

[17:35:35 CDT(-0500)] <jhernandez> just in case that you don't succeed on building the apk

[17:36:00 CDT(-0500)] <colinclark> Yes, I'm a bit freaked out about it

[17:36:28 CDT(-0500)] <jhernandez> as an emergency plan, I can pass the apk and the js code to you

[17:36:58 CDT(-0500)] <jhernandez> (wink)

[20:38:29 CDT(-0500)] <colinclark> hey jhernandez, are you around?