Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

[12:59:40 CDT(-0500)] <colinclark> boss is on the phone

[13:28:48 CDT(-0500)] <colinclark> Bosmon: Ok. So a typed array is not a primitive object, but neither is it a plan object.

[13:29:06 CDT(-0500)] <colinclark> So what does that mean for the fate of said object within the merging system?

[13:30:06 CDT(-0500)] <Bosmon> colinclark - it is treated as if it is a primitive object, in fact

[13:30:27 CDT(-0500)] <Bosmon> At least, all of the current tests sites separately combine the predicates "isPrimitive" and "!isPlainObject"

[13:30:38 CDT(-0500)] <Bosmon> But the tests are broken out in case they end up being separately useful at some point

[14:05:54 CDT(-0500)] <colinclark> michelled, anastasiac: Here's my list: https://gist.github.com/colinbdclark/6815237

[14:06:11 CDT(-0500)] <colinclark> our list, rather (smile)

[16:06:59 CDT(-0500)] <Bosmon> Hi colinclark

[16:07:07 CDT(-0500)] <colinclark> oh Bosmon

[16:07:08 CDT(-0500)] <Bosmon> Did I manage to resolve your queries on isPlainObject?

[16:07:08 CDT(-0500)] <colinclark> hello

[16:07:24 CDT(-0500)] <colinclark> Yes, you certainly did

[16:07:43 CDT(-0500)] <Bosmon> cool

[16:08:00 CDT(-0500)] <colinclark> thank you

[16:08:07 CDT(-0500)] <colinclark> I'll push the code this evening

[16:08:09 CDT(-0500)] <Bosmon> yzen - did you check that your FLUID-5169 is not a duplicate of FLUID-5155 ?

[16:58:06 CDT(-0500)] <Bosmon> Thanks for the report and test case for FLUID-5169, yzen

[16:58:16 CDT(-0500)] <Bosmon> I've updated my FLUID-5155 to include test case and fix

[17:07:10 CDT(-0500)] <yzen> Bosmon: awesome

[17:07:12 CDT(-0500)] <yzen> (smile)