Page Comparison

[03:05:48 EST(-0500)] * andreauoc (~carlos@120.Red-213-96-26.staticIP.rima-tde.net) has joined #fluid-work
[04:59:10 EST(-0500)] * sveto (~sveto@62.44.108.2) has joined #fluid-work
[08:25:07 EST(-0500)] * justin_o (~jmo@142.150.154.101) has joined #fluid-work
[08:29:43 EST(-0500)] * andreauoc (~carlos@120.Red-213-96-26.staticIP.rima-tde.net) has left #fluid-work
[09:12:15 EST(-0500)] * justin_o (~jmo@142.150.154.101) has joined #fluid-work
[09:44:32 EST(-0500)] * justin_o (~jmo@142.150.154.101) has joined #fluid-work
[09:45:07 EST(-0500)] * justin_o (~jmo@142.150.154.101) has joined #fluid-work
[09:49:29 EST(-0500)] * anastasiac (~team@142.150.154.189) has joined #fluid-work
[09:56:45 EST(-0500)] * clown (~clown@142.150.154.101) has joined #fluid-work
[10:01:48 EST(-0500)] <anastasiac> Bosmon, Bosmon2: are you there?
[10:19:17 EST(-0500)] * laurel (~Laurel@142.150.154.178) has joined #fluid-work
[10:19:34 EST(-0500)] * laurel (~Laurel@142.150.154.178) has left #fluid-work
[10:30:47 EST(-0500)] * sveto (~sveto@62.44.108.2) has left #fluid-work
[10:58:10 EST(-0500)] * EricDalquist (~dalquist@2607:f388:e:0:221:9bff:fe37:e768) has joined #fluid-work
[11:26:25 EST(-0500)] * elicochran (~elicochra@70.137.137.123) has joined #fluid-work
[12:57:55 EST(-0500)] * colinclark (~colin@142.150.154.101) has joined #fluid-work
[13:41:58 EST(-0500)] * colinclark (~colin@142.150.154.101) has joined #fluid-work
[14:11:57 EST(-0500)] <anastasiac> Bosmon, Bosmon2: are you there?
[14:13:03 EST(-0500)] <Bosmon> Yes, I am here
[14:13:21 EST(-0500)] <anastasiac> Bosmon, your recent changes to fluid.model.setBeanValue() have caused my code to fail, but I'm not sure if it's a bug in getPenultimate() or if I'm using setBeanValue() wrong
[14:13:32 EST(-0500)] <Bosmon> Ok, that is interesting
[14:13:33 EST(-0500)] <anastasiac> I'm essentially doing this:
[14:13:47 EST(-0500)] <Bosmon> There may be some edge cases that behave differently that have fallen between the cracks in the tests
[14:13:51 EST(-0500)] <anastasiac> fluid.model.setBeanValue ({}, "fields.title", "new title");
[14:13:58 EST(-0500)] <Bosmon> Ah ok
[14:14:08 EST(-0500)] <Bosmon> That case should work, let me make a test case and fix it
[14:14:12 EST(-0500)] <anastasiac> thanks!
[14:15:05 EST(-0500)] <Bosmon> If you made a JIRA, it would be even more tasty
[14:15:26 EST(-0500)] <anastasiac> will do
[14:15:29 EST(-0500)] <Bosmon> tnx
[14:15:38 EST(-0500)] <anastasiac> I just wanted to confirm that it wasn't my bug first
[14:16:03 EST(-0500)] <Bosmon> Well, the behaviour on "blank paths" was never really specified
[14:16:22 EST(-0500)] <Bosmon> But there was actually a test case for the renderer that exposed exactly the same issue last night with getBeanValue() that I fixed up...
[14:17:34 EST(-0500)] <Bosmon> I mean, to be honest, it is not absolutely clear what kind of new object should be created... I guess if setBeanValue were really clever it would do things like looking if the upcoming path were a numeric index, and then try to guess that you were trying to make an array
[14:17:40 EST(-0500)] <Bosmon> But that would probably be going too far
[14:19:51 EST(-0500)] <anastasiac> well, it worked before... I guess the question is: should setBeanValue() be responsible for creating the necessary hierarchy?
[14:19:54 EST(-0500)] <anastasiac> fyi: http://issues.fluidproject.org/browse/FLUID-3489
[14:20:08 EST(-0500)] <Bosmon> Well, I guess it "should"
[14:20:22 EST(-0500)] <Bosmon> That had been the "semi-inadvertently" implemented behaviour so far
[14:20:32 EST(-0500)] <Bosmon>
[14:20:37 EST(-0500)] <anastasiac>
[14:21:21 EST(-0500)] <Bosmon> Thanks for the JIRA
[14:22:04 EST(-0500)] * colinclark (~colin@142.150.154.101) has joined #fluid-work
[17:21:37 EST(-0500)] * clown_afk (~clown@142.150.154.101) has left #fluid-work
[17:42:50 EST(-0500)] * anastasiac (~team@142.150.154.189) has left #fluid-work
[17:55:14 EST(-0500)] * EverettZ (~chatzilla@bas4-toronto06-1279277146.dsl.bell.ca) has joined #fluid-work
[17:56:36 EST(-0500)] <EverettZ> colinclark: Do you have a moment to make a recommendation on a Drupal problem if I give you a brief description?
[17:56:50 EST(-0500)] <colinclark> EverettZ: Sure, if I can. Fire away.
[17:58:17 EST(-0500)] <EverettZ> colinclark: In Drupal there are tables that have dragable rows that can be used to reorder the items in the table. With JS turned off in the browser there is a Weight column that can be used for reordering. The solution for non-mouse users is to provide a link to show the Weight column even when JS is turned on.
[17:58:38 EST(-0500)] <EverettZ> colinclark: Well, theoretically that link will be in Drupal 7.
[17:58:47 EST(-0500)] <colinclark> ok
[17:59:37 EST(-0500)] <EverettZ> colinclark: The question the usability people are asking is if that link can be shown only on focus. I have given reasons why this is not ideal (non-mouse, non-screen-reader, users will not know the link and functionality are present unless they accidentally tab past it and see it appear on screen).
[18:00:37 EST(-0500)] <EverettZ> colinclark: I have been asked if there are other accessible UI components out there that can be looked to for guidance on the decision about how to present this information to non-mouse, non-screen-reader, users.
[18:00:47 EST(-0500)] <EverettZ> colinclark: done
[18:01:39 EST(-0500)] <colinclark> EverettZ: Good question
[18:02:57 EST(-0500)] <colinclark> EverettZ: First, I totally agree with you about why hiding the link is really not a great option. As you say, sighted keyboard-only users will have no idea where to go.
[18:03:23 EST(-0500)] <EverettZ> colinclark: I was thinking that fluid reorder was analogous, special instructions needed by non-mouse users. But, I have never seen a live implementation of reorder. On the test pages instructions have been present, but that is not a comparable use-case.
[18:04:27 EST(-0500)] <colinclark> EverettZ: For sure. There have been plenty of live implementations of the Reorderer, but I don't know that they've all chosen to use the instructions we provide. Which is too bad, really.
[18:05:59 EST(-0500)] <EverettZ> colinclark: I wouldd imagine that the bare minimum instructions would not be to visibly intrusive. A link "Show weighted reordering". Or something such as that.
[18:06:05 EST(-0500)] <colinclark> EverettZ: Interestingly, I think there's still a learning curve for all sorts of users about drag and drop and other direct manipulation on the Web. So instructions aren't such a bad thing.
[18:06:30 EST(-0500)] <colinclark> I think what we've done in the Image Reorderer demo is decent, but should also include instructions for mouse users.
[18:06:31 EST(-0500)] <colinclark> http://build.fluidproject.org/infusion/demos/reorderer/imageReorderer/demo.html
[18:07:10 EST(-0500)] <colinclark> EverettZ: But you're right, a simple link should be sufficient for most users, especially if it's described in non-technical terms
[18:10:22 EST(-0500)] <EverettZ> colinclark: thanks for the help. Do you mind if I copy our conversation to the Drupal issue queue as a comment?
[18:10:46 EST(-0500)] <colinclark> EverettZ: Please, no problem.
[18:11:55 EST(-0500)] <EverettZ> colinclark: Thanks again. Drupal 7 is looking pretty good, my poorly informed oppinion being disconnected from the community for about 4 months.
[18:12:38 EST(-0500)] <colinclark> EverettZ: That's really good to hear