Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

[15:16:48 CDT(-0500)] <Bosmon> "Some functions" will be just fine : P

[15:17:13 CDT(-0500)] <Justin_o> Bosmon: is it worth changing?

[15:17:29 CDT(-0500)] <Bosmon> Well, it would save you a dozen lines or so (smile)

[15:18:10 CDT(-0500)] <Justin_o> (smile) okay i'll look into that

[15:18:29 CDT(-0500)] <Justin_o> Bosmon: i'm heading out now.. if you have more feedback please send it along and I'll start in on it tomorrow

[15:18:38 CDT(-0500)] <Bosmon> I think your other code looks pretty good

[15:18:47 CDT(-0500)] <Bosmon> I'd like to see this regex surfaced as a dedicated function

[15:18:48 CDT(-0500)] <Bosmon> prefObj[mdlPrefix + prefName.replace(/[.]/g, "_")] = rule;

[15:19:14 CDT(-0500)] <Bosmon> Especially since it seems you do a similar operation earlier in the code

[15:20:09 CDT(-0500)] <Justin_o> Bosmon: right i should clean that up