Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

[12:56:11 CDT(-0500)] <Justin_o> cindyli, anastasiac: yes.. it should probably be updated to use a model relay i guess. it's pretty old.. i wonder if this is something that needs to be done now though.. i think Bosmon was going to look at this when he starts the new model relay work

[12:56:40 CDT(-0500)] <anastasiac> booleans are ok, they're not dependent on "value"; I'm going to check the drop-down and radio buttons

[12:56:47 CDT(-0500)] <Justin_o> anastasiac: thanks for filing a jira

[12:56:47 CDT(-0500)] <anastasiac> but I suspect they'll be ok

[12:57:55 CDT(-0500)] <anastasiac> well, I'm not sure where the fix needs to go, but it's going to feel very weird to write documentation that says "you can call your model field whatever you like, unless you're using our textfieldSlider, then you must use 'value'"

[13:04:32 CDT(-0500)] <anastasiac> Justin_o, cindyli, I've added the JIRA to the iteration page http://issues.fluidproject.org/browse/FLUID-5190

[13:05:34 CDT(-0500)] <Justin_o> anastasiac: thanks.. i'm not 100% sure it's a blocker for 1.5 though.. but we can leave at that for now

[13:06:12 CDT(-0500)] <anastasiac> Justin_o, see my comment above, about the docs

[13:06:55 CDT(-0500)] <Justin_o> yes.. it is strange (sad)

[13:50:16 CDT(-0500)] <Justin_o> cindyli: i sent the pull request for FLUID-5131 and updated the jiras and iteration plan

[13:50:24 CDT(-0500)] <Justin_o> Bosmon: FLUID-5131 is ready for review

[13:50:40 CDT(-0500)] <cindyli> yay! thanks, Justin_o

[13:51:00 CDT(-0500)] <Justin_o> thank you cindyli

[13:56:40 CDT(-0500)] <Bosmon> Thanks, Justin_o

[13:57:21 CDT(-0500)] <Justin_o> Bosmon: thanks.. looking forward to your review.. also I updated the FLUID-5183 pull request and sent one off for FLUID-5186 too

[14:17:06 CDT(-0500)] <anastasiac> Justin_o, cindyli, is there any way for a panel to get access to the enum (for a dropdown) that's in the primary schema? Right now, the panel has to reproduce that enum in its controlValues option. It would be nice to avoid that duplication.

[14:18:33 CDT(-0500)] <Justin_o> anastasiac: they can get it from the preferenceMap. you can put a path into the options on the left side, with the key of the primary schema on the right.

[14:18:47 CDT(-0500)] <anastasiac> ah, ok, thanks Justin_o, I'll try that

[14:19:31 CDT(-0500)] <anastasiac> Justin_o, worked, thanks for the pointer

[14:49:59 CDT(-0500)] <Bosmon> Hi Justin_o - I'll be looking at your updated pulls now

[14:50:09 CDT(-0500)] <Bosmon> btw I have a fix in for the IE8 issue that you and cindyli discovered

[14:51:21 CDT(-0500)] <cindyli> thanks, Bosmon.

[14:52:55 CDT(-0500)] <Bosmon> In the end it was caused by the implementation of the new framework fluid.isPlainObject utility

[14:53:04 CDT(-0500)] <Bosmon> Which gives different results on IE8 to other browsers

[14:53:26 CDT(-0500)] <Bosmon> In particular, Object.prototype.toString.call(null) amazingly produces "[object Object]"