Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

[16:54:12 CDT(-0500)] <Bosmon> As well as "fluid.hasFeature"

[16:54:35 CDT(-0500)] <colinclark> I'm not yet convinced I want to promote fluid.hasFeature()

[16:54:42 CDT(-0500)] <colinclark> but it's certainly worth having a look

[16:54:48 CDT(-0500)] <Bosmon> It should be destroyed, rather than promoted, yes (smile)

[16:55:24 CDT(-0500)] <colinclark> I was going to ask alexn why he decided to hide the full screen button with CSS instead of using IoC to not create it at all

[16:55:27 CDT(-0500)] <colinclark> but perhaps that can be for tomorrow

[16:55:34 CDT(-0500)] <colinclark> and for a comment in the pull request