Page Comparison

[04:13:45 CDT(-0500)] * kasper (~kasper@0x5552c030.adsl.cybercity.dk) has joined #fluid-work
[07:32:44 CDT(-0500)] * Justin_o (~Justin@142.150.154.171) has joined #fluid-work
[07:48:09 CDT(-0500)] * colinclark (~colin@bas2-toronto09-1176444357.dsl.bell.ca) has joined #fluid-work
[07:56:13 CDT(-0500)] <colinclark> Justin_o: So I think DECA-70 is probably fixed now. We'd need to test it, but I believe the supported cameras check should prevent this issue.
[07:57:50 CDT(-0500)] <colinclark> Justin_o: We should probably ping the list about DECA-138 sooner rather than later. I think maybe jhung was going to take that one on?
[07:58:05 CDT(-0500)] <Justin_o> colinclark: okay... is the capture button itself disabled on page load?
[07:58:26 CDT(-0500)] <Justin_o> colinclark: yes... we should definitely check in on that
[07:58:34 CDT(-0500)] <Justin_o> for 138 that is
[07:59:02 CDT(-0500)] <colinclark> Justin_o: Interesting, Michael Cutter is just pinging me about it over IM
[07:59:06 CDT(-0500)] <colinclark> I'll relay what he says
[07:59:34 CDT(-0500)] <colinclark> For DECA-70, if I remember the code right, it should show the "no cameras" dialog once, and from then on prevent the button from doing anything interesting
[07:59:39 CDT(-0500)] <colinclark> But there could still be a bug
[07:59:56 CDT(-0500)] <Justin_o> colinclark: okay... we'll check it out today
[08:00:57 CDT(-0500)] <Justin_o> colinclark: also just to confirm, DECA-81 is finished?
[08:01:47 CDT(-0500)] <colinclark> Justin_o: Generally speaking, yes
[08:01:57 CDT(-0500)] <colinclark> If there is a specific size we want, that can be changed in the server quite easily
[08:02:13 CDT(-0500)] <colinclark> At the moment, I resized the unstitched images to a longest dimension of 900px
[08:02:32 CDT(-0500)] <Justin_o> jameswy: does that sound right ^
[08:02:48 CDT(-0500)] <colinclark> jameswy: I think that's what you had originally suggested, but I can't fully remember
[08:03:33 CDT(-0500)] <jameswy> colinclark, Justin_o: I think I suggested 640 or 800, but so long as it's easily changeable, that's totally fine.
[08:03:57 CDT(-0500)] <colinclark> Ok. I'll tell you guys where in the code it leaves
[08:04:02 CDT(-0500)] <colinclark> lives
[08:04:17 CDT(-0500)] <colinclark> And for the record, it lives in the worst spot possible, but that is on my todo list for 0.5
[08:04:18 CDT(-0500)] <colinclark>
[08:04:57 CDT(-0500)] <Justin_o>
[08:06:01 CDT(-0500)] <colinclark> Ok, jameswy and Justin_o
[08:06:11 CDT(-0500)] <colinclark> In imageprocessing.py, there is a method called medium()
[08:06:22 CDT(-0500)] <colinclark> Medium hard codes a longest dimension of 900 px
[08:06:38 CDT(-0500)] <colinclark> Change that to 800 or 640, and you're ready to go
[08:06:55 CDT(-0500)] <colinclark> jameswy: This is for the main image of the page spread in the Capture page, just to be clear
[08:07:05 CDT(-0500)] <colinclark> For calibration the images are 640 px at their longest
[08:08:10 CDT(-0500)] <colinclark> Which still causes some styling issues
[08:09:12 CDT(-0500)] <Justin_o> colinclark: thanks...
[08:11:13 CDT(-0500)] <colinclark> Justin_o: I had hoped to add the "tidy up" code to the install scripts today
[08:11:19 CDT(-0500)] <colinclark> Do you think that counts as "code cleanup"
[08:11:22 CDT(-0500)] <colinclark> ?
[08:12:00 CDT(-0500)] <colinclark> Or am I stretching that definition?
[08:12:21 CDT(-0500)] <Justin_o> yep i'd guess it would count.. we also added refactoring to it
[08:16:17 CDT(-0500)] <colinclark> ok, thanks
[08:29:40 CDT(-0500)] * michelled (~michelled@142.150.154.141) has joined #fluid-work
[08:34:54 CDT(-0500)] * jhung (~Jon@H58.C206.cci.switchworks.net) has joined #fluid-work
[08:43:50 CDT(-0500)] * yura_ (~yura@142.150.154.163) has joined #fluid-work
[08:47:24 CDT(-0500)] * colinclark_ (~colin@bas2-toronto09-1176444357.dsl.bell.ca) has joined #fluid-work
[08:48:15 CDT(-0500)] * mackrauss (~Armin@142.150.154.103) has joined #fluid-work
[08:48:20 CDT(-0500)] * mackrauss (~Armin@142.150.154.103) has left #fluid-work
[08:54:24 CDT(-0500)] * EricDalquist (~dalquist@2607:f388:e:0:221:9bff:fe37:e768) has joined #fluid-work
[08:59:55 CDT(-0500)] * clown (~clown@142.150.154.103) has joined #fluid-work
[09:08:49 CDT(-0500)] * sgithens (~sgithens@149-166-10-223.dhcp-in.iupui.edu) has joined #fluid-work
[09:19:11 CDT(-0500)] * laurel (~laurel@dsl-173-206-89-50.tor.primus.ca) has joined #fluid-work
[09:53:32 CDT(-0500)] * bsparks (~bsparks@wsip-72-215-204-133.ph.ph.cox.net) has joined #fluid-work
[10:00:11 CDT(-0500)] * jhung1 (~decapod@H58.C206.cci.switchworks.net) has joined #fluid-work
[10:16:56 CDT(-0500)] <jhung> justin_o: I've pushed changes to server.decapod.googlecode.com. But when I pull from decapod.googlecode.com, the changes are not there. Any idea why?
[10:21:00 CDT(-0500)] * jhung2 (~Jon@H58.C206.cci.switchworks.net) has joined #fluid-work
[10:21:09 CDT(-0500)] * jhung3 (~decapod@H58.C206.cci.switchworks.net) has joined #fluid-work
[10:32:27 CDT(-0500)] * Justin_o (~Justin@142.150.154.171) has joined #fluid-work
[10:43:55 CDT(-0500)] <Justin_o> jhung: were you able to get the default repo working?
[10:52:23 CDT(-0500)] * jhung1 (~decapod@H22.C196.cci.switchworks.net) has joined #fluid-work
[10:52:28 CDT(-0500)] * jhung2 (~Jon@H22.C196.cci.switchworks.net) has joined #fluid-work
[10:56:22 CDT(-0500)] <Justin_o> jameswy: i've pushed your changes into the master
[11:38:44 CDT(-0500)] * jhung (~Jon@H22.C196.cci.switchworks.net) has joined #fluid-work
[11:55:41 CDT(-0500)] * bsparks1 (~bsparks@wsip-72-215-204-133.ph.ph.cox.net) has joined #fluid-work
[12:00:01 CDT(-0500)] * athena (~athena@c-76-121-97-221.hsd1.wa.comcast.net) has joined #fluid-work
[12:33:18 CDT(-0500)] * jhung2 (~Jon@H233.C205.cci.switchworks.net) has joined #fluid-work
[12:34:52 CDT(-0500)] * jhung3 (~decapod@H233.C205.cci.switchworks.net) has joined #fluid-work
[12:37:19 CDT(-0500)] * Justin_o (~Justin@142.150.154.171) has joined #fluid-work
[12:51:52 CDT(-0500)] <jhung> justin_o: ping
[13:06:57 CDT(-0500)] * michelled (~michelled@142.150.154.141) has joined #fluid-work
[13:18:15 CDT(-0500)] <Justin_o> jhung: hello
[13:19:09 CDT(-0500)] <jhung> justin_o there's a problem with the image rotation with respect to scaling within the 300x300 container.
[13:20:16 CDT(-0500)] <Justin_o> okay... what seems to be the problem
[13:20:20 CDT(-0500)] <jhung> It's impossible without javascript to know which edge of the image is longest, and therefore scale to fit the container.
[13:20:29 CDT(-0500)] <Justin_o> interesting
[13:20:41 CDT(-0500)] <jhung> So at best, using CSS, I can scale one edge to fit the container.
[13:20:52 CDT(-0500)] <jhung> If we're lucky, that edge is the long edge.
[13:21:04 CDT(-0500)] <Justin_o> i'll try to see what we did in engage to handle this, because we didn't know there either, the dimensions of the image
[13:21:09 CDT(-0500)] <jhung> If we're not lucky, the short edge is scaled to fit, but the long edge overflows.
[13:21:16 CDT(-0500)] <jhung> But...
[13:21:22 CDT(-0500)] <jhung> There's another problem.
[13:21:25 CDT(-0500)] <Justin_o> okay
[13:22:13 CDT(-0500)] <jhung> nevermind.
[13:22:35 CDT(-0500)] <jhung> I thought maybe we'd have a problem when we rotate, but that shouldn't be the case.
[13:22:56 CDT(-0500)] <Justin_o> jhung: okay... that's good... can you set a max width and a max height on it
[13:23:23 CDT(-0500)] <jhung> yes. But doing that will stretch the aspect ratio to fit the container.
[13:23:35 CDT(-0500)] <Justin_o> really
[13:23:36 CDT(-0500)] <Justin_o> hmm
[13:24:25 CDT(-0500)] <jhung> So I have an idea... but it requires adding some code to the thumbnail generation, and perhaps only specific to the calibration.
[13:25:16 CDT(-0500)] <jhung> Use imagemagick to resize the image to fit 640x640 and pad the empty space with white.
[13:25:35 CDT(-0500)] <jhung> That way we always have a square image and it doesn't matter which edge is scaled.
[13:26:14 CDT(-0500)] <jhung> Otherwise we can add presentation javascript that determines the long edge and scales it appropriately.
[13:26:24 CDT(-0500)] <jhung> Rather go without javascript if possible.
[13:26:48 CDT(-0500)] <Justin_o> jhung: yes probably better to not use code where possible
[13:27:17 CDT(-0500)] <Justin_o> I just tried in firebug to set a max-height: 300px; and max-width: 300px and it seemed to scale and keep the aspect ratio
[13:30:50 CDT(-0500)] <jhung> justin_o: hmmm... that's weird because that's not what I'm getting on my end. Did you just specify max-width and max-height? Did you add any other attributes?
[13:31:12 CDT(-0500)] <Justin_o> jhung: nope... do you want to screen share or something...
[13:31:47 CDT(-0500)] * laurel (~laurel@dsl-173-206-89-50.tor.primus.ca) has joined #fluid-work
[13:32:42 CDT(-0500)] <jhung> I'll try. Not sure if Skype on ubuntu has that
[13:34:37 CDT(-0500)] <jhung> justin_o: hop onto skype and we'll try this.
[13:34:56 CDT(-0500)] <Justin_o> sorry... did realize i wasn't on skype
[13:37:03 CDT(-0500)] * bsparks (~bsparks@wsip-72-215-204-133.ph.ph.cox.net) has joined #fluid-work
[14:10:48 CDT(-0500)] <Justin_o> jhung, jameswy: I just tested clicking export when there were no captures done. It will generate a pdf file with no pages
[14:10:57 CDT(-0500)] <jameswy> Justin_o: nice!
[14:11:43 CDT(-0500)] <jhung> jhung: doh
[14:12:56 CDT(-0500)] <jhung> justin_o, jameswy: DECA-129 fix now in repo. New images ahoy!
[14:16:14 CDT(-0500)] <Justin_o> jhung: that's great... thanks...
[14:16:29 CDT(-0500)] <Justin_o> jhung, jameswy: so i guess i should look at disabling the export button then
[14:17:41 CDT(-0500)] <jhung> justin_o: yeah.
[14:31:53 CDT(-0500)] <Justin_o> jhung: just tried out the new capture images... they are showing up horizontal instead of vertical... is that correct?
[14:32:54 CDT(-0500)] <jhung> Yes on the UI because of sticthing rotation
[14:33:35 CDT(-0500)] <Justin_o> jhung: okay.. thanks
[14:33:40 CDT(-0500)] <jhung> justin_o, but export should look okay because we don't use the stitched images for exporting, right?
[14:34:09 CDT(-0500)] <Justin_o> okay... i'll try running an export and see what happens.. and yes i believe we don't use the stitched images for export
[14:34:39 CDT(-0500)] <Justin_o> jhung: the exported versions look fine
[15:36:18 CDT(-0500)] * jhung (~Jon@H233.C205.cci.switchworks.net) has left #fluid-work