Page Comparison

[08:33:56 CST(-0600)] <jhung> heidi_: I'm cleaning up the CSS we did on the Grid Reorderer to be simpler. I'll post a patch in a few mins.
[08:34:12 CST(-0600)] <heidi_> jhung cool was just going to ping you about that - did you figure out the drop marker?
[08:36:19 CST(-0600)] <jhung> heidi: I haven't gotten there yet, but I don't think that will be a problem.
[09:10:20 CST(-0600)] <heidi_> hey mlam did your fix for the IE/unclickable area thing get committed yet? did you set it to 16px ?
[09:11:00 CST(-0600)] <mlam> hey heidi_: no, it hasn't been committed yet , and I'll set the px height to 16px now
[09:12:29 CST(-0600)] <heidi_> ok cool, i'm going to make it look better in IE
[09:12:39 CST(-0600)] <heidi_> for FLUID-3860
[09:13:12 CST(-0600)] <mlam> ok, cool
[09:14:06 CST(-0600)] <heidi_> mlam can you ping me when the patch is up? just want to make sure i have the exact same as you
[09:14:13 CST(-0600)] <mlam> yup, for sure
[09:15:24 CST(-0600)] <mlam> heidi_: do you remember the jira that i posted under?
[09:16:26 CST(-0600)] <mlam> actually, it's ok, i have it now
[09:16:31 CST(-0600)] <heidi_> k
[09:17:51 CST(-0600)] <mlam> heidi_: it's on the JIRA now
[09:18:12 CST(-0600)] <heidi_> mlam what's the number?
[09:18:14 CST(-0600)] <mlam> http://issues.fluidproject.org/browse/FLUID-3635
[09:18:15 CST(-0600)] <mlam> haha
[09:18:17 CST(-0600)] <heidi_> hehe thanks
[09:18:22 CST(-0600)] <mlam> np
[09:26:48 CST(-0600)] <jhung> heidi_: new patch attached to http://issues.fluidproject.org/browse/FLUID-3870. Review please?
[09:27:10 CST(-0600)] <heidi_> will do jhung
[09:29:59 CST(-0600)] <heidi_> jhung looks good , i'll check IE too
[09:30:08 CST(-0600)] <jhung> Thanks!
[09:31:16 CST(-0600)] <heidi_> jhung there's some weirdness with dragging stuff
[09:31:22 CST(-0600)] <heidi_> trying to put a letter in the corner is tricky
[09:31:30 CST(-0600)] <jhung> hmmm...
[09:31:49 CST(-0600)] <heidi_> specifically top right corner
[09:31:56 CST(-0600)] <heidi_> vs how you put it in the bottom right
[09:32:14 CST(-0600)] <jhung> heidi: Really? Works fine for me in IE8. Which IE you using?
[09:32:18 CST(-0600)] <heidi_> FF
[09:32:23 CST(-0600)] <jhung> oh
[09:32:38 CST(-0600)] <heidi_> jhung : top right = drop line has to be before
[09:32:41 CST(-0600)] <jhung> works okay for me.
[09:32:45 CST(-0600)] <heidi_> bottom right = drop line has to be after
[09:33:36 CST(-0600)] <heidi_> see what i mean?
[09:33:37 CST(-0600)] <jhung> Heidi: that's how it is.
[09:33:48 CST(-0600)] <jhung> heidi: reorderer has always been like that.
[09:33:52 CST(-0600)] <heidi_> howcome drop line after last letter doesn't work?
[09:34:10 CST(-0600)] <heidi_> er, before
[09:34:13 CST(-0600)] <jhung> heidi: check the image reorderer demo. It will do the same thing in the corners.
[09:34:24 CST(-0600)] <heidi_> jhung isn't that weird?
[09:34:26 CST(-0600)] <jhung> heidi: skype? I think we're seeing the same thing.
[09:34:27 CST(-0600)] <heidi_> just wondering
[09:34:31 CST(-0600)] <heidi_> sure one sec
[10:21:03 CST(-0600)] <heidi_> jhung on IE the grid demo is a little funny - can i screen share with you? or do you have IE8?
[10:21:48 CST(-0600)] <jhung> sure
[10:40:41 CST(-0600)] <jhung> heidi_: I'm going to have to run a few errands before the blizzard hits. I'll ping you when I'm back.
[10:40:49 CST(-0600)] <heidi_> cool
[10:41:15 CST(-0600)] <colinclark> totally rejected at standup today
[10:41:20 CST(-0600)] <colinclark> But my update is really simple
[10:41:29 CST(-0600)] <colinclark> Uploader all day today
[10:41:47 CST(-0600)] <mlam> haha
[10:41:52 CST(-0600)] <colinclark> Worked from home this morning to try to push everything else-emails, etc.-out of the way for Uploader
[10:42:00 CST(-0600)] <colinclark> Into the office shortly. All Uploader, all the time.
[10:42:26 CST(-0600)] <colinclark> Spent some time this weekend working with Gregg Vanderheiden, Jutta, and Jess on the European NPII-related grant. That's it.
[10:52:42 CST(-0600)] <Justin_o> colinclark: thanks for the update
[12:19:32 CST(-0600)] <heidi_> hey jhung i added some notes to the jira re: ie8 issues
[12:20:08 CST(-0600)] <jhung> heidi_: cool. I'll take a look in a min.
[12:33:21 CST(-0600)] <jhung> heidi: what jira #s are they?
[12:39:18 CST(-0600)] <jhung> heidi: nevermind. I thought you made new jiras.
[12:51:22 CST(-0600)] <jhung> heidi_: I'm doing some changes to the markup. Changing the <p>s to <divs>. May help with the hovering issues.
[12:51:48 CST(-0600)] <heidi_> k
[13:03:36 CST(-0600)] <jhung> heidi: I did some experimenting, and it seems it doesn't matter if the movable elements are div, li, or p's.
[13:04:03 CST(-0600)] <jhung> However, the List reorderer demo doesn't have problems in IE.
[13:04:19 CST(-0600)] <jhung> So makes we wonder...
[13:04:46 CST(-0600)] <heidi_> perhaps we have to tweak the focus style jhung to only apply to certain elements
[13:05:14 CST(-0600)] <jhung> yeah. Will try that now heidi_
[13:05:51 CST(-0600)] <heidi_> mlam that fix isn't working for my IE... i still gets no padding, even tho i can alert the padding and it says 16px. argh
[13:06:20 CST(-0600)] <mlam> didn't it work late last week?
[13:06:42 CST(-0600)] <heidi_> mlam i feel like it did but maybe there was some other thing we tweaked as well???
[13:06:57 CST(-0600)] <heidi_> cos it's not now... ie makes me crazay
[13:07:23 CST(-0600)] <mlam> that was the only tweak we made to make to the textEditbutton visible on an empty inline edit in IE8
[13:07:38 CST(-0600)] <mlam> it's still visible on my IE8
[13:07:49 CST(-0600)] <heidi_> mlam i think it has to be explicity made block for the padding to work
[13:07:56 CST(-0600)] <heidi_> and for some reason it's not now
[13:08:15 CST(-0600)] <heidi_> did we take out any block stuff?
[13:08:37 CST(-0600)] <mlam> no, we left all the block styling in
[13:09:04 CST(-0600)] <heidi_> if i add componentThat.viewEI.css('display', 'block'); after yr 16px thing it works
[13:09:11 CST(-0600)] <heidi_> oyyy
[13:09:52 CST(-0600)] <heidi_> ill try a fresh checkout cos it could be weird cache stuff
[13:09:53 CST(-0600)] <mlam>
[13:09:55 CST(-0600)] <heidi_> thanks mlam
[13:10:29 CST(-0600)] <mlam> yeah, it could be....are u still having inconsistencies between your's and jhung's version?
[13:10:31 CST(-0600)] <mlam> np
[13:11:02 CST(-0600)] <heidi_> mlam the inconsistency was that my browser was set to 'compatibility view'
[13:11:07 CST(-0600)] <heidi_> whatever that means !
[13:11:16 CST(-0600)] <heidi_> when i turned that off it behaved the same
[13:12:45 CST(-0600)] <mlam> ahh i see
[13:12:57 CST(-0600)] <jhung> heidi_: I'm going to send up a patch shortly.
[13:13:07 CST(-0600)] <jhung> still having IE oddities.
[13:13:11 CST(-0600)] <heidi_> jhung cool ill give it a spin when yr ready
[13:13:18 CST(-0600)] <jhung> mostly selection and hover styling in IE8
[13:13:49 CST(-0600)] <heidi_> jhung i noticed the pointer issue was for all browsers (doesn't change for selected items)
[13:14:27 CST(-0600)] <jhung> heidi_: okay. But there is still the issue where the point doesn't change to "move" until hovering over the actual letters.
[13:15:34 CST(-0600)] <jhung> heidi_: new patch up. Notice changes from p to li, and the addition of :focus styling (the li:focus isn't working well, but the :focus override fixes those black focus lines appearing in IE8).
[13:15:58 CST(-0600)] <colinclark> jameswy and Justin_o: I wouldn't mind showing Dr. Chuck a few cool things a bit later if you guys have time
[13:16:03 CST(-0600)] <heidi_> jhung ill check it out in a bit... hey can you actually try mike's patch on your IE?
[13:16:11 CST(-0600)] <colinclark> maybe Engage and the design work we're doing for FLOE
[13:16:18 CST(-0600)] <heidi_> jhung it's on this jira http://issues.fluidproject.org/browse/FLUID-3635
[13:16:19 CST(-0600)] <jameswy> colinclark: Sure thing.
[13:16:24 CST(-0600)] <colinclark> maybe the HTML 5 Uploader, too, mlam
[13:16:32 CST(-0600)] <Justin_o> colinclark: okay
[13:16:43 CST(-0600)] <colinclark> nothing big
[13:17:28 CST(-0600)] <mlam> sure
[13:20:37 CST(-0600)] <jhung> mlam: I applied the patch. I get a hover and a pointer change, but clicking doesn't do anything.
[13:21:55 CST(-0600)] <mlam> the clickable area for the empty inline edit is very small since there is no text. where in the empty inline edit are you clicking?
[13:26:35 CST(-0600)] <Justin_o> colinclark, michelled: so i'm looking at implementing the changes to the tooltip plugin that we have talked about... basically creating a wrapper.. so i'm trying to figure out how to create a single tooltip...
[13:27:03 CST(-0600)] <Justin_o> but they are created off of a dom element, which when receiving focus, will show the tooltip
[13:27:15 CST(-0600)] <jhung> mlam: the no invitation text field on the manual test.
[13:27:36 CST(-0600)] <jhung> mlam: duuuur.
[13:27:37 CST(-0600)] <Justin_o> i figure if there is only one tooltip, i will have to manually trigger the open and close calls when specific elements receive focus...
[13:27:48 CST(-0600)] <Justin_o> but how do i attach the tooltip?
[13:28:02 CST(-0600)] <mlam> jhung, this is still IE8, right?
[13:28:17 CST(-0600)] <jhung> mlam: I'm stupid. Of course nothing will happen! The patch is on my local machine and I'm testing on the build server.
[13:28:21 CST(-0600)] * jhung smacks head
[13:28:26 CST(-0600)] <mlam> sweet!
[13:28:41 CST(-0600)] <jhung> going to test again now
[13:29:15 CST(-0600)] <michelled> Justin_o: what happens if you attach it to the container that holds all the links?
[13:29:18 CST(-0600)] <jhung> mlam: works!
[13:29:23 CST(-0600)] <mlam> ok, cool
[13:29:39 CST(-0600)] <michelled> Justin_o: or were you trying to get a single tooltip for the entire page?
[13:29:40 CST(-0600)] <Justin_o> michelled: i would suspect that when any part of the container recieves focus that the tooltip would appear
[13:30:32 CST(-0600)] <michelled> I suppose that's what we'd want however I doubt it would do the right thing when it already has focus and a different link is selected
[13:31:07 CST(-0600)] <Justin_o> michelled: i suppose it would move to the last position
[13:31:16 CST(-0600)] <Justin_o> to the latest focused item
[13:34:02 CST(-0600)] <mlam> heidi_: any luck?
[13:34:45 CST(-0600)] <heidi_> reading... jhung so mlam's patch worked for you?
[13:34:57 CST(-0600)] <jhung> heidi_: yep
[13:35:06 CST(-0600)] <heidi_> jhung what if you enter a space
[13:35:24 CST(-0600)] <jhung> still works
[13:35:39 CST(-0600)] <heidi_> well that's good - wish my IE would behave
[13:35:41 CST(-0600)] <heidi_> !
[13:35:52 CST(-0600)] <jhung> hmmm... that doesn
[13:35:52 CST(-0600)] <heidi_> if i enter a space, i lose a clickable area
[13:36:05 CST(-0600)] <jhung> 't sound good.
[13:36:10 CST(-0600)] <jhung> weird.
[13:36:25 CST(-0600)] <heidi_> i'm going to restart my Vm and clear caches etc and see
[13:36:30 CST(-0600)] <heidi_> if it's just something off
[13:37:01 CST(-0600)] <jhung> k
[13:49:51 CST(-0600)] <heidi_> jhung mlam still no luck, only with space. stumped
[13:49:58 CST(-0600)] <heidi_> i think it's a block issue w/ IE
[13:56:24 CST(-0600)] <harriswong> jhung, Justin_o: I have attached a patch for FLUID-3848, including the changes to the anchor titles fix for pager related to aria-sort. Also includes an associated testcase. Patch @ http://issues.fluidproject.org/browse/FLUID-3848
[13:56:59 CST(-0600)] <Justin_o> harriswong: thanks
[13:57:13 CST(-0600)] <jhung> harris. thanks. Will check it out in a bit.
[13:57:18 CST(-0600)] <Justin_o> harriswong: we still have to write some e-mails out to those screen reader vendors
[14:05:08 CST(-0600)] <mlam> heidi_: once the block is in, everything works swimmingly for you?
[14:05:49 CST(-0600)] <heidi_> mlam ya... just figuring out why it's not on
[14:06:19 CST(-0600)] <mlam> oh ok
[14:06:26 CST(-0600)] <jhung> heidi_: I figured out the problem.
[14:06:32 CST(-0600)] <heidi_> oh??
[14:06:58 CST(-0600)] <jhung> For whatever reason I had put opacity on the movable items. Removing opacity fixes it.
[14:07:14 CST(-0600)] <jhung> So I just need to put opacity on drag only and I think we're set.
[14:08:18 CST(-0600)] <heidi_> jhung ah cool
[14:08:38 CST(-0600)] <heidi_> let me know when patch is up and ill check it. gonna hang out in inline edit zone for a bit more to try and figure this out...
[14:13:27 CST(-0600)] <heidi_> justin_o is this no longer for bug parade? http://issues.fluidproject.org/browse/FLUID-3868
[14:17:50 CST(-0600)] <Bosmon> Wow.... this is so weird.... I had forgotten that my FLUID-3681 branch actually dates from before we had IoC
[14:18:08 CST(-0600)] <Bosmon> It seems I was trying to implement grading and options before merging in IoC at all.....
[14:19:44 CST(-0600)] <Justin_o> heidi_: I don't think i got around to adding that one on... but can't remember.. is it something that is fixable... i think if it is going to be too much work it is something we could live with for this release.. i'm not jameswy would agree with me though
[14:20:35 CST(-0600)] <heidi_> justin_o i'd only worry that removing block and replacing with inline would cause unforeseen problems, last minute as the code/css is pretty delicate
[14:21:46 CST(-0600)] <Justin_o> heidi_: that sounds like a good reason to hold off of it for this release...
[14:24:27 CST(-0600)] <jhung> heidi_: patch uploaded.
[14:24:49 CST(-0600)] <jhung> heidi_: the one thing I don't like is the :focus override.
[14:25:41 CST(-0600)] <heidi_> jhung k ill check it out
[14:28:42 CST(-0600)] <harriswong> Bosmon: are you working on FLUID-3707?
[14:49:44 CST(-0600)] <heidi_> jhung still no borders or focus in my IE
[14:50:22 CST(-0600)] <heidi_> but the pointer issue looks fixed
[14:52:08 CST(-0600)] <jhung> heidi: really? harriswong, can you help test patch 6 http://issues.fluidproject.org/browse/FLUID-3870
[14:52:21 CST(-0600)] <jhung> harriswong, You're using Windows right?
[14:52:47 CST(-0600)] <heidi_> jhung i can show you on screen share
[14:52:52 CST(-0600)] <heidi_> there's no select style either
[14:53:33 CST(-0600)] <jhung> k
[14:53:46 CST(-0600)] <harriswong> jhung: yes i am on windows. i will test on my ie8
[14:53:54 CST(-0600)] <jhung> harriswong: thanks!
[14:59:31 CST(-0600)] <jhung> harriswong: we're looking for borders around the items when the demo is loaded, and consistent focus styling when dragging and dropping.
[14:59:53 CST(-0600)] <jhung> the focus style is a 2px border, whereas the default state is a 1px border.
[15:00:23 CST(-0600)] <harriswong> jhung: just applied the patch, checking into the borders now.
[15:00:32 CST(-0600)] <jhung> thanks!
[15:02:25 CST(-0600)] <harriswong> jhung: on load, 1px #ccc on elements A to I; on drag/focus, 2px #000
[15:02:59 CST(-0600)] <harriswong> jhung: IE7 however gives me no borders, both on drag/focus/load
[15:03:24 CST(-0600)] <harriswong> heidi_: i think you might be on "compatibility view"
[15:03:34 CST(-0600)] <heidi_> harriswong naw i turned it off
[15:03:41 CST(-0600)] <jhung> hrm.
[15:03:48 CST(-0600)] <heidi_> OH
[15:03:58 CST(-0600)] <heidi_> now i see it
[15:04:07 CST(-0600)] <heidi_> i restarted my browser and turned compat view off again and it worked
[15:04:07 CST(-0600)] <jhung> ?
[15:04:13 CST(-0600)] <heidi_> OH IE
[15:04:20 CST(-0600)] <harriswong> heidi_:
[15:04:23 CST(-0600)] <jhung> lol
[15:04:31 CST(-0600)] <heidi_> it likes to torture me
[15:04:54 CST(-0600)] <heidi_> jhung looks awesome now
[15:05:03 CST(-0600)] <jhung> harriswong: okay. Thanks for testing.
[15:05:27 CST(-0600)] <harriswong> jhung: np, anytime~
[15:05:38 CST(-0600)] <jhung> heidi_: cool. I guess I'll commit the changes then.
[15:05:50 CST(-0600)] <heidi_> cool, phew
[15:06:07 CST(-0600)] <colinclark> hey jameswy, do you have time for a quick question
[15:06:17 CST(-0600)] <jameswy> colinclark: Yep, what's up.
[15:06:30 CST(-0600)] <colinclark> I'm working on the Uploader's progressive enhancement features
[15:06:36 CST(-0600)] <colinclark> So, here's a quick summary
[15:06:41 CST(-0600)] <colinclark> IE doesn't support multiple file uploads
[15:07:01 CST(-0600)] <colinclark> FF4, Chrome and Safari 4+ do support it beautifully
[15:07:15 CST(-0600)] <colinclark> FF3.6 supports it decently, but with limits on how big the file can be
[15:07:21 CST(-0600)] <colinclark> FF 3.5 almost supports it
[15:07:38 CST(-0600)] <colinclark> it seems that the one limitation is that it doesn't support multiple files being selected in the OS chooser dialog
[15:07:50 CST(-0600)] <colinclark> So, this is a fairly big edge case, since we don't formally support FF3.5 any more
[15:07:53 CST(-0600)] <colinclark> but it's always nice to try
[15:08:01 CST(-0600)] <colinclark> So, do you think it's better to;
[15:08:24 CST(-0600)] <colinclark> 1. Give the user an all-HTML Uploader, but they will have to select files one at a time, clicking "Add More" each time
[15:08:37 CST(-0600)] <colinclark> 2. Give them the Flash version?
[15:09:00 CST(-0600)] <colinclark> I imagine the number of FF3.5 users is pretty slim by now
[15:09:48 CST(-0600)] <jameswy> So, to clarify, the question is what to do for FF3.5 users specifically?
[15:09:56 CST(-0600)] <jameswy> And IE users?
[15:10:01 CST(-0600)] <colinclark> yes
[15:10:04 CST(-0600)] <colinclark> IE users will get the Flash version
[15:10:09 CST(-0600)] <colinclark> Just FF3.5 specifically
[15:10:18 CST(-0600)] <colinclark> everyone else will get the best we can offer them
[15:10:25 CST(-0600)] <colinclark> it's just the FF3.5 is sort of in between
[15:10:40 CST(-0600)] <jameswy> Right.
[15:13:36 CST(-0600)] <jameswy> This is a tricky question, and there's probably decent justification for either way.
[15:13:36 CST(-0600)] <jameswy> I'd vote for an HTML uploader, relying on "add more" to add files one at a time, in an effort to ween off of Flash.
[15:14:18 CST(-0600)] <colinclark> lol
[15:14:30 CST(-0600)] <colinclark> jameswy: That was my vote, too
[15:14:37 CST(-0600)] <colinclark> let's try it and see how it goes
[15:14:51 CST(-0600)] <colinclark> It also happens to be easier to implement, which is appealing
[15:15:08 CST(-0600)] <jameswy>
[15:23:10 CST(-0600)] <jhung> justin_o: http://issues.fluidproject.org/browse/FLUID-3870 is ready for review.
[15:24:22 CST(-0600)] <Justin_o> jhung: thanks...
[15:27:42 CST(-0600)] <jhung> harriswong: I'll take a look at your patch tonight http://issues.fluidproject.org/browse/FLUID-3848.
[15:27:57 CST(-0600)] <jhung> justin_o: assuming http://issues.fluidproject.org/browse/FLUID-3848 is okay, would this mean pager is in a semi-stable state?
[15:28:24 CST(-0600)] <Justin_o> jhung: yes.. except for the tooltip, which may still undergo some changes...
[15:28:25 CST(-0600)] <harriswong> jhung: thanks~ if 3848 is ok, i think 3849 and 3850 can be closed along with it. Need justin_o to confirm.
[15:30:01 CST(-0600)] <Justin_o> harriswong: probably correct, we do also need to e-mail some AT Vendors about aria-sort still
[15:30:41 CST(-0600)] <jhung> justin_o: FLUID-3600 and FLUID-3580 requires somewhat stable markup to close. Will the fixes to the tooltip affect the markup?
[15:31:06 CST(-0600)] <Justin_o> jhung: i don't think so
[15:31:27 CST(-0600)] <Justin_o> i believe it will be a code thing and it shouldn't, hopefully, affect the end user experience
[15:31:37 CST(-0600)] <jhung> Justin_o: great. I'll try to get those closed off tonight or tomorrow morning.
[15:32:05 CST(-0600)] <Justin_o> jhung: thanks.. i'm going to be leaving shortly i hope, could you update me tomorrow of the state of those things